diff mbox series

[1/2] gobi: Use LOW_POWER instead of PERSIST_LOW_POWER

Message ID 20240430173817.3044-1-denkenz@gmail.com (mailing list archive)
State Accepted
Commit 75ba0c33e3e3017ff861bef263b7c725efa4483e
Headers show
Series [1/2] gobi: Use LOW_POWER instead of PERSIST_LOW_POWER | expand

Commit Message

Denis Kenzior April 30, 2024, 5:37 p.m. UTC 
PERSIST_LOW_POWER setting is supposed to tell the device that it should
not enter online state at the next bootup.  Unfortunately, no USB
devices tested seem to honor this setting.

Telit devices in particular will turn off the SIM and become unusable
until set back into online mode.  Use low-power instead of persistent
low power state instead.  AlwaysOnline support is now no longer needed.
---
 plugins/gobi.c   | 4 ++--
 plugins/udevng.c | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

patchwork-bot+ofono@kernel.org May 1, 2024, 9 p.m. UTC | #1 
Hello:

This series was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:

On Tue, 30 Apr 2024 12:37:34 -0500 you wrote:
> PERSIST_LOW_POWER setting is supposed to tell the device that it should
> not enter online state at the next bootup.  Unfortunately, no USB
> devices tested seem to honor this setting.
> 
> Telit devices in particular will turn off the SIM and become unusable
> until set back into online mode.  Use low-power instead of persistent
> low power state instead.  AlwaysOnline support is now no longer needed.
> 
> [...]

Here is the summary with links:
  - [1/2] gobi: Use LOW_POWER instead of PERSIST_LOW_POWER
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=75ba0c33e3e3
  - [2/2] udevng: Add support for Telit FN990
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=e41785fbd397

You are awesome, thank you!
diff mbox series

Patch

diff --git a/plugins/gobi.c b/plugins/gobi.c
index 550ce78733f5..39c1ab81fa56 100644
--- a/plugins/gobi.c
+++ b/plugins/gobi.c
@@ -226,7 +226,7 @@  static void get_oper_mode_cb(struct qmi_result *result, void *user_data)
 	switch (data->oper_mode) {
 	case QMI_DMS_OPER_MODE_ONLINE:
 		param = qmi_param_new_uint8(QMI_DMS_PARAM_OPER_MODE,
-					QMI_DMS_OPER_MODE_PERSIST_LOW_POWER);
+					QMI_DMS_OPER_MODE_LOW_POWER);
 		if (!param) {
 			shutdown_device(modem);
 			return;
@@ -480,7 +480,7 @@  static int gobi_disable(struct ofono_modem *modem)
 		goto out;
 
 	param = qmi_param_new_uint8(QMI_DMS_PARAM_OPER_MODE,
-					QMI_DMS_OPER_MODE_PERSIST_LOW_POWER);
+					QMI_DMS_OPER_MODE_LOW_POWER);
 	if (!param)
 		return -ENOMEM;
 
diff --git a/plugins/udevng.c b/plugins/udevng.c
index b9d115f16b7d..243dcd6e91ec 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -850,7 +850,6 @@  static gboolean setup_telitqmi(struct modem_info *modem)
 		return FALSE;
 
 	ofono_modem_set_boolean(modem->modem, "ForceSimLegacy", TRUE);
-	ofono_modem_set_boolean(modem->modem, "AlwaysOnline", TRUE);
 
 	return TRUE;
 }