[v2,03/33] qmi: Drop unused major/minor information

Commit Message

Denis Kenzior June 18, 2024, 8:01 p.m. UTC

QMI radio-settings, ussd and voicecall atoms request and store the
service version major/minor numbers, but never use this information.
Remove this functionality until needed.
---
 drivers/qmimodem/radio-settings.c | 4 ----
 drivers/qmimodem/ussd.c           | 3 ---
 drivers/qmimodem/voicecall.c      | 4 ----
 3 files changed, 11 deletions(-)

Patch

diff --git a/drivers/qmimodem/radio-settings.c b/drivers/qmimodem/radio-settings.c
index 8463c84bf1ed..cf0b747eb681 100644
--- a/drivers/qmimodem/radio-settings.c
+++ b/drivers/qmimodem/radio-settings.c
@@ -21,8 +21,6 @@ 
 struct settings_data {
 	struct qmi_service *nas;
 	struct qmi_service *dms;
-	uint16_t major;
-	uint16_t minor;
 };
 
 static void get_system_selection_pref_cb(struct qmi_result *result,
@@ -211,8 +209,6 @@  static int qmi_radio_settings_probev(struct ofono_radio_settings *rs,
 	data->dms = dms;
 	data->nas = nas;
 
-	qmi_service_get_version(data->nas, &data->major, &data->minor);
-
 	ofono_radio_settings_set_data(rs, data);
 
 	return 0;
diff --git a/drivers/qmimodem/ussd.c b/drivers/qmimodem/ussd.c
index 6637ae759c55..51c3aaef7a19 100644
--- a/drivers/qmimodem/ussd.c
+++ b/drivers/qmimodem/ussd.c
@@ -24,8 +24,6 @@ 
 
 struct ussd_data {
 	struct qmi_service *voice;
-	uint16_t major;
-	uint16_t minor;
 };
 
 static int validate_ussd_data(const struct qmi_ussd_data *data, uint16_t size)
@@ -156,7 +154,6 @@  static int qmi_ussd_probe(struct ofono_ussd *ussd,
 	data = l_new(struct ussd_data, 1);
 	data->voice = voice;
 
-	qmi_service_get_version(data->voice, &data->major, &data->minor);
 	qmi_service_register(data->voice, QMI_VOICE_USSD_IND,
 					async_ind, ussd, NULL);
 	qmi_service_register(data->voice, QMI_VOICE_ASYNC_ORIG_USSD,
diff --git a/drivers/qmimodem/voicecall.c b/drivers/qmimodem/voicecall.c
index c7a5230f9680..aed662da7ef6 100644
--- a/drivers/qmimodem/voicecall.c
+++ b/drivers/qmimodem/voicecall.c
@@ -24,8 +24,6 @@ 
 
 struct voicecall_data {
 	struct qmi_service *voice;
-	uint16_t major;
-	uint16_t minor;
 	struct l_queue *call_list;
 	struct ofono_phone_number dialed;
 	char *full_dtmf;
@@ -721,8 +719,6 @@  static int qmi_voicecall_probe(struct ofono_voicecall *vc,
 	data->voice = voice;
 	data->call_list = l_queue_new();
 
-	qmi_service_get_version(data->voice, &data->major, &data->minor);
-
 	qmi_service_register(data->voice, QMI_VOICE_ALL_CALL_STATUS_IND,
 				all_call_status_ind, vc, NULL);