| Message ID | 20240711164654.1688558-1-denkenz@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,01/11] udevng: Remove gps from setup_gobi | expand |
Hello: This series was applied to ofono.git (master) by Denis Kenzior <denkenz@gmail.com>: On Thu, 11 Jul 2024 11:46:18 -0500 you wrote: > From: Steve Schrock <steve.schrock@getcruise.com> > > Even when the gps variable was set, it was not actually used for > anything. > --- > plugins/udevng.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) Here is the summary with links: - [v2,01/11] udevng: Remove gps from setup_gobi (no matching commit) - [v2,02/11] build: Require at least version 0.67 when building with external ELL (no matching commit) - [v2,03/11] Release 2.9 (no matching commit) - [v2,04/11] gobi: Limit number of premultiplexed contexts to 4 (no matching commit) - [v2,05/11] gobi: Request dedicated WDS services for contexts (no matching commit) - [v2,06/11] qmi: Enable _auto_ use for some classes (no matching commit) - [v2,07/11] qmi: gprs-context: Declare qmi_service objects using _auto_ (no matching commit) - [v2,08/11] qmi: Pass two dedicated WDS services to gprs-context (no matching commit) - [v2,09/11] qmi: gprs-context: Remove parsing of unused TLVs (no matching commit) - [v2,10/11] qmi: gprs-context: Treat IP family TLV as mandatory (no matching commit) - [v2,11/11] qmi: gprs-context: Set up WDS service for IPv6 https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=c09e6bebe703 You are awesome, thank you!
diff --git a/plugins/udevng.c b/plugins/udevng.c index 8e116c6605ea..1c56e2ea62d3 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -355,7 +355,6 @@ static gboolean setup_gobi(struct modem_info *modem) { const struct device_info *qmi = NULL; const struct device_info *net = NULL; - const char *gps = NULL; GSList *list; DBG("%s", modem->syspath); @@ -373,23 +372,12 @@ static gboolean setup_gobi(struct modem_info *modem) qmi = info; else if (g_strcmp0(subsystem, "net") == 0) /* wwan */ net = info; - else if (g_strcmp0(subsystem, "tty") == 0) { - if (g_strcmp0(info->interface, "255/255/255") == 0) { - if (g_strcmp0(info->number, "03") == 0) - gps = info->devnode; /* gobi */ - } else if (g_strcmp0(info->interface, "255/0/0") == 0) { - if (g_strcmp0(info->number, "01") == 0) - gps = info->devnode; /* ec20 */ - /* ignore the 3rd device second AT/mdm iface */ - } - } } if (qmi == NULL || net == NULL) return FALSE; - DBG("qmi=%s net=%s gps=%s", - qmi->devnode, get_ifname(net), gps); + DBG("qmi=%s net=%s", qmi->devnode, get_ifname(net)); if (setup_qmi_qmux(modem, qmi, net) < 0) return FALSE;
From: Steve Schrock <steve.schrock@getcruise.com> Even when the gps variable was set, it was not actually used for anything. --- plugins/udevng.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-)