| Message ID | 20181109234526.4280-1-ayman.bagabas@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Huawei laptops | expand |
On Sat, Nov 10, 2018 at 1:45 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote: > Thanks for an updated version. I have pushed this to my review and testing queue, however, I would wait till Taskashi ACKs the last two patches in the series. Meanwhile you may rename the files to follow the pattern (<VENDOR>-wmi.c etc). > Changes from v3: > * Code formatting > > Changes from v2: > * Support for Huawei MBX > * Style and formating issues > > [PATCH v3 1/3] > The first patch adds support for missing hotkeys on some models. > > [PATCH v3 2/3] > This one enables the front speakers on the Huawei Matebook X Pro (MBXP). This > solves bug 200501 https://bugzilla.kernel.org/show_bug.cgi?id=200501 > It simply uses the pins configurations generated by hdajackretast using the > settings posted on the bug page https://imgur.com/a/N1xsCVZ > > [PATCH v3 3/3] > This enables the micmute LED on Huawei laptops with these IDs: > 1. Matebook X (19e5:3200) > 2. Matebook X (19e5:3201) > 3. Matebook X Pro (19e5:3204) > > > Ayman Bagabas (3): > x86: add support for Huawei WMI hotkeys. > ALSA: hda: fix front speakers on Huawei MBXP. > ALSA: hda: add support for Huawei WMI micmute LED > > drivers/platform/x86/Kconfig | 10 + > drivers/platform/x86/Makefile | 1 + > drivers/platform/x86/huawei_wmi.c | 215 +++++++++++++++++++ > include/linux/platform_data/x86/huawei_wmi.h | 9 + > sound/pci/hda/huawei_wmi_helper.c | 47 ++++ > sound/pci/hda/patch_realtek.c | 30 +++ > 6 files changed, 312 insertions(+) > create mode 100644 drivers/platform/x86/huawei_wmi.c > create mode 100644 include/linux/platform_data/x86/huawei_wmi.h > create mode 100644 sound/pci/hda/huawei_wmi_helper.c > > -- > 2.17.2 >
On Sat, Nov 10, 2018 at 4:17 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sat, Nov 10, 2018 at 1:45 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote: > > > > Thanks for an updated version. > > I have pushed this to my review and testing queue, however, I would > wait till Taskashi ACKs the last two patches in the series. > Meanwhile you may rename the files to follow the pattern (<VENDOR>-wmi.c etc). To clarify, I'm talking here of the files regarding to PDx86. Whatever scheme is used in ALSA I don't care. > > Changes from v3: > > * Code formatting > > > > Changes from v2: > > * Support for Huawei MBX > > * Style and formating issues > > > > [PATCH v3 1/3] > > The first patch adds support for missing hotkeys on some models. > > > > [PATCH v3 2/3] > > This one enables the front speakers on the Huawei Matebook X Pro (MBXP). This > > solves bug 200501 https://bugzilla.kernel.org/show_bug.cgi?id=200501 > > It simply uses the pins configurations generated by hdajackretast using the > > settings posted on the bug page https://imgur.com/a/N1xsCVZ > > > > [PATCH v3 3/3] > > This enables the micmute LED on Huawei laptops with these IDs: > > 1. Matebook X (19e5:3200) > > 2. Matebook X (19e5:3201) > > 3. Matebook X Pro (19e5:3204) > > > > > > Ayman Bagabas (3): > > x86: add support for Huawei WMI hotkeys. > > ALSA: hda: fix front speakers on Huawei MBXP. > > ALSA: hda: add support for Huawei WMI micmute LED > > > > drivers/platform/x86/Kconfig | 10 + > > drivers/platform/x86/Makefile | 1 + > > drivers/platform/x86/huawei_wmi.c | 215 +++++++++++++++++++ > > include/linux/platform_data/x86/huawei_wmi.h | 9 + > > sound/pci/hda/huawei_wmi_helper.c | 47 ++++ > > sound/pci/hda/patch_realtek.c | 30 +++ > > 6 files changed, 312 insertions(+) > > create mode 100644 drivers/platform/x86/huawei_wmi.c > > create mode 100644 include/linux/platform_data/x86/huawei_wmi.h > > create mode 100644 sound/pci/hda/huawei_wmi_helper.c > > > > -- > > 2.17.2 > > > > > -- > With Best Regards, > Andy Shevchenko