[platform,0/4] Fixes for issues with coverity, locking, redundant checks

Message

Vadim Pasternak Aug. 23, 2022, 8:19 p.m. UTC

The patch set includes fixes for several issues:
Patch #1: fixes coverity issue.
Patch #2: fixes locking dependency issue.
Patches #3-#4: remove unnecessary code.

Vadim Pasternak (4):
  platform/mellanox: mlxreg-lc: Fix coverity warning
  platform/mellanox: mlxreg-lc: Fix locking issue
  platform/mellanox: Remove unnecessary code
  platform/mellanox: Remove redundant 'NULL' check

 drivers/platform/mellanox/mlxreg-lc.c | 53 ++++++++++++++++-----------
 1 file changed, 31 insertions(+), 22 deletions(-)

Comments

Hans de Goede Sept. 1, 2022, 12:46 p.m. UTC | #1

Hi All,

On 8/23/22 22:19, Vadim Pasternak wrote:
> The patch set includes fixes for several issues:
> Patch #1: fixes coverity issue.
> Patch #2: fixes locking dependency issue.
> Patches #3-#4: remove unnecessary code.

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

I will also send this out as part of my next fixes
pull-req for 6.0-rc#.

Note I do have one code-style remark to patch 2/4,
since I want to add this to my fixes pull-req I've
taken 2/4 as is. Please send a follow-up (incremental)
patch addressing the code-style issue. See my reply
to patch 2/4.

Regards,

Hans


> 
> Vadim Pasternak (4):
>   platform/mellanox: mlxreg-lc: Fix coverity warning
>   platform/mellanox: mlxreg-lc: Fix locking issue
>   platform/mellanox: Remove unnecessary code
>   platform/mellanox: Remove redundant 'NULL' check
> 
>  drivers/platform/mellanox/mlxreg-lc.c | 53 ++++++++++++++++-----------
>  1 file changed, 31 insertions(+), 22 deletions(-)
>