| Message ID | 20240624111519.15652-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | i2c-i801 / dell-lis3lv02d: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d | expand |
On Monday 24 June 2024 13:15:12 Hans de Goede wrote: > Hans de Goede (6): > i2c: core: Setup i2c_adapter runtime-pm before calling device_add() > i2c: i801: Use a different adapter-name for IDF adapters > platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to > dell-smo8800-ids.h > platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client > from i2c-i801 to dell-lis3lv02d > platform/x86: dell-smo8800: Add a couple more models to > lis3lv02d_devices[] > platform/x86: dell-smo8800: Add support for probing for the > accelerometer i2c address Patches 1-5 looks good. There are just a few minor things, but you can add Reviewed-by: Pali Rohár <pali@kernel.org> For patch 6 as I mentioned previously I'm strictly against this change until somebody goes and politely ask Dell about the current situation of the discovering of accelerometer's i2c address. And if there is no other option than start discussion if Dell can include this information into DMI / ACPI / WMI or other part of firmware data which they can send from BIOS/UEFI to operating system. > drivers/i2c/busses/i2c-i801.c | 133 +------- > drivers/i2c/i2c-core-base.c | 18 +- > drivers/platform/x86/dell/Makefile | 1 + > drivers/platform/x86/dell/dell-lis3lv02d.c | 331 +++++++++++++++++++ > drivers/platform/x86/dell/dell-smo8800-ids.h | 26 ++ > drivers/platform/x86/dell/dell-smo8800.c | 16 +- > 6 files changed, 379 insertions(+), 146 deletions(-) > create mode 100644 drivers/platform/x86/dell/dell-lis3lv02d.c > create mode 100644 drivers/platform/x86/dell/dell-smo8800-ids.h > > -- > 2.45.1 >
Hi, On 6/24/24 8:28 PM, Pali Rohár wrote: > On Monday 24 June 2024 13:15:12 Hans de Goede wrote: >> Hans de Goede (6): >> i2c: core: Setup i2c_adapter runtime-pm before calling device_add() >> i2c: i801: Use a different adapter-name for IDF adapters >> platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to >> dell-smo8800-ids.h >> platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client >> from i2c-i801 to dell-lis3lv02d >> platform/x86: dell-smo8800: Add a couple more models to >> lis3lv02d_devices[] >> platform/x86: dell-smo8800: Add support for probing for the >> accelerometer i2c address > > Patches 1-5 looks good. There are just a few minor things, but you can add > Reviewed-by: Pali Rohár <pali@kernel.org> Thank you. > For patch 6 as I mentioned previously I'm strictly against this change > until somebody goes and politely ask Dell about the current situation of > the discovering of accelerometer's i2c address. Dell is on the Cc and not responding... > And if there is no other > option than start discussion if Dell can include this information into > DMI / ACPI / WMI or other part of firmware data which they can send from > BIOS/UEFI to operating system. AFAIK newer Dell laptops don't have a freefall sensor anymore since everything has moved to nvme. Even the bigger laptops seems to simply have multiple nvme slots rather then room for a 2.5" HDD. Note I did not research this, this is is my observation from 3 newer Dell laptops which I have access to. Regards, Hans >> drivers/i2c/busses/i2c-i801.c | 133 +------- >> drivers/i2c/i2c-core-base.c | 18 +- >> drivers/platform/x86/dell/Makefile | 1 + >> drivers/platform/x86/dell/dell-lis3lv02d.c | 331 +++++++++++++++++++ >> drivers/platform/x86/dell/dell-smo8800-ids.h | 26 ++ >> drivers/platform/x86/dell/dell-smo8800.c | 16 +- >> 6 files changed, 379 insertions(+), 146 deletions(-) >> create mode 100644 drivers/platform/x86/dell/dell-lis3lv02d.c >> create mode 100644 drivers/platform/x86/dell/dell-smo8800-ids.h >> >> -- >> 2.45.1 >> >
On Wednesday 03 July 2024 12:58:01 Hans de Goede wrote: > Hi, > > On 6/24/24 8:28 PM, Pali Rohár wrote: > > On Monday 24 June 2024 13:15:12 Hans de Goede wrote: > >> Hans de Goede (6): > >> i2c: core: Setup i2c_adapter runtime-pm before calling device_add() > >> i2c: i801: Use a different adapter-name for IDF adapters > >> platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to > >> dell-smo8800-ids.h > >> platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client > >> from i2c-i801 to dell-lis3lv02d > >> platform/x86: dell-smo8800: Add a couple more models to > >> lis3lv02d_devices[] > >> platform/x86: dell-smo8800: Add support for probing for the > >> accelerometer i2c address > > > > Patches 1-5 looks good. There are just a few minor things, but you can add > > Reviewed-by: Pali Rohár <pali@kernel.org> > > Thank you. > > > For patch 6 as I mentioned previously I'm strictly against this change > > until somebody goes and politely ask Dell about the current situation of > > the discovering of accelerometer's i2c address. > > Dell is on the Cc and not responding... And what do you expecting here? That somebody on the group address specified in CC list would react to all your tons of messages? Not mentioning the fact that you did not even ask anything. This is not how things works. If you do not change your attitude here then I highly doubt that somebody will respond to you. I have feeling that you are doing it on purpose just because you do not want to do anything, and trying to find some kind of proof that nobody is responding to you, to convince others for merge your last hack change. > > And if there is no other > > option than start discussion if Dell can include this information into > > DMI / ACPI / WMI or other part of firmware data which they can send from > > BIOS/UEFI to operating system. > > AFAIK newer Dell laptops don't have a freefall sensor anymore since > everything has moved to nvme. Even the bigger laptops seems to simply > have multiple nvme slots rather then room for a 2.5" HDD. Note I did not > research this, this is is my observation from 3 newer Dell laptops which > I have access to. > > Regards, > > Hans > > > > > >> drivers/i2c/busses/i2c-i801.c | 133 +------- > >> drivers/i2c/i2c-core-base.c | 18 +- > >> drivers/platform/x86/dell/Makefile | 1 + > >> drivers/platform/x86/dell/dell-lis3lv02d.c | 331 +++++++++++++++++++ > >> drivers/platform/x86/dell/dell-smo8800-ids.h | 26 ++ > >> drivers/platform/x86/dell/dell-smo8800.c | 16 +- > >> 6 files changed, 379 insertions(+), 146 deletions(-) > >> create mode 100644 drivers/platform/x86/dell/dell-lis3lv02d.c > >> create mode 100644 drivers/platform/x86/dell/dell-smo8800-ids.h > >> > >> -- > >> 2.45.1 > >> > > >
Hi Pali, On 7/3/24 8:41 PM, Pali Rohár wrote: > On Wednesday 03 July 2024 12:58:01 Hans de Goede wrote: >> Hi, >> >> On 6/24/24 8:28 PM, Pali Rohár wrote: >>> On Monday 24 June 2024 13:15:12 Hans de Goede wrote: >>>> Hans de Goede (6): >>>> i2c: core: Setup i2c_adapter runtime-pm before calling device_add() >>>> i2c: i801: Use a different adapter-name for IDF adapters >>>> platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to >>>> dell-smo8800-ids.h >>>> platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client >>>> from i2c-i801 to dell-lis3lv02d >>>> platform/x86: dell-smo8800: Add a couple more models to >>>> lis3lv02d_devices[] >>>> platform/x86: dell-smo8800: Add support for probing for the >>>> accelerometer i2c address >>> >>> Patches 1-5 looks good. There are just a few minor things, but you can add >>> Reviewed-by: Pali Rohár <pali@kernel.org> >> >> Thank you. >> >>> For patch 6 as I mentioned previously I'm strictly against this change >>> until somebody goes and politely ask Dell about the current situation of >>> the discovering of accelerometer's i2c address. >> >> Dell is on the Cc and not responding... > > And what do you expecting here? That somebody on the group address > specified in CC list would react to all your tons of messages? Not > mentioning the fact that you did not even ask anything. You keep on repeating this since I first posted this patch in December last year, but as I already wrote back then: https://lore.kernel.org/platform-driver-x86/8b3946e0-7eb5-4e1f-9708-1f6cfda95e1a@redhat.com/ "Unfortunately I no longer have any contacts inside Dell" And Paul Menzel reached out back to gkh back then asking if Greg had any contacts in he did not have any contacts either. Dell.Client.Kernel@dell.com is the official address listed for Dell drivers under drivers/platform/x86 . > This is not how things works. The email address which I'm using is *THE* one which Dell has provided for contacting about Dell pdx86 drivers. I really don't know what else you expect me to do here. You just keep repeating that Dell should be contacted about this and multiple people (me and Andy) have already pointed out that Dell does not have any other contact info. Repeating the same remark over and over does not change things. As I mentioned in my other email too, if you think you can do better feel free to try and contact Dell your self, something which you could already have done the first time you mentioned this in December 2023, back when I already said I don't have any other contact info for Dell. > If you do not change your attitude here then I highly doubt that > somebody will respond to you. > > I have feeling that you are doing it on purpose just because you do not > want to do anything, and trying to find some kind of proof that nobody > is responding to you, to convince others for merge your last hack change. This is just plain hurtful I do not believe I have ever done anything to earn this level of distrust from you. I am hurt that you cannot at least show the common decency to assume good intentions from my side. Regards, Hans
On 7/3/24 8:41 PM, Pali Rohár wrote: > On Wednesday 03 July 2024 12:58:01 Hans de Goede wrote: >> Hi, >> >> On 6/24/24 8:28 PM, Pali Rohár wrote: >>> On Monday 24 June 2024 13:15:12 Hans de Goede wrote: >>>> Hans de Goede (6): >>>> i2c: core: Setup i2c_adapter runtime-pm before calling device_add() >>>> i2c: i801: Use a different adapter-name for IDF adapters >>>> platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to >>>> dell-smo8800-ids.h >>>> platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client >>>> from i2c-i801 to dell-lis3lv02d >>>> platform/x86: dell-smo8800: Add a couple more models to >>>> lis3lv02d_devices[] >>>> platform/x86: dell-smo8800: Add support for probing for the >>>> accelerometer i2c address >>> >>> Patches 1-5 looks good. There are just a few minor things, but you can add >>> Reviewed-by: Pali Rohár <pali@kernel.org> >> >> Thank you. >> >>> For patch 6 as I mentioned previously I'm strictly against this change >>> until somebody goes and politely ask Dell about the current situation of >>> the discovering of accelerometer's i2c address. >> >> Dell is on the Cc and not responding... > > And what do you expecting here? That somebody on the group address > specified in CC list would react to all your tons of messages? Not > mentioning the fact that you did not even ask anything. > > This is not how things works. > > If you do not change your attitude here then I highly doubt that > somebody will respond to you. > > I have feeling that you are doing it on purpose just because you do not > want to do anything, and trying to find some kind of proof that nobody > is responding to you, to convince others for merge your last hack change. p.s. This is not a hack, please stop with this nonsense about how this is a hack and super dangerous. It is neither. Probing for i2c-addresses is something which the kernel has done since the 199x years. The whole i2c-core has infrastructure for drivers to indicate which addresses they want the core to probe for them. This is used by a lot of hwmon i2c drivers since hwmon chips typically are not described in the ACPI tables. So userspace manually modprobes these (after a sensors-detect run setting up the config) and then when loaded the core will call these drivers detect() callback for the addresses listed in their i2c_driver struct. People using these driver are having the i2c-addresses listed in these drivers probed (on adapters which indicate they support probing like i2c-i801) every single boot! Regards, Hans >>> And if there is no other >>> option than start discussion if Dell can include this information into >>> DMI / ACPI / WMI or other part of firmware data which they can send from >>> BIOS/UEFI to operating system. >> >> AFAIK newer Dell laptops don't have a freefall sensor anymore since >> everything has moved to nvme. Even the bigger laptops seems to simply >> have multiple nvme slots rather then room for a 2.5" HDD. Note I did not >> research this, this is is my observation from 3 newer Dell laptops which >> I have access to. >> >> Regards, >> >> Hans >> >> >> >> >>>> drivers/i2c/busses/i2c-i801.c | 133 +------- >>>> drivers/i2c/i2c-core-base.c | 18 +- >>>> drivers/platform/x86/dell/Makefile | 1 + >>>> drivers/platform/x86/dell/dell-lis3lv02d.c | 331 +++++++++++++++++++ >>>> drivers/platform/x86/dell/dell-smo8800-ids.h | 26 ++ >>>> drivers/platform/x86/dell/dell-smo8800.c | 16 +- >>>> 6 files changed, 379 insertions(+), 146 deletions(-) >>>> create mode 100644 drivers/platform/x86/dell/dell-lis3lv02d.c >>>> create mode 100644 drivers/platform/x86/dell/dell-smo8800-ids.h >>>> >>>> -- >>>> 2.45.1 >>>> >>> >> >
On Thursday 04 July 2024 12:17:27 Hans de Goede wrote: > Hi Pali, > > On 7/3/24 8:41 PM, Pali Rohár wrote: > > On Wednesday 03 July 2024 12:58:01 Hans de Goede wrote: > >> Hi, > >> > >> On 6/24/24 8:28 PM, Pali Rohár wrote: > >>> On Monday 24 June 2024 13:15:12 Hans de Goede wrote: > >>>> Hans de Goede (6): > >>>> i2c: core: Setup i2c_adapter runtime-pm before calling device_add() > >>>> i2c: i801: Use a different adapter-name for IDF adapters > >>>> platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to > >>>> dell-smo8800-ids.h > >>>> platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client > >>>> from i2c-i801 to dell-lis3lv02d > >>>> platform/x86: dell-smo8800: Add a couple more models to > >>>> lis3lv02d_devices[] > >>>> platform/x86: dell-smo8800: Add support for probing for the > >>>> accelerometer i2c address > >>> > >>> Patches 1-5 looks good. There are just a few minor things, but you can add > >>> Reviewed-by: Pali Rohár <pali@kernel.org> > >> > >> Thank you. > >> > >>> For patch 6 as I mentioned previously I'm strictly against this change > >>> until somebody goes and politely ask Dell about the current situation of > >>> the discovering of accelerometer's i2c address. > >> > >> Dell is on the Cc and not responding... > > > > And what do you expecting here? That somebody on the group address > > specified in CC list would react to all your tons of messages? Not > > mentioning the fact that you did not even ask anything. > > You keep on repeating this since I first posted this patch > in December last year, but as I already wrote back then: Yes, because you have not done anything and you are just repeating those nonsenses. What are you expecting? You are either doing all this on purpose or you are just lazy and think that somebody (e.g. me) would do this stuff. > https://lore.kernel.org/platform-driver-x86/8b3946e0-7eb5-4e1f-9708-1f6cfda95e1a@redhat.com/ > > "Unfortunately I no longer have any contacts inside Dell" > > And Paul Menzel reached out back to gkh back then asking > if Greg had any contacts in he did not have any contacts > either. > > Dell.Client.Kernel@dell.com is the official address listed > for Dell drivers under drivers/platform/x86 . Perfect. And may you explain why you have not tried to contact them with addressed requests of exact information of what you need and ask for help? You wrote tons of emails with zero value. > > This is not how things works. > > The email address which I'm using is *THE* one which Dell has > provided for contacting about Dell pdx86 drivers. I really > don't know what else you expect me to do here. > > You just keep repeating that Dell should be contacted about > this and multiple people (me and Andy) have already pointed > out that Dell does not have any other contact info. Repeating > the same remark over and over does not change things. > > As I mentioned in my other email too, if you think you can do > better feel free to try and contact Dell your self, something I'm not your servant and I'm not going to play role of your secretary. > which you could already have done the first time you mentioned > this in December 2023, back when I already said I don't have > any other contact info for Dell. Could you stop complaining? I'm really not interested in your stories why you are not wanted to do anything. > > If you do not change your attitude here then I highly doubt that > > somebody will respond to you. > > > > I have feeling that you are doing it on purpose just because you do not > > want to do anything, and trying to find some kind of proof that nobody > > is responding to you, to convince others for merge your last hack change. > > This is just plain hurtful I do not believe I have ever done > anything to earn this level of distrust from you. Then read your message again. Now it is more clear that you are doing it on purpose. > I am hurt that you cannot at least show the common decency to > assume good intentions from my side. I hope that I do not have to explain you how to find contact address in MAINTAINERS file, how to write an addressed email for target audience, how to formulate questions and how to ask for information. And how to do it in _one_ message. > Regards, > > Hans > >
Hi, On 7/4/24 5:54 PM, Pali Rohár wrote: > On Thursday 04 July 2024 12:17:27 Hans de Goede wrote: >> Hi Pali, >> >> On 7/3/24 8:41 PM, Pali Rohár wrote: >>> On Wednesday 03 July 2024 12:58:01 Hans de Goede wrote: >>>> Hi, >>>> >>>> On 6/24/24 8:28 PM, Pali Rohár wrote: >>>>> On Monday 24 June 2024 13:15:12 Hans de Goede wrote: >>>>>> Hans de Goede (6): >>>>>> i2c: core: Setup i2c_adapter runtime-pm before calling device_add() >>>>>> i2c: i801: Use a different adapter-name for IDF adapters >>>>>> platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to >>>>>> dell-smo8800-ids.h >>>>>> platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client >>>>>> from i2c-i801 to dell-lis3lv02d >>>>>> platform/x86: dell-smo8800: Add a couple more models to >>>>>> lis3lv02d_devices[] >>>>>> platform/x86: dell-smo8800: Add support for probing for the >>>>>> accelerometer i2c address >>>>> >>>>> Patches 1-5 looks good. There are just a few minor things, but you can add >>>>> Reviewed-by: Pali Rohár <pali@kernel.org> >>>> >>>> Thank you. >>>> >>>>> For patch 6 as I mentioned previously I'm strictly against this change >>>>> until somebody goes and politely ask Dell about the current situation of >>>>> the discovering of accelerometer's i2c address. >>>> >>>> Dell is on the Cc and not responding... >>> >>> And what do you expecting here? That somebody on the group address >>> specified in CC list would react to all your tons of messages? Not >>> mentioning the fact that you did not even ask anything. >> >> You keep on repeating this since I first posted this patch >> in December last year, but as I already wrote back then: > > Yes, because you have not done anything and you are just repeating those > nonsenses. What are you expecting? You are either doing all this on > purpose or you are just lazy and think that somebody (e.g. me) would do > this stuff. > >> https://lore.kernel.org/platform-driver-x86/8b3946e0-7eb5-4e1f-9708-1f6cfda95e1a@redhat.com/ >> >> "Unfortunately I no longer have any contacts inside Dell" >> >> And Paul Menzel reached out back to gkh back then asking >> if Greg had any contacts in he did not have any contacts >> either. >> >> Dell.Client.Kernel@dell.com is the official address listed >> for Dell drivers under drivers/platform/x86 . > > Perfect. And may you explain why you have not tried to contact them with > addressed requests of exact information of what you need and ask for > help? You wrote tons of emails with zero value. > >>> This is not how things works. >> >> The email address which I'm using is *THE* one which Dell has >> provided for contacting about Dell pdx86 drivers. I really >> don't know what else you expect me to do here. >> >> You just keep repeating that Dell should be contacted about >> this and multiple people (me and Andy) have already pointed >> out that Dell does not have any other contact info. Repeating >> the same remark over and over does not change things. >> >> As I mentioned in my other email too, if you think you can do >> better feel free to try and contact Dell your self, something > > I'm not your servant and I'm not going to play role of your secretary. > >> which you could already have done the first time you mentioned >> this in December 2023, back when I already said I don't have >> any other contact info for Dell. > > Could you stop complaining? I'm really not interested in your stories > why you are not wanted to do anything. > >>> If you do not change your attitude here then I highly doubt that >>> somebody will respond to you. >>> >>> I have feeling that you are doing it on purpose just because you do not >>> want to do anything, and trying to find some kind of proof that nobody >>> is responding to you, to convince others for merge your last hack change. >> >> This is just plain hurtful I do not believe I have ever done >> anything to earn this level of distrust from you. > > Then read your message again. Now it is more clear that you are doing > it on purpose. > >> I am hurt that you cannot at least show the common decency to >> assume good intentions from my side. > > I hope that I do not have to explain you how to find contact address in > MAINTAINERS file, how to write an addressed email for target audience, > how to formulate questions and how to ask for information. And how to do > it in _one_ message. Really? Doubling down after insulting me (calling my integrity into question) ? So be it, I will simply not be responding to you in this thread anymore. Regards, Hans
Hi All, Here is v4 of my patch series to move the manual instantation of lis3lv02d i2c_client-s for SMO88xx ACPI device from the generic i2c-i801.c code to a SMO88xx specific dell-lis3lv02d driver. Moving the i2c_client instantiation there has the following advantages: 1. This moves the SMO88xx ACPI device quirk handling away from the generic i2c-i801 module which is loaded on all Intel x86 machines to a module which will only be loaded when there is an ACPI SMO88xx device. 2. This removes the duplication of the SMO88xx ACPI Hardware ID (HID) table between the i2c-i801 and dell-smo8800 drivers. 3. This allows extending the quirk handling by adding new code and related module parameters to the dell-lis3lv02d driver, without needing to modify the i2c-i801 code. This series also extends the i2c_client instantiation with support for probing for the i2c-address of the lis3lv02d chip on devices which are not yet listed in the DMI table with i2c-addresses for known models. This probing is only done when requested through a module parameter. The probing support adds quite a bit of code which shows why it is good to move the handling out of the generic i2c-i801 code. Changes in v4: - Move the i2c_client instantiation to a new dell-lis3lv02d driver instead of adding it to the dell-smo8800 driver - Address a couple of other minor review comments Changes in v3: - Use an i2c bus notifier so that the i2c_client will still be instantiated if the i801 i2c_adapter shows up later or is re-probed (removed + added again). This addresses the main concern / review-comments made during review of v2. - Add 2 prep patches to the i2c-core / the i2c-i801 driver to allow bus-notifier use / to avoid the need to duplicate the PCI-ids of IDF i2c-i801 adapters. - Switch to standard dmi_system_id matching to check both sys-vendor + product-name DMI fields - Drop the patch to alternatively use the st_accel IIO driver instead of drivers/misc/lis3lv02d/lis3lv02d.c Changes in v2: - Drop "[PATCH 1/6] platform/x86: dell-smo8800: Only load on Dell laptops" - Use a pci_device_id table to check for IDF (non main) i2c-i801 SMBusses - Add a comment documenting the IDF PCI device ids - Keep using drivers/misc/lis3lv02d/lis3lv02d.c by default - Rename the module-parameter to use_iio_driver which can be set to use the IIO st_accel driver instead - Add a new patch adding the accelerometer address for the 2 models I have tested this on to dell_lis3lv02d_devices[] Since this touches files under both drivers/i2c and drivers/platform/x86 some subsystem coordination is necessary. I think it would be best to just merge the entire series through the i2c subsystem since this touches some core i2c files. As pdx86 subsys co-maintainer I'm fine with doing so. Regards, Hans Hans de Goede (6): i2c: core: Setup i2c_adapter runtime-pm before calling device_add() i2c: i801: Use a different adapter-name for IDF adapters platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to dell-smo8800-ids.h platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d platform/x86: dell-smo8800: Add a couple more models to lis3lv02d_devices[] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address drivers/i2c/busses/i2c-i801.c | 133 +------- drivers/i2c/i2c-core-base.c | 18 +- drivers/platform/x86/dell/Makefile | 1 + drivers/platform/x86/dell/dell-lis3lv02d.c | 331 +++++++++++++++++++ drivers/platform/x86/dell/dell-smo8800-ids.h | 26 ++ drivers/platform/x86/dell/dell-smo8800.c | 16 +- 6 files changed, 379 insertions(+), 146 deletions(-) create mode 100644 drivers/platform/x86/dell/dell-lis3lv02d.c create mode 100644 drivers/platform/x86/dell/dell-smo8800-ids.h