| Message ID | 20250207154610.13675-1-kuurtb@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | platform/x86: alienware-wmi driver rework | expand |
On Fri, 7 Feb 2025, Kurt Borja wrote:
> One more correction. I apologize for the noise!
Applied to review-ilpo-next. Thanks.
On Mon Feb 10, 2025 at 6:53 AM -05, Ilpo Järvinen wrote: > On Fri, 7 Feb 2025, Kurt Borja wrote: > >> One more correction. I apologize for the noise! > > Applied to review-ilpo-next. Thanks. Thank you so much for reviewing this, Ilpo :) -- ~ Kurt
On Mon, Feb 10, 2025 at 08:48:05AM -0500, Kurt Borja wrote: > On Mon Feb 10, 2025 at 6:53 AM -05, Ilpo Järvinen wrote: > > On Fri, 7 Feb 2025, Kurt Borja wrote: > > > >> One more correction. I apologize for the noise! > > > > Applied to review-ilpo-next. Thanks. > > Thank you so much for reviewing this, Ilpo :) Please address my concerns in the followup patches. (Main concern is abuse of objs, others are more like cleanups to improve readability and maintenance)
Hi all, On Tue Feb 11, 2025 at 11:58 AM -05, Andy Shevchenko wrote: > On Mon, Feb 10, 2025 at 08:48:05AM -0500, Kurt Borja wrote: >> On Mon Feb 10, 2025 at 6:53 AM -05, Ilpo Järvinen wrote: >> > On Fri, 7 Feb 2025, Kurt Borja wrote: >> > >> >> One more correction. I apologize for the noise! >> > >> > Applied to review-ilpo-next. Thanks. >> >> Thank you so much for reviewing this, Ilpo :) > > Please address my concerns in the followup patches. > > (Main concern is abuse of objs, others are more like cleanups to improve > readability and maintenance) I agree with most of your coments. Some require additional patches tho, which is fine but are outside the scope of this series. I still have a lot of doubts about how to proceed with the Makefile stuff, I don't understand the root of the problem and a lot of drivers already do this so I'm a bit confused. Ilpo, how should we proceed here? I see this series has not hit linux-next so, is it fine to send a v11 incorporating Andy's comments? Obviously after understanding the Makefile problems. Also with all this fixes problems I'm having seconds thoughts about splitting the file (patch 11). I'd also like to know your opinion on that, Ilpo. Thank you again for your review Andy!
Hi all, One more correction. I apologize for the noise! ~ Kurt --- [11/14] - Fix .driver_data of Alienware m16 R1 AMD v9: https://lore.kernel.org/platform-driver-x86/20250207140743.16822-1-kuurtb@gmail.com/ Kurt Borja (14): platform/x86: alienware-wmi: Add a state container for LED control feature platform/x86: alienware-wmi: Add WMI Drivers platform/x86: alienware-wmi: Add a state container for thermal control methods platform/x86: alienware-wmi: Refactor LED control methods platform/x86: alienware-wmi: Refactor hdmi, amplifier, deepslp methods platform/x86: alienware-wmi: Refactor thermal control methods platform/x86: alienware-wmi: Split DMI table MAINTAINERS: Update ALIENWARE WMI DRIVER entry platform/x86: Rename alienware-wmi.c platform/x86: Add alienware-wmi.h platform/x86: Split the alienware-wmi driver platform/x86: dell: Modify Makefile alignment platform/x86: Update alienware-wmi config entries platform/x86: alienware-wmi: Update header and module information MAINTAINERS | 4 +- drivers/platform/x86/dell/Kconfig | 30 +- drivers/platform/x86/dell/Makefile | 45 +- .../platform/x86/dell/alienware-wmi-base.c | 491 +++++++ .../platform/x86/dell/alienware-wmi-legacy.c | 95 ++ .../platform/x86/dell/alienware-wmi-wmax.c | 768 ++++++++++ drivers/platform/x86/dell/alienware-wmi.c | 1249 ----------------- drivers/platform/x86/dell/alienware-wmi.h | 117 ++ 8 files changed, 1523 insertions(+), 1276 deletions(-) create mode 100644 drivers/platform/x86/dell/alienware-wmi-base.c create mode 100644 drivers/platform/x86/dell/alienware-wmi-legacy.c create mode 100644 drivers/platform/x86/dell/alienware-wmi-wmax.c delete mode 100644 drivers/platform/x86/dell/alienware-wmi.c create mode 100644 drivers/platform/x86/dell/alienware-wmi.h base-commit: e75394bbf4838857f57b6c5d00f1e56c46cd6c11