| Message ID | 1437261021-25632-1-git-send-email-dos@dosowisko.net (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
On Sun, Jul 19, 2015 at 01:10:21AM +0200, Sebastian Krzyszkowiak wrote: > There is at least one (mine) Yoga 2 Pro in existence that has incorrect > product version stored in DMI (reading as "INVALID"), causing it to not be > recognized as Yoga 2 by ideapad-laptop module, which in turn causes > non-existent hardware rfkills to be always reported as blocked. > > This change adds a second check by board name, which is "Yoga2". > Looks like it also happens to be "INVALID" on some other Yoga 2 machines > where product version is correct instead, so the original check is left > intact to catch both cases. > > Signed-off-by: Sebastian Krzyszkowiak <dos@dosowisko.net> Hi Sebastien, Please Cc the full list reported by get_maintainer in the future. Ike, any concerns from you if I pull this in? > --- > drivers/platform/x86/ideapad-laptop.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c > index 76b5738..4241262 100644 > --- a/drivers/platform/x86/ideapad-laptop.c > +++ b/drivers/platform/x86/ideapad-laptop.c > @@ -853,6 +853,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { > }, > }, > { > + .ident = "Lenovo Yoga 2 11 / 13 / Pro", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), > + }, > + }, > + { > .ident = "Lenovo Yoga 3 Pro 1370", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > -- > 2.4.6 > > -- > To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index 76b5738..4241262 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -853,6 +853,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = { }, }, { + .ident = "Lenovo Yoga 2 11 / 13 / Pro", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_BOARD_NAME, "Yoga2"), + }, + }, + { .ident = "Lenovo Yoga 3 Pro 1370", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
There is at least one (mine) Yoga 2 Pro in existence that has incorrect product version stored in DMI (reading as "INVALID"), causing it to not be recognized as Yoga 2 by ideapad-laptop module, which in turn causes non-existent hardware rfkills to be always reported as blocked. This change adds a second check by board name, which is "Yoga2". Looks like it also happens to be "INVALID" on some other Yoga 2 machines where product version is correct instead, so the original check is left intact to catch both cases. Signed-off-by: Sebastian Krzyszkowiak <dos@dosowisko.net> --- drivers/platform/x86/ideapad-laptop.c | 7 +++++++ 1 file changed, 7 insertions(+)