| Message ID | 1441819545-11619-1-git-send-email-coproscefalo@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Wed, Sep 09, 2015 at 11:25:44AM -0600, Azael Avalos wrote: > Commit e1a949c1b988 ("toshiba_acpi: Refactor *{get, set} functions return > value") made changes on the return type of the HCI/SCI functions, but a > typo on the USB Sleep and Music code is always reporting non existent > support for such feature. > > This patch corrects the typo, changing an assignment to a comparison, > making the laptops with actual support for such feature to work again. > > Signed-off-by: Azael Avalos <coproscefalo@gmail.com> > --- > Darren, > > Hopefully this patch can go into one of the 4.3 RCs, as the changes are > there and to avoid shipping a broken feature support. Queued for 4.3, thanks Azael.
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 6740c51..c434b53 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -938,7 +938,7 @@ static int toshiba_usb_sleep_music_get(struct toshiba_acpi_dev *dev, u32 *state) else if (result == TOS_NOT_SUPPORTED) return -ENODEV; - return result = TOS_SUCCESS ? 0 : -EIO; + return result == TOS_SUCCESS ? 0 : -EIO; } static int toshiba_usb_sleep_music_set(struct toshiba_acpi_dev *dev, u32 state)
Commit e1a949c1b988 ("toshiba_acpi: Refactor *{get, set} functions return value") made changes on the return type of the HCI/SCI functions, but a typo on the USB Sleep and Music code is always reporting non existent support for such feature. This patch corrects the typo, changing an assignment to a comparison, making the laptops with actual support for such feature to work again. Signed-off-by: Azael Avalos <coproscefalo@gmail.com> --- Darren, Hopefully this patch can go into one of the 4.3 RCs, as the changes are there and to avoid shipping a broken feature support. drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)