| Message ID | 1441819700-11678-3-git-send-email-coproscefalo@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote: > The driver currently uses the hotkey enabling value of 0x09 to enable > hotkey events, but windows uses a different value (0x01). > > All Toshiba laptops accept the following "hotkey" parameters: > 0x01 - Enable hotkey and system events. > 0x03 - Enable system events only. > 0x09 - Enable hotkey events only. > 0x0b - Disable (hotkey and system) events. > > This patch changes the default hotkey enabling value from 0x09 to 0x01, > enabling both the hotkey and system events. > > Signed-off-by: Azael Avalos <coproscefalo@gmail.com> Queued to testing for 4.4. Let me know if you were expecting 4.3....
Hi Darren, 2015-09-18 15:37 GMT-06:00 Darren Hart <dvhart@infradead.org>: > On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote: >> The driver currently uses the hotkey enabling value of 0x09 to enable >> hotkey events, but windows uses a different value (0x01). >> >> All Toshiba laptops accept the following "hotkey" parameters: >> 0x01 - Enable hotkey and system events. >> 0x03 - Enable system events only. >> 0x09 - Enable hotkey events only. >> 0x0b - Disable (hotkey and system) events. >> >> This patch changes the default hotkey enabling value from 0x09 to 0x01, >> enabling both the hotkey and system events. >> >> Signed-off-by: Azael Avalos <coproscefalo@gmail.com> > > Queued to testing for 4.4. > > Let me know if you were expecting 4.3.... Nope, just the first two fixes were meant for 4.3, the rest is 4.4 material, I just wanted to send them early. > > -- > Darren Hart > Intel Open Source Technology Center Cheers Azael
On Fri, Sep 18, 2015 at 03:45:05PM -0600, Azael Avalos wrote: > Hi Darren, > > 2015-09-18 15:37 GMT-06:00 Darren Hart <dvhart@infradead.org>: > > On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote: > >> The driver currently uses the hotkey enabling value of 0x09 to enable > >> hotkey events, but windows uses a different value (0x01). > >> > >> All Toshiba laptops accept the following "hotkey" parameters: > >> 0x01 - Enable hotkey and system events. > >> 0x03 - Enable system events only. > >> 0x09 - Enable hotkey events only. > >> 0x0b - Disable (hotkey and system) events. > >> > >> This patch changes the default hotkey enabling value from 0x09 to 0x01, > >> enabling both the hotkey and system events. > >> > >> Signed-off-by: Azael Avalos <coproscefalo@gmail.com> > > > > Queued to testing for 4.4. > > > > Let me know if you were expecting 4.3.... > > Nope, just the first two fixes were meant for 4.3, the rest > is 4.4 material, I just wanted to send them early. OK, check mainline please, everything I plan to push for 4.3 is now there. Please confirm it has all you expected.
Hi Darren, 2015-09-18 16:14 GMT-06:00 Darren Hart <dvhart@infradead.org>: > On Fri, Sep 18, 2015 at 03:45:05PM -0600, Azael Avalos wrote: >> Hi Darren, >> >> 2015-09-18 15:37 GMT-06:00 Darren Hart <dvhart@infradead.org>: >> > On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote: >> >> The driver currently uses the hotkey enabling value of 0x09 to enable >> >> hotkey events, but windows uses a different value (0x01). >> >> >> >> All Toshiba laptops accept the following "hotkey" parameters: >> >> 0x01 - Enable hotkey and system events. >> >> 0x03 - Enable system events only. >> >> 0x09 - Enable hotkey events only. >> >> 0x0b - Disable (hotkey and system) events. >> >> >> >> This patch changes the default hotkey enabling value from 0x09 to 0x01, >> >> enabling both the hotkey and system events. >> >> >> >> Signed-off-by: Azael Avalos <coproscefalo@gmail.com> >> > >> > Queued to testing for 4.4. >> > >> > Let me know if you were expecting 4.3.... >> >> Nope, just the first two fixes were meant for 4.3, the rest >> is 4.4 material, I just wanted to send them early. > > OK, check mainline please, everything I plan to push for 4.3 is now there. > Please confirm it has all you expected. Yup, everything is in there, thanks.
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 5510d3f..803e967 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -131,7 +131,7 @@ MODULE_LICENSE("GPL"); /* Field definitions */ #define HCI_ACCEL_MASK 0x7fff #define HCI_HOTKEY_DISABLE 0x0b -#define HCI_HOTKEY_ENABLE 0x09 +#define HCI_HOTKEY_ENABLE 0x01 #define HCI_HOTKEY_SPECIAL_FUNCTIONS 0x10 #define HCI_LCD_BRIGHTNESS_BITS 3 #define HCI_LCD_BRIGHTNESS_SHIFT (16-HCI_LCD_BRIGHTNESS_BITS)
The driver currently uses the hotkey enabling value of 0x09 to enable hotkey events, but windows uses a different value (0x01). All Toshiba laptops accept the following "hotkey" parameters: 0x01 - Enable hotkey and system events. 0x03 - Enable system events only. 0x09 - Enable hotkey events only. 0x0b - Disable (hotkey and system) events. This patch changes the default hotkey enabling value from 0x09 to 0x01, enabling both the hotkey and system events. Signed-off-by: Azael Avalos <coproscefalo@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)