| Message ID | 1442912500-1878-1-git-send-email-souvik.k.chakravarty@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tue, Sep 22, 2015 at 02:31:40PM +0530, Souvik Kumar Chakravarty wrote: > Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry. > It depends on PUNIT and PMC IPC drivers. > > Signed-off-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com> Souvik, v2 seems to be the latest I have from you and checkpatch still reports several basic coding style errors about comment blocks and comparison constant location. See my response to v1 regarding that on Sep 18.
Hi Darren,
I am a bit confused as checkpatch that I pulled from Linus' tree gave me all clear.
Can you please send me the log, because I have a clean checkpatch report at my end.
BR,
Souvik
skchakra@intel-desktop:~/disk2/linux-platform-drivers-x86/linux$ ./scripts/checkpatch.pl 0004-platform-x86-Makefile-Kconfig-MAINTAINERS-changes-fo.patch
total: 0 errors, 0 warnings, 36 lines checked
0004-platform-x86-Makefile-Kconfig-MAINTAINERS-changes-fo.patch has no obvious style problems and is ready for submission.
skchakra@intel-desktop:~/disk2/linux-platform-drivers-x86/linux$ ./scripts/checkpatch.pl 0003-platform-x86-Add-Intel-Telemetry-Debugfs-interfaces.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 1094 lines checked
0003-platform-x86-Add-Intel-Telemetry-Debugfs-interfaces.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
skchakra@intel-desktop:~/disk2/linux-platform-drivers-x86/linux$ ./scripts/checkpatch.pl 0002-platform-x86-Add-Intel-telemetry-platform-device-dri.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#195:
new file mode 100644
total: 0 errors, 1 warnings, 1371 lines checked
0002-platform-x86-Add-Intel-telemetry-platform-device-dri.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
skchakra@intel-desktop:~/disk2/linux-platform-drivers-x86/linux$ ./scripts/checkpatch.pl 0001-platform-x86-Add-Intel-Telemetry-Core-Driver.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34:
new file mode 100644
total: 0 errors, 1 warnings, 611 lines checked
0001-platform-x86-Add-Intel-Telemetry-Core-Driver.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86-
> owner@vger.kernel.org] On Behalf Of Darren Hart
> Sent: Thursday, October 8, 2015 10:22 PM
> To: Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>
> Cc: platform-driver-x86@vger.kernel.org; Kasagar, Srinidhi
> <srinidhi.kasagar@intel.com>; Zha, Qipeng <qipeng.zha@intel.com>
> Subject: Re: [PATCH v2 4/4] platform:x86: Makefile/Kconfig/MAINTAINERS
> changes for Intel Telemetry
>
> On Tue, Sep 22, 2015 at 02:31:40PM +0530, Souvik Kumar Chakravarty wrote:
> > Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry.
> > It depends on PUNIT and PMC IPC drivers.
> >
> > Signed-off-by: Souvik Kumar Chakravarty
> > <souvik.k.chakravarty@intel.com>
>
> Souvik, v2 seems to be the latest I have from you and checkpatch still reports
> several basic coding style errors about comment blocks and comparison
> constant location.
>
> See my response to v1 regarding that on Sep 18.
>
> --
> Darren Hart
> Intel Open Source Technology Center
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
> in the body of a message to majordomo@vger.kernel.org More majordomo
> info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 09, 2015 at 04:31:40AM +0000, Chakravarty, Souvik K wrote: > Hi Darren, > > I am a bit confused as checkpatch that I pulled from Linus' tree gave me all clear. > Can you please send me the log, because I have a clean checkpatch report at my end. > Sure, using checkpatch.pl from Linux v4.3-rc4: $ scripts/checkpatch.pl ~/incoming/*mbox ------------------------------------------------------------------------------------ /home/dvhart/incoming/PATCH_v2_1-4_platform-x86_Add_Intel_Telemetry_Core_Driver.mbox ------------------------------------------------------------------------------------ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 WARNING: Comparisons should place the constant on the right side of the test #645: FILE: drivers/platform/x86/intel_telemetry_core.c:437: + if (TELEM_PSS == telem_unit) WARNING: Comparisons should place the constant on the right side of the test #648: FILE: drivers/platform/x86/intel_telemetry_core.c:440: + else if (TELEM_IOSS == telem_unit) total: 0 errors, 3 warnings, 611 lines checked /home/dvhart/incoming/PATCH_v2_1-4_platform-x86_Add_Intel_Telemetry_Core_Driver.mbox has style problems, please review. ------------------------------------------------------------------------------------------------- /home/dvhart/incoming/PATCH_v2_2-4_platform-x86_Add_Intel_telemetry_platform_device_&_driver.mbox ------------------------------------------------------------------------------------------------- WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #211: new file mode 100644 WARNING: Block comments use * on subsequent lines #318: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:103: +/* The following counters are programmed by default during setup. + Only 20 allocated to kernel driver */ WARNING: Block comments use a trailing */ on a separate line #318: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:103: + Only 20 allocated to kernel driver */ WARNING: Comparisons should place the constant on the right side of the test #388: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:173: + if (TELEM_PSS == telem_unit) WARNING: Comparisons should place the constant on the right side of the test #390: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:175: + else if (TELEM_IOSS == telem_unit) WARNING: Comparisons should place the constant on the right side of the test #421: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:206: + if ((len > 0) && (NULL == evtmap)) WARNING: Comparisons should place the constant on the right side of the test #431: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:216: + if ((len > 0) && (NULL == evtmap)) WARNING: Comparisons should place the constant on the right side of the test #509: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:294: + if (TELEM_RESET == action) { WARNING: Comparisons should place the constant on the right side of the test #539: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:324: + if (TELEM_UPDATE == action) { WARNING: Comparisons should place the constant on the right side of the test #571: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:356: + if (TELEM_ADD == action) { WARNING: Comparisons should place the constant on the right side of the test #642: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:427: + if (TELEM_RESET == action) { WARNING: Comparisons should place the constant on the right side of the test #669: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:454: + if (TELEM_UPDATE == action) { WARNING: Comparisons should place the constant on the right side of the test #699: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:484: + if (TELEM_ADD == action) { WARNING: Comparisons should place the constant on the right side of the test #1204: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:989: + if (NULL == verbosity) total: 0 errors, 14 warnings, 1371 lines checked /home/dvhart/incoming/PATCH_v2_2-4_platform-x86_Add_Intel_telemetry_platform_device_&_driver.mbox has style problems, please review. ------------------------------------------------------------------------------------------- /home/dvhart/incoming/PATCH_v2_3-4_platform-x86_Add_Intel_Telemetry_Debugfs_interfaces.mbox ------------------------------------------------------------------------------------------- WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #46: new file mode 100644 total: 0 errors, 1 warnings, 1094 lines checked /home/dvhart/incoming/PATCH_v2_3-4_platform-x86_Add_Intel_Telemetry_Debugfs_interfaces.mbox has style problems, please review. ------------------------------------------------------------------------------------------------------------- /home/dvhart/incoming/PATCH_v2_4-4_platform-x86_Makefile-Kconfig-MAINTAINERS_changes_for_Intel_Telemetry.mbox ------------------------------------------------------------------------------------------------------------- total: 0 errors, 0 warnings, 36 lines checked /home/dvhart/incoming/PATCH_v2_4-4_platform-x86_Makefile-Kconfig-MAINTAINERS_changes_for_Intel_Telemetry.mbox has no obvious style problems and is ready for submission. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Yes this helps. Seems the checkpatch.pl in 4.3-rc4 has some changes. Will update the patches. BR, Souvik > -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Sunday, October 11, 2015 12:08 AM > To: Chakravarty, Souvik K <souvik.k.chakravarty@intel.com> > Cc: platform-driver-x86@vger.kernel.org; Kasagar, Srinidhi > <srinidhi.kasagar@intel.com>; Zha, Qipeng <qipeng.zha@intel.com> > Subject: Re: [PATCH v2 4/4] platform:x86: Makefile/Kconfig/MAINTAINERS > changes for Intel Telemetry > > On Fri, Oct 09, 2015 at 04:31:40AM +0000, Chakravarty, Souvik K wrote: > > Hi Darren, > > > > I am a bit confused as checkpatch that I pulled from Linus' tree gave me all > clear. > > Can you please send me the log, because I have a clean checkpatch report at > my end. > > > > Sure, using checkpatch.pl from Linux v4.3-rc4: > > $ scripts/checkpatch.pl ~/incoming/*mbox > ------------------------------------------------------------------------------------ > /home/dvhart/incoming/PATCH_v2_1-4_platform- > x86_Add_Intel_Telemetry_Core_Driver.mbox > ------------------------------------------------------------------------------------ > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #51: > new file mode 100644 > > WARNING: Comparisons should place the constant on the right side of the test > #645: FILE: drivers/platform/x86/intel_telemetry_core.c:437: > + if (TELEM_PSS == telem_unit) > > WARNING: Comparisons should place the constant on the right side of the test > #648: FILE: drivers/platform/x86/intel_telemetry_core.c:440: > + else if (TELEM_IOSS == telem_unit) > > total: 0 errors, 3 warnings, 611 lines checked > > /home/dvhart/incoming/PATCH_v2_1-4_platform- > x86_Add_Intel_Telemetry_Core_Driver.mbox has style problems, please > review. > ------------------------------------------------------------------------------------------------- > /home/dvhart/incoming/PATCH_v2_2-4_platform- > x86_Add_Intel_telemetry_platform_device_&_driver.mbox > ------------------------------------------------------------------------------------------------- > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #211: > new file mode 100644 > > WARNING: Block comments use * on subsequent lines > #318: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:103: > +/* The following counters are programmed by default during setup. > + Only 20 allocated to kernel driver */ > > WARNING: Block comments use a trailing */ on a separate line > #318: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:103: > + Only 20 allocated to kernel driver */ > > WARNING: Comparisons should place the constant on the right side of the test > #388: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:173: > + if (TELEM_PSS == telem_unit) > > WARNING: Comparisons should place the constant on the right side of the test > #390: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:175: > + else if (TELEM_IOSS == telem_unit) > > WARNING: Comparisons should place the constant on the right side of the test > #421: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:206: > + if ((len > 0) && (NULL == evtmap)) > > WARNING: Comparisons should place the constant on the right side of the test > #431: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:216: > + if ((len > 0) && (NULL == evtmap)) > > WARNING: Comparisons should place the constant on the right side of the test > #509: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:294: > + if (TELEM_RESET == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #539: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:324: > + if (TELEM_UPDATE == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #571: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:356: > + if (TELEM_ADD == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #642: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:427: > + if (TELEM_RESET == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #669: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:454: > + if (TELEM_UPDATE == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #699: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:484: > + if (TELEM_ADD == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #1204: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:989: > + if (NULL == verbosity) > > total: 0 errors, 14 warnings, 1371 lines checked > > /home/dvhart/incoming/PATCH_v2_2-4_platform- > x86_Add_Intel_telemetry_platform_device_&_driver.mbox has style > problems, please review. > ------------------------------------------------------------------------------------------- > /home/dvhart/incoming/PATCH_v2_3-4_platform- > x86_Add_Intel_Telemetry_Debugfs_interfaces.mbox > ------------------------------------------------------------------------------------------- > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #46: > new file mode 100644 > > total: 0 errors, 1 warnings, 1094 lines checked > > /home/dvhart/incoming/PATCH_v2_3-4_platform- > x86_Add_Intel_Telemetry_Debugfs_interfaces.mbox has style problems, please > review. > ------------------------------------------------------------------------------------------------------------- > /home/dvhart/incoming/PATCH_v2_4-4_platform-x86_Makefile-Kconfig- > MAINTAINERS_changes_for_Intel_Telemetry.mbox > ------------------------------------------------------------------------------------------------------------- > total: 0 errors, 0 warnings, 36 lines checked > > /home/dvhart/incoming/PATCH_v2_4-4_platform-x86_Makefile-Kconfig- > MAINTAINERS_changes_for_Intel_Telemetry.mbox has no obvious style > problems and is ready for submission. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > -- > Darren Hart > Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/MAINTAINERS b/MAINTAINERS index 4d8c8e1..a7f3c1f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5548,6 +5548,15 @@ S: Maintained F: drivers/platform/x86/intel_pmc_ipc.c F: arch/x86/include/asm/intel_pmc_ipc.h +INTEL TELEMETRY DRIVER +M: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com> +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: drivers/platform/x86/intel_telemetry_core.c +F: drivers/platform/x86/intel_telemetry_pltdrv.c +F: drivers/platform/x86/intel_telemetry_debugfs.c +F: arch/x86/include/asm/intel_telemetry.h + IOC3 ETHERNET DRIVER M: Ralf Baechle <ralf@linux-mips.org> L: linux-mips@linux-mips.org diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 6dc13e4..eb8f024 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -919,4 +919,15 @@ config INTEL_PMC_IPC The PMC is an ARC processor which defines IPC commands for communication with other entities in the CPU. +config INTEL_TELEMETRY + tristate "Intel SoC Telemetry Driver" + default n + depends on INTEL_PMC_IPC && INTEL_PUNIT_IPC && X86_64 + ---help--- + This driver provides interfaces to configure and use + telemetry for INTEL SoC from APL onwards. It is also + used to get various SoC events and parameters + directly via debugfs files. Various tools may use + this interface for SoC state monitoring. + endif # X86_PLATFORM_DEVICES diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index dda95a9..34f6ebf 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -60,3 +60,6 @@ obj-$(CONFIG_INTEL_SMARTCONNECT) += intel-smartconnect.o obj-$(CONFIG_PVPANIC) += pvpanic.o obj-$(CONFIG_ALIENWARE_WMI) += alienware-wmi.o obj-$(CONFIG_INTEL_PMC_IPC) += intel_pmc_ipc.o +obj-$(CONFIG_INTEL_TELEMETRY) += intel_telemetry_core.o \ + intel_telemetry_pltdrv.o \ + intel_telemetry_debugfs.o
Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry. It depends on PUNIT and PMC IPC drivers. Signed-off-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com> --- Changes in v2: * Change bool to tristate in Kconfig to enable support as module * Remove PUNIT_IPC specific additions. These will be merged separately by Qipeng's PUNIT_IPC patch. --- MAINTAINERS | 9 +++++++++ drivers/platform/x86/Kconfig | 11 +++++++++++ drivers/platform/x86/Makefile | 3 +++ 3 files changed, 23 insertions(+)