From patchwork Wed Oct 21 10:46:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Herrmann X-Patchwork-Id: 7456101 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CAED39F36A for ; Wed, 21 Oct 2015 10:47:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 07B9720822 for ; Wed, 21 Oct 2015 10:47:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2701E207ED for ; Wed, 21 Oct 2015 10:47:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbbJUKrC (ORCPT ); Wed, 21 Oct 2015 06:47:02 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:35007 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbbJUKrA (ORCPT ); Wed, 21 Oct 2015 06:47:00 -0400 Received: by wicll6 with SMTP id ll6so84702657wic.0; Wed, 21 Oct 2015 03:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=QGsjf0cQClPqNZHZx6Y9oj7x0HMM9j8QWmuCQbcKJhA=; b=oCg5GVr08E1WwK1KebRtywaajxT6kZoejLWhGOCzl3JQSiwlbGYftQvaaVMKce0818 fQFlY4EI4xZM6MuX6pOSn3v4QOzHn9sXLJmlyUPif5iEmvgneSdWyeHhXm/umR08CVk7 V65gWcxajqCyMeg0SVX9XZlFrkaawib8aflg4ogBTNOe74maA9QPPbLLDDiQNJfqXBuS 7PT/7T/Mi0PcLqzmdCBhhpqVYvqEbaEPh8bNVOGB7vRD6xbfyNp6FEVXnrB8P/lX2ji3 thgfSFhjx1IdLrDjNowDyKZeeWMw6njskLkWHFRxQFexsvldzdFuTghRqFxcuiSL+xme GXuA== X-Received: by 10.194.200.195 with SMTP id ju3mr10023901wjc.26.1445424418844; Wed, 21 Oct 2015 03:46:58 -0700 (PDT) Received: from david-t2.localdomain ([37.120.90.97]) by smtp.gmail.com with ESMTPSA id v9sm9553029wjv.45.2015.10.21.03.46.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Oct 2015 03:46:57 -0700 (PDT) From: David Herrmann To: platform-driver-x86@vger.kernel.org Cc: Henrique de Moraes Holschuh , Darren Hart , ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, David Herrmann Subject: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces Date: Wed, 21 Oct 2015 12:46:10 +0200 Message-Id: <1445424370-4725-1-git-send-email-dh.herrmann@gmail.com> X-Mailer: git-send-email 2.6.1 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The thinkpad_acpi driver currently emits error messages on unsupported brightness interfaces, giving the impression that someone will implement those. However, this error is spit out on nearly every thinkpad in production since 2 years now. Furthermore, the backlight interfaces on those devices are supported by the i915 driver just fine. Downgrade the error message to a normal pr_info() and stop telling people to report it to IBM. Signed-off-by: David Herrmann Acked-by: Henrique de Moraes Holschuh --- drivers/platform/x86/thinkpad_acpi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 131dd74..0bed473 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -6459,8 +6459,7 @@ static void __init tpacpi_detect_brightness_capabilities(void) pr_info("detected a 8-level brightness capable ThinkPad\n"); break; default: - pr_err("Unsupported brightness interface, " - "please contact %s\n", TPACPI_MAIL); + pr_info("Unsupported brightness interface\n"); tp_features.bright_unkfw = 1; bright_maxlvl = b - 1; }