From patchwork Wed Nov 4 16:28:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Azael Avalos X-Patchwork-Id: 7551741 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 08C01BEEA4 for ; Wed, 4 Nov 2015 16:29:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2A0B82061B for ; Wed, 4 Nov 2015 16:29:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BDD0205E8 for ; Wed, 4 Nov 2015 16:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754516AbbKDQ2w (ORCPT ); Wed, 4 Nov 2015 11:28:52 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34834 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754857AbbKDQ2u (ORCPT ); Wed, 4 Nov 2015 11:28:50 -0500 Received: by oifu63 with SMTP id u63so31191622oif.2; Wed, 04 Nov 2015 08:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=dX4dj1f6DkfZ3DyI3kYKwy1Uuube2huCFTV7Vp8+r8M=; b=qu2XXGBsOw2oDq1X03Y4J4te7jTcIbTxpUJ5oXcKGOCuvdEv/lTVP5+9dUwYvRUYDS Muj/MINDXwig4pwY5U/crO8z4+4kvdxTsO6arMH50EijFqT8rYLh5D1ig1gfYJOtGd2S 36ystitBKqOB608GdA+J1oWnuecESORLnRPaPFnk8oZdTRlZBzLC9zry9v2FaSjLmEux HokeDdwt8WSjNYwM8BdCIZajSZwb71rWH0MJnz7UHExzWJT7ehB9pXI2Rw9H8iEeZCJL MqG+mAnLTzxdSGt/JQMt4hyos7hlKCBJcVLB6B/j79XQstsNXQkHYq2Qhq6HFRdRfnlh f5ig== X-Received: by 10.202.211.82 with SMTP id k79mr1377632oig.32.1446654529892; Wed, 04 Nov 2015 08:28:49 -0800 (PST) Received: from Shakuras.scurra.org ([148.210.107.223]) by smtp.gmail.com with ESMTPSA id f1sm681513oeu.17.2015.11.04.08.28.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Nov 2015 08:28:48 -0800 (PST) From: Azael Avalos To: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Azael Avalos , stable@vger.kernel.org Subject: [PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type variable Date: Wed, 4 Nov 2015 09:28:26 -0700 Message-Id: <1446654506-3730-1-git-send-email-coproscefalo@gmail.com> X-Mailer: git-send-email 2.6.2 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some toshiba models") fixed an issue on some laptops regarding hotkeys registration, however, if failed to address the initialization of the hotkey_event_type variable, and thus, it can lead to potential unwanted effects as the variable is being checked. This patch initializes such variable to avoid such unwanted effects. Cc: # 4.1+ Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index beb709f..c013029 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev) ret = toshiba_function_keys_get(dev, &dev->special_functions); dev->kbd_function_keys_supported = !ret; + dev->hotkey_event_type = 0; if (toshiba_acpi_setup_keyboard(dev)) pr_info("Unable to activate hotkeys\n");