From patchwork Sat Apr 16 00:01:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giedrius Statkevi?ius X-Patchwork-Id: 8859791 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 71D299F1E6 for ; Sat, 16 Apr 2016 00:03:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9222820222 for ; Sat, 16 Apr 2016 00:03:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B712520204 for ; Sat, 16 Apr 2016 00:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752529AbcDPACt (ORCPT ); Fri, 15 Apr 2016 20:02:49 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34153 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397AbcDPACs (ORCPT ); Fri, 15 Apr 2016 20:02:48 -0400 Received: by mail-wm0-f65.google.com with SMTP id n3so9791929wmn.1; Fri, 15 Apr 2016 17:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fQileluDUoBoL6ObzIGqBGPPYHZddHb1tHGyQMOhcXo=; b=JQd1kzAWaQSh0Z5mAYPRTS3wAa++jIzScsnxGrQHYdHDpA6CEjTHKBAnGM8jdmDSaq z/wnHDnVVFNxiWrPYO9djcdHjJsRzn9mbI2lYXHue7GTn7w/mhKR/f+1AEHxWGq9SpWh SenRKFdRRUgTFEQGaobpMpFKVYdaxB0rdsYdP07rYKNCXFyW6G2csfvargr+QJYHZPg5 O2zHAG+DYeTzv0wcvQhNfiUnVI/H/O1QeSeHpiYZSKq/CHZT1A8clisMOIYxtYtSnDrm PDZCESKnBT9mhJYAXB06rUUJl7rzPBS8jQtS9BF1JgLAqA3BwKTJSTUvWmKrQNyM+xBZ UAXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fQileluDUoBoL6ObzIGqBGPPYHZddHb1tHGyQMOhcXo=; b=acctMJe6MA0Y6gLNd+TitiasxI1b/90Sru49UWdPqUlWuVSOHNHchPFSDKJRe8I757 MQgN0wYddhfGJZOE25pI/3JptUFM8xWpwUf4UFFkPXP/Co9+uMOIyhx3pCXI0bbznklW aVFXWbol3laN+cfc3pItRXWyc7xPx2doKSlLKVAxoEGUqCPjmeQdljEOTq3jzwq7Y70O ebpamQTR4AocGAVdWvuHwJsA/0A2GpGFmOboH4yxJi10Zd2yBGVn11jjSXl6hfy+9PPD SX5lPa0HKfT63txn1H4Dy2VgVRXN7gUkHBNcZG1O74UcX0Gm4KrhYtC9COlmdZ58awyC cLgQ== X-Gm-Message-State: AOPr4FXuVgdpg6/hFYtFnub0p9D2WHtwbFLb1LxXlC/K+7u1seISarT64Ii4DkgrCxJ2rg== X-Received: by 10.194.112.6 with SMTP id im6mr24522553wjb.16.1460764967016; Fri, 15 Apr 2016 17:02:47 -0700 (PDT) Received: from tyrael.localdomain (78-57-189-147.static.zebra.lt. [78.57.189.147]) by smtp.gmail.com with ESMTPSA id r8sm51215352wjz.34.2016.04.15.17.02.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Apr 2016 17:02:46 -0700 (PDT) From: =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?= To: corentin.chary@gmail.com, dvhart@infradead.org Cc: acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?= Subject: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Date: Sat, 16 Apr 2016 03:01:57 +0300 Message-Id: <1460764917-1042-2-git-send-email-giedrius.statkevicius@gmail.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1460764917-1042-1-git-send-email-giedrius.statkevicius@gmail.com> References: <1460764917-1042-1-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Properly return rv back to the caller in the case of an error in parse_arg. In the process remove a unused variable 'out'. Signed-off-by: Giedrius Statkevi?ius --- drivers/platform/x86/asus-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index d86d42e..9a69734 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus, const char *method) { int rv, value; - int out = 0; rv = parse_arg(buf, count, &value); - if (rv > 0) - out = value ? 1 : 0; + if (rv <= 0) + return rv; if (write_acpi_int(asus->handle, method, value)) return -ENODEV;