From patchwork Fri Apr 22 15:29:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Azael Avalos X-Patchwork-Id: 8912901 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0CD409F1D3 for ; Fri, 22 Apr 2016 15:29:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 308CE20108 for ; Fri, 22 Apr 2016 15:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4744D2025A for ; Fri, 22 Apr 2016 15:29:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbcDVP3n (ORCPT ); Fri, 22 Apr 2016 11:29:43 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:34744 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932211AbcDVP3m (ORCPT ); Fri, 22 Apr 2016 11:29:42 -0400 Received: by mail-oi0-f53.google.com with SMTP id k142so120304907oib.1; Fri, 22 Apr 2016 08:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=r32XOS59YERBLe2pYRx+Cxotu1KRLDPwArTrtFfloVE=; b=AcHYYVFcHkdkVDuhIV+dWXpMaDur0P9Y9L2R/Fo5LxFOWMRCEj/IE95BVypXK4iHZq uezJRkayqfZktuyXVicm1hEI5d/1+pMHLEeCCR2rpRuW7CScaAaPJAWXbYMALn4WWzHL 9wPqSU6zqCtc8QLs7Z1AbXRVOeUiODJJ4ZMxSopc4EGp8guSGZkwb2+0dcaYyus0WMVs bAaD22f3LLpll7GHi36Ff22879Zryo7pcRoPqs151eM2S06TGqMVqWcV72fv36VFbB0i bNbewYpwLrP0dekv5OHEO5cuRMLvGkJUoODi6C3epwjShvVSH7dWpG/SJR5arkzrNGLc EWWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=r32XOS59YERBLe2pYRx+Cxotu1KRLDPwArTrtFfloVE=; b=aX3nPtQlnRCtPKF0hX02MV7yLWV7rePlvx1JhZMroBsWk4IHShjeACdnndOVTWr1Qo w4kiiO5QfTroqbU7a3izKhV3lu5m6Qo5VGivKaph2Ll7kutleFwO+G32DJgM1FOWwV2w DyIz+uZ7hWa+L0T05Ft4yENqGDQjVi7lsYjrcjw+MzKcy1ZPc0xf1owBwG3+oNTWRFcd xmwt/KGiLzyDvnzPXHCm0T1Y1XNh/qxNo5itikIDy/hbg006oi2Ps4R/Lwp2LOquZsXy lmNtu90l83AlAAKM2jYKY7GzX34oX5WJugYOiljLv+73PpGJhKjUJNgXp9h26A1eVPDz /sfA== X-Gm-Message-State: AOPr4FUB/ku7kBqTdfkKAZlo9T5ONw3WKMIgg4X5Uq0MBw0fxzQitsVP5cKeNZOcUHqKsw== X-Received: by 10.157.36.135 with SMTP id z7mr8410165ota.69.1461338981373; Fri, 22 Apr 2016 08:29:41 -0700 (PDT) Received: from Shakuras.scurra.org ([148.210.135.132]) by smtp.gmail.com with ESMTPSA id e20sm2085205oic.19.2016.04.22.08.29.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Apr 2016 08:29:40 -0700 (PDT) From: Azael Avalos To: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Azael Avalos Subject: [PATCH] toshiba_acpi: Fix regression caused by hotkey enabling value Date: Fri, 22 Apr 2016 09:29:36 -0600 Message-Id: <1461338976-5194-1-git-send-email-coproscefalo@gmail.com> X-Mailer: git-send-email 2.8.1 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 52cbae0127ad ("toshiba_acpi: Change default Hotkey enabling value") changed the hotkeys enabling value, as it was the same value Windows uses, however, it turns out that the value tells the EC that the driver will now take care of the hardware events like the physical RFKill switch or the pointing device toggle button. This patch reverts such commit by changing the default hotkey enabling value to 0x09, which enables hotkey events only, making the hardware buttons working again. Fixes bugs 113331 and 114941. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index df1f1a7..01e12d2 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -135,7 +135,7 @@ MODULE_LICENSE("GPL"); /* Field definitions */ #define HCI_ACCEL_MASK 0x7fff #define HCI_HOTKEY_DISABLE 0x0b -#define HCI_HOTKEY_ENABLE 0x01 +#define HCI_HOTKEY_ENABLE 0x09 #define HCI_HOTKEY_SPECIAL_FUNCTIONS 0x10 #define HCI_LCD_BRIGHTNESS_BITS 3 #define HCI_LCD_BRIGHTNESS_SHIFT (16-HCI_LCD_BRIGHTNESS_BITS)