diff mbox

[v2,2/2] Telemetry: remove redundant macro definition

Message ID 1500560474-24268-2-git-send-email-rajneesh.bhardwaj@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Andy Shevchenko
Headers show

Commit Message

Rajneesh Bhardwaj July 20, 2017, 2:21 p.m. UTC 
Telemetry driver includes intel_telemetry.h which defines
TELEM_MAX_OS_ALLOCATED_EVENTS already.

Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
---
 drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Chakravarty, Souvik K July 21, 2017, 3:15 a.m. UTC | #1 
Both set of two looks good. +1.

> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-
> x86-owner@vger.kernel.org] On Behalf Of Rajneesh Bhardwaj
> Sent: Thursday, July 20, 2017 7:51 PM
> To: platform-driver-x86@vger.kernel.org
> Cc: dvhart@infradead.org; andy@infradead.org; linux-
> kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
> Rajneesh <rajneesh.bhardwaj@intel.com>
> Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Telemetry driver includes intel_telemetry.h which defines
> TELEM_MAX_OS_ALLOCATED_EVENTS already.
> 
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> ---
>  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 6393b3b1d5a6..e0424d5a795a 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -46,7 +46,6 @@
>  #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
> 
>  #define TELEM_MAX_EVENTS_SRAM		28
> -#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
>  #define TELEM_SSRAM_STARTTIME_OFFSET	8
>  #define TELEM_SSRAM_EVTLOG_OFFSET	16
> 
> --
> 2.7.4
Chakravarty, Souvik K July 21, 2017, 3:29 a.m. UTC | #2 
Just missed the email from Darren.

Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@intel.com>

> -----Original Message-----
> From: Chakravarty, Souvik K
> Sent: Friday, July 21, 2017 8:45 AM
> To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@intel.com>; platform-driver-
> x86@vger.kernel.org
> Cc: dvhart@infradead.org; andy@infradead.org; linux-
> kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> Bhardwaj, Rajneesh <rajneesh.bhardwaj@intel.com>
> Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Both set of two looks good. +1.
> 
> > -----Original Message-----
> > From: platform-driver-x86-owner@vger.kernel.org
> > [mailto:platform-driver- x86-owner@vger.kernel.org] On Behalf Of
> > Rajneesh Bhardwaj
> > Sent: Thursday, July 20, 2017 7:51 PM
> > To: platform-driver-x86@vger.kernel.org
> > Cc: dvhart@infradead.org; andy@infradead.org; linux-
> > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> > Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
> > Rajneesh <rajneesh.bhardwaj@intel.com>
> > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> >
> > Telemetry driver includes intel_telemetry.h which defines
> > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> >
> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> > ---
> >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > index 6393b3b1d5a6..e0424d5a795a 100644
> > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > @@ -46,7 +46,6 @@
> >  #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
> >
> >  #define TELEM_MAX_EVENTS_SRAM		28
> > -#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
> >  #define TELEM_SSRAM_STARTTIME_OFFSET	8
> >  #define TELEM_SSRAM_EVTLOG_OFFSET	16
> >
> > --
> > 2.7.4
Darren Hart July 21, 2017, 11:02 p.m. UTC | #3 
On Fri, Jul 21, 2017 at 03:29:39AM +0000, Chakravarty, Souvik K wrote:
> Just missed the email from Darren.

:-)

> Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@intel.com>

Thank you Souvik.

While these one liners are OK for trivial changes like this, please note that
Andy and I depend on individual driver maintainers to provide thorough reviews,
and it helps to document that review to help us understand what sorts of things
you considered before approving the patch. Please keep this in mind in the
future for more complex changes.

This set is on Andy's queue, so the final review/follow-up will come from him.

Thanks,

> 
> > -----Original Message-----
> > From: Chakravarty, Souvik K
> > Sent: Friday, July 21, 2017 8:45 AM
> > To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@intel.com>; platform-driver-
> > x86@vger.kernel.org
> > Cc: dvhart@infradead.org; andy@infradead.org; linux-
> > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> > Bhardwaj, Rajneesh <rajneesh.bhardwaj@intel.com>
> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> > 
> > Both set of two looks good. +1.
> > 
> > > -----Original Message-----
> > > From: platform-driver-x86-owner@vger.kernel.org
> > > [mailto:platform-driver- x86-owner@vger.kernel.org] On Behalf Of
> > > Rajneesh Bhardwaj
> > > Sent: Thursday, July 20, 2017 7:51 PM
> > > To: platform-driver-x86@vger.kernel.org
> > > Cc: dvhart@infradead.org; andy@infradead.org; linux-
> > > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
> > > Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
> > > Rajneesh <rajneesh.bhardwaj@intel.com>
> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> > >
> > > Telemetry driver includes intel_telemetry.h which defines
> > > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> > >
> > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> > > ---
> > >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > index 6393b3b1d5a6..e0424d5a795a 100644
> > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > @@ -46,7 +46,6 @@
> > >  #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
> > >
> > >  #define TELEM_MAX_EVENTS_SRAM		28
> > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
> > >  #define TELEM_SSRAM_STARTTIME_OFFSET	8
> > >  #define TELEM_SSRAM_EVTLOG_OFFSET	16
> > >
> > > --
> > > 2.7.4
> 
>
Andy Shevchenko July 24, 2017, 9:24 a.m. UTC | #4 
On Sat, Jul 22, 2017 at 2:02 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Fri, Jul 21, 2017 at 03:29:39AM +0000, Chakravarty, Souvik K wrote:
>> Just missed the email from Darren.
>
> :-)
>
>> Reviewed-by: Souvik K Chakravarty <souvik.k.chakravarty@intel.com>
>
> Thank you Souvik.
>
> While these one liners are OK for trivial changes like this, please note that
> Andy and I depend on individual driver maintainers to provide thorough reviews,
> and it helps to document that review to help us understand what sorts of things
> you considered before approving the patch. Please keep this in mind in the
> future for more complex changes.
>
> This set is on Andy's queue, so the final review/follow-up will come from him.
>

Pushed both to testing, thanks!

> Thanks,
>
>>
>> > -----Original Message-----
>> > From: Chakravarty, Souvik K
>> > Sent: Friday, July 21, 2017 8:45 AM
>> > To: 'Rajneesh Bhardwaj' <rajneesh.bhardwaj@intel.com>; platform-driver-
>> > x86@vger.kernel.org
>> > Cc: dvhart@infradead.org; andy@infradead.org; linux-
>> > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
>> > Bhardwaj, Rajneesh <rajneesh.bhardwaj@intel.com>
>> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
>> >
>> > Both set of two looks good. +1.
>> >
>> > > -----Original Message-----
>> > > From: platform-driver-x86-owner@vger.kernel.org
>> > > [mailto:platform-driver- x86-owner@vger.kernel.org] On Behalf Of
>> > > Rajneesh Bhardwaj
>> > > Sent: Thursday, July 20, 2017 7:51 PM
>> > > To: platform-driver-x86@vger.kernel.org
>> > > Cc: dvhart@infradead.org; andy@infradead.org; linux-
>> > > kernel@vger.kernel.org; Murthy, Shanth <shanth.murthy@intel.com>;
>> > > Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; Bhardwaj,
>> > > Rajneesh <rajneesh.bhardwaj@intel.com>
>> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
>> > >
>> > > Telemetry driver includes intel_telemetry.h which defines
>> > > TELEM_MAX_OS_ALLOCATED_EVENTS already.
>> > >
>> > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
>> > > ---
>> > >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>> > >  1 file changed, 1 deletion(-)
>> > >
>> > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > b/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > index 6393b3b1d5a6..e0424d5a795a 100644
>> > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > @@ -46,7 +46,6 @@
>> > >  #define TELEM_SAMPLING_DEFAULT_PERIOD    0xD
>> > >
>> > >  #define TELEM_MAX_EVENTS_SRAM            28
>> > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS    20
>> > >  #define TELEM_SSRAM_STARTTIME_OFFSET     8
>> > >  #define TELEM_SSRAM_EVTLOG_OFFSET        16
>> > >
>> > > --
>> > > 2.7.4
>>
>>
>
> --
> Darren Hart
> VMware Open Source Technology Center
diff mbox

Patch

diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 6393b3b1d5a6..e0424d5a795a 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -46,7 +46,6 @@ 
 #define TELEM_SAMPLING_DEFAULT_PERIOD	0xD
 
 #define TELEM_MAX_EVENTS_SRAM		28
-#define TELEM_MAX_OS_ALLOCATED_EVENTS	20
 #define TELEM_SSRAM_STARTTIME_OFFSET	8
 #define TELEM_SSRAM_EVTLOG_OFFSET	16