| Message ID | 1502523858-25716-4-git-send-email-pali.rohar@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
Hi, On 12-08-17 09:44, Pali Rohár wrote: > According to Hans de Goede, WMI interface of thh peaq-wmi module has 10 > instances but corresponding ACPI WMBC method does not check Arg0 (instance > number) at all. Therefore evaluate WMI method with first instance number > (0x0) instead of second (0x1). > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > Cc: Hans de Goede <hdegoede@redhat.com> Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/platform/x86/peaq-wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/peaq-wmi.c b/drivers/platform/x86/peaq-wmi.c > index 77d1f90..f59a5a2 100644 > --- a/drivers/platform/x86/peaq-wmi.c > +++ b/drivers/platform/x86/peaq-wmi.c > @@ -39,7 +39,7 @@ static void peaq_wmi_poll(struct input_polled_dev *dev) > struct acpi_buffer input = { sizeof(dummy), &dummy }; > struct acpi_buffer output = { sizeof(obj), &obj }; > > - status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 1, > + status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 0, > PEAQ_DOLBY_BUTTON_METHOD_ID, > &input, &output); > if (ACPI_FAILURE(status)) >
diff --git a/drivers/platform/x86/peaq-wmi.c b/drivers/platform/x86/peaq-wmi.c index 77d1f90..f59a5a2 100644 --- a/drivers/platform/x86/peaq-wmi.c +++ b/drivers/platform/x86/peaq-wmi.c @@ -39,7 +39,7 @@ static void peaq_wmi_poll(struct input_polled_dev *dev) struct acpi_buffer input = { sizeof(dummy), &dummy }; struct acpi_buffer output = { sizeof(obj), &obj }; - status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 1, + status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 0, PEAQ_DOLBY_BUTTON_METHOD_ID, &input, &output); if (ACPI_FAILURE(status))
According to Hans de Goede, WMI interface of thh peaq-wmi module has 10 instances but corresponding ACPI WMBC method does not check Arg0 (instance number) at all. Therefore evaluate WMI method with first instance number (0x0) instead of second (0x1). Signed-off-by: Pali Rohár <pali.rohar@gmail.com> Cc: Hans de Goede <hdegoede@redhat.com> --- drivers/platform/x86/peaq-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)