From patchwork Tue Feb 27 17:47:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Limonciello, Mario" X-Patchwork-Id: 10245879 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8016460211 for ; Tue, 27 Feb 2018 17:48:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7117728A30 for ; Tue, 27 Feb 2018 17:48:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 652D928A34; Tue, 27 Feb 2018 17:48:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E453628A30 for ; Tue, 27 Feb 2018 17:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbeB0RsJ (ORCPT ); Tue, 27 Feb 2018 12:48:09 -0500 Received: from esa1.dell-outbound.iphmx.com ([68.232.153.90]:55035 "EHLO esa1.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbeB0RsI (ORCPT ); Tue, 27 Feb 2018 12:48:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1519753217; x=1551289217; h=from:to:cc:subject:date:message-id; bh=epxnXo2JBRhhkKjMA5eoXnV8sAQpVtFO7VbBfYN2WTM=; b=c+o+AzvP/AfMRSCN/ZfLKqS+WGLsyPhpKr5oFyVQZDFGJSQtVlNUqr+y j7veJyvYjxVrB6jSf2ojQC2nyghM56EGGJ5RGh3N/hr6g2+11BwUlmkrp BF6BMdu4v4rbySG4HRbJsw2SkQGtktG9pB9g3T1+PN/+na8w4ACX3KVnW 4=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GKAABxmZVah8mZ6EReGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYUmKJt1gxiWPwqFMoJOWBQBAgEBAQEBAQIBAhABAQEKCwkIKC+?= =?us-ascii?q?COCQBgnVST28BEoUVrXU6iHCCSIdKgVeQIwWNcnSLaAmCC45mAo5ykVCBLjWBc?= =?us-ascii?q?3BPgkOBcwFMAxAMghpYjFIBAQE?= X-IPAS-Result: =?us-ascii?q?A2GKAABxmZVah8mZ6EReGQEBAQEBAQEBAQEBAQcBAQEBAYU?= =?us-ascii?q?mKJt1gxiWPwqFMoJOWBQBAgEBAQEBAQIBAhABAQEKCwkIKC+COCQBgnVST28BE?= =?us-ascii?q?oUVrXU6iHCCSIdKgVeQIwWNcnSLaAmCC45mAo5ykVCBLjWBc3BPgkOBcwFMAxA?= =?us-ascii?q?MghpYjFIBAQE?= Received: from esa1.dell-outbound2.iphmx.com ([68.232.153.201]) by esa1.dell-outbound.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2018 11:40:03 -0600 Received: from ausxipps310.us.dell.com ([143.166.148.211]) by esa1.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2018 23:39:59 +0600 X-LoopCount0: from 10.208.86.39 X-IronPort-AV: E=Sophos;i="5.47,401,1515477600"; d="scan'208";a="140744581" X-DLP: DLP_GlobalPCIDSS From: Mario Limonciello To: dvhart@infradead.org, Andy Shevchenko Cc: pali.rohar@gmail.com, LKML , platform-driver-x86@vger.kernel.org, Mario Limonciello Subject: [PATCH v2 1/3] platform/x86: dell-smbios: Correct some style warnings Date: Tue, 27 Feb 2018 11:47:37 -0600 Message-Id: <1519753659-3376-1-git-send-email-mario.limonciello@dell.com> X-Mailer: git-send-email 2.7.4 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: function definition argument 'struct calling_interface_buffer *' should also have an identifier name + int (*call_fn)(struct calling_interface_buffer *); WARNING: Block comments use * on subsequent lines + /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least + 6 bytes of entry */ WARNING: Block comments use a trailing */ on a separate line + 6 bytes of entry */ Signed-off-by: Mario Limonciello --- changes from v1: * Adjust comment style drivers/platform/x86/dell-smbios.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c index 8541cde..76b9d75 100644 --- a/drivers/platform/x86/dell-smbios.c +++ b/drivers/platform/x86/dell-smbios.c @@ -36,7 +36,7 @@ static DEFINE_MUTEX(smbios_mutex); struct smbios_device { struct list_head list; struct device *device; - int (*call_fn)(struct calling_interface_buffer *); + int (*call_fn)(struct calling_interface_buffer *arg); }; struct smbios_call { @@ -352,8 +352,10 @@ static void __init parse_da_table(const struct dmi_header *dm) struct calling_interface_structure *table = container_of(dm, struct calling_interface_structure, header); - /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least - 6 bytes of entry */ + /* + * 4 bytes of table header, plus 7 bytes of Dell header + * plus at least 6 bytes of entry + */ if (dm->length < 17) return;