Message ID | 1553696734-31282-1-git-send-email-mario.limonciello@dell.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Darren Hart |
Headers | show |
Series | platform/x86: dell-laptop: fix rfkill functionality | expand |
On Wed, Mar 27, 2019 at 09:25:34AM -0500, Mario Limonciello wrote: > When converting the driver two arguments were transposed leading > to rfkill not working. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 > Reported-by: Pepijn de Vos <pepijndevos@gmail.com> > Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > Acked-by: Pali Rohár <pali.rohar@gmail.com> Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's been broken that long :-(
> -----Original Message----- > From: Darren Hart <dvhart@infradead.org> > Sent: Wednesday, April 3, 2019 3:24 PM > To: Limonciello, Mario > Cc: Andy Shevchenko; LKML; platform-driver-x86@vger.kernel.org > Subject: Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality > > > [EXTERNAL EMAIL] > > On Wed, Mar 27, 2019 at 09:25:34AM -0500, Mario Limonciello wrote: > > When converting the driver two arguments were transposed leading > > to rfkill not working. > > > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 > > Reported-by: Pepijn de Vos <pepijndevos@gmail.com> > > Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > Acked-by: Pali Rohár <pali.rohar@gmail.com> > > Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's > been broken that long :-( > Not many "newer" platforms actually use this radio control anymore. It's been superseded by other technologies. So I think that would be the main reason. Can you CC it to stable when it's committed or do I need to re-send or anything?
On Wed, Apr 03, 2019 at 09:54:27PM +0000, Mario.Limonciello@dell.com wrote: > > -----Original Message----- > > From: Darren Hart <dvhart@infradead.org> > > Sent: Wednesday, April 3, 2019 3:24 PM > > To: Limonciello, Mario > > Cc: Andy Shevchenko; LKML; platform-driver-x86@vger.kernel.org > > Subject: Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality > > > > > > [EXTERNAL EMAIL] > > > > On Wed, Mar 27, 2019 at 09:25:34AM -0500, Mario Limonciello wrote: > > > When converting the driver two arguments were transposed leading > > > to rfkill not working. > > > > > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 > > > Reported-by: Pepijn de Vos <pepijndevos@gmail.com> > > > Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > > Acked-by: Pali Rohár <pali.rohar@gmail.com> > > > > Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's > > been broken that long :-( > > > > Not many "newer" platforms actually use this radio control anymore. It's been > superseded by other technologies. So I think that would be the main reason. > > Can you CC it to stable when it's committed or do I need to re-send or anything? > I will add the Cc to stable. Just wanted to confirm our expectations were aligned.
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 95e6ca1..a561f65 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -531,7 +531,7 @@ static void dell_rfkill_query(struct rfkill *rfkill, void *data) return; } - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); hwswitch = buffer.output[1]; @@ -562,7 +562,7 @@ static int dell_debugfs_show(struct seq_file *s, void *data) return ret; status = buffer.output[1]; - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); hwswitch_ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); if (hwswitch_ret) return hwswitch_ret; @@ -647,7 +647,7 @@ static void dell_update_rfkill(struct work_struct *ignored) if (ret != 0) return; - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); if (ret == 0 && (status & BIT(0)))