From patchwork Wed Mar 27 14:25:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Limonciello, Mario" X-Patchwork-Id: 10873553 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 137D4922 for ; Wed, 27 Mar 2019 14:26:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F281B28AC3 for ; Wed, 27 Mar 2019 14:26:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E680128AD4; Wed, 27 Mar 2019 14:26:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67BD028AC3 for ; Wed, 27 Mar 2019 14:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728122AbfC0O0B (ORCPT ); Wed, 27 Mar 2019 10:26:01 -0400 Received: from esa4.dell-outbound.iphmx.com ([68.232.149.214]:63613 "EHLO esa4.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbfC0O0B (ORCPT ); Wed, 27 Mar 2019 10:26:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1553696761; x=1585232761; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=APGFYem9Z/+mrl1Cgr1awOzTT4/uhjJN2ut5zsHMZS8=; b=zIVtc8vde+AyF38X8v90NtlphmmOQtzbPFHqB8ZaasPgik4c+RePaxsX I4zao4O3Lr6nvEnbxCeD4B5jW9PYibJdHVBWWqlwvTaxze9NVs6hOzCF4 1e4S+vpTH4JzIaqvyXL9Da8kXmTOKuaVRC69PoYPYvWSc3xtpeplnX2Xc k=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2EUAAAHh5tchyeV50NjHQEBBQEHBQGBUQgBCwGCeIEDJ4QOiBxflgqPBIF7DQEBIwuEPoUxIjQJDQEBAwEBCQEDAgEBAhABAQEKCwkIKSMMgjopARRNawEBAQEBASMCDWYWEQ8BRjUCGA4CIzwBEiKDAAGBXQMVD51cPQJvgQGJBwEBAW+BL4gADYIaBYELJAGGaYRIgVc/hGGCGkcEGIRRglcDkkKSMzYHAoJLBIUdiByDPwIYlAsBiyyGCYE8i3UCBAIEBQIVgU2CD3CDPIIWDgmIX4VdIgExAY90AQE X-IPAS-Result: A2EUAAAHh5tchyeV50NjHQEBBQEHBQGBUQgBCwGCeIEDJ4QOiBxflgqPBIF7DQEBIwuEPoUxIjQJDQEBAwEBCQEDAgEBAhABAQEKCwkIKSMMgjopARRNawEBAQEBASMCDWYWEQ8BRjUCGA4CIzwBEiKDAAGBXQMVD51cPQJvgQGJBwEBAW+BL4gADYIaBYELJAGGaYRIgVc/hGGCGkcEGIRRglcDkkKSMzYHAoJLBIUdiByDPwIYlAsBiyyGCYE8i3UCBAIEBQIVgU2CD3CDPIIWDgmIX4VdIgExAY90AQE Received: from mx0a-00154901.pphosted.com ([67.231.149.39]) by esa4.dell-outbound.iphmx.com with ESMTP/TLS/AES256-SHA256; 27 Mar 2019 09:26:00 -0500 Received: from pps.filterd (m0142693.ppops.net [127.0.0.1]) by mx0a-00154901.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2RENFBr189159; Wed, 27 Mar 2019 10:26:00 -0400 Received: from esa2.dell-outbound2.iphmx.com (esa2.dell-outbound2.iphmx.com [68.232.153.202]) by mx0a-00154901.pphosted.com with ESMTP id 2rg8uprx5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 Mar 2019 10:26:00 -0400 Received: from ausxippc110.us.dell.com ([143.166.85.200]) by esa2.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 27 Mar 2019 20:25:57 +0600 X-LoopCount0: from 10.173.37.27 X-IronPort-AV: E=Sophos;i="5.60,277,1549951200"; d="scan'208";a="770865619" From: Mario Limonciello To: dvhart@infradead.org, Andy Shevchenko Cc: LKML , platform-driver-x86@vger.kernel.org, Mario Limonciello Subject: [PATCH] platform/x86: dell-laptop: fix rfkill functionality Date: Wed, 27 Mar 2019 09:25:34 -0500 Message-Id: <1553696734-31282-1-git-send-email-mario.limonciello@dell.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-27_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903270101 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When converting the driver two arguments were transposed leading to rfkill not working. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 Reported-by: Pepijn de Vos Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") Signed-off-by: Mario Limonciello Acked-by: Pali Rohár --- drivers/platform/x86/dell-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 95e6ca1..a561f65 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -531,7 +531,7 @@ static void dell_rfkill_query(struct rfkill *rfkill, void *data) return; } - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); hwswitch = buffer.output[1]; @@ -562,7 +562,7 @@ static int dell_debugfs_show(struct seq_file *s, void *data) return ret; status = buffer.output[1]; - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); hwswitch_ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); if (hwswitch_ret) return hwswitch_ret; @@ -647,7 +647,7 @@ static void dell_update_rfkill(struct work_struct *ignored) if (ret != 0) return; - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); if (ret == 0 && (status & BIT(0)))