From patchwork Sat Jun 11 18:52:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Azael Avalos X-Patchwork-Id: 9171109 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E018060865 for ; Sat, 11 Jun 2016 18:53:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2E151FF21 for ; Sat, 11 Jun 2016 18:53:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7D7725D91; Sat, 11 Jun 2016 18:53:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72F7C20410 for ; Sat, 11 Jun 2016 18:53:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752236AbcFKSxN (ORCPT ); Sat, 11 Jun 2016 14:53:13 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34641 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbcFKSwx (ORCPT ); Sat, 11 Jun 2016 14:52:53 -0400 Received: by mail-oi0-f67.google.com with SMTP id r4so18617469oib.1; Sat, 11 Jun 2016 11:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oWy+VfmJ1DVRAJp8X7ZriM2FoYkikE4JKV/xKrBCzQc=; b=aSUmKRKwYj+c0hSEyRlgvNCPdbLtnC5XfV9tbhDzLdzcXU6eVs3U+AY1upp1lE5tnM 2nhWSyju9l0NlftBx0TvdU14ElB1dWFfrKcfZ/5AD3KRuhuiaHVyMGO73soRzfhHFa1L eFVpeNSxZbSHaTxADQ4CfPjJD6LWPxf38ifi+qseE9AuGlTJpRkjOk5XA9ykYBctArvw RHvpDo6j3jMuqsH+ce4zy72PBWhlbwHQ/WUJ9kS2T1EXuq6pSyVzcYRTORo2nW/QFdHc 4PpcXE4wGEP+IHCDhmBcjVxxb37r/hI5wCeeSWqt25oZ0nWzrnb3EMEx7K3U10i9aDgi y81Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oWy+VfmJ1DVRAJp8X7ZriM2FoYkikE4JKV/xKrBCzQc=; b=fUI9lbTwaW6khvlBGFWcRPZMvHVxA9YY/qVoG6cDU8sxV3gVmr/jwLxDwhcxucK3C/ 44Ov0PvAVpjG6IX0F0gG5s97wZ+JbmA80X5o4rXEa2RwGho+41Ks5PBINtEHERWL2ubf jiO9Y4lmZlxPtRYzLe9ZNuoP5bOTE/WkTx99079XM6ejxUpeRk3xWu3T4h9WNHGq7BJJ C67xrx9Zjq4/MBPcaAEFf1A3T0BOt8IyoDxV89sw61iqNGzo97v3DPNXXgnWofpK8+kH 5BnApgtnQXyqMX2y/9W5YVKa/FeHDo+dYTrO7O+nfYfClVGpQBZgahnjaiWpSUOCdiN6 6ZIg== X-Gm-Message-State: ALyK8tKb18i/vlBES3bsGjS5a0G57D0cd7rSKkTYTb35UzYUzVgd3Pknor1Uz5fesXV4KA== X-Received: by 10.157.60.42 with SMTP id q39mr4372391otc.189.1465671172442; Sat, 11 Jun 2016 11:52:52 -0700 (PDT) Received: from Shakuras.scurra.org (148-240-208-153.ftth.dynamic.axtel.net. [148.240.208.153]) by smtp.gmail.com with ESMTPSA id j7sm7953171otc.13.2016.06.11.11.52.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 11 Jun 2016 11:52:52 -0700 (PDT) From: Azael Avalos To: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Azael Avalos Subject: [PATCH 2/3] toshiba_acpi: Remove the position sysfs entry Date: Sat, 11 Jun 2016 12:52:44 -0600 Message-Id: <20160611185245.14155-2-coproscefalo@gmail.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20160611185245.14155-1-coproscefalo@gmail.com> References: <20160611185245.14155-1-coproscefalo@gmail.com> Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 85014a3..818b960 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -1961,32 +1961,6 @@ static ssize_t touchpad_show(struct device *dev, } static DEVICE_ATTR_RW(touchpad); -static ssize_t position_show(struct device *dev, - struct device_attribute *attr, char *buf) -{ - struct toshiba_acpi_dev *toshiba = dev_get_drvdata(dev); - u32 xyval, zval; - int x, y, z; - int ret; - - xyval = zval = 0; - ret = toshiba_accelerometer_get(toshiba, &xyval, &zval); - if (ret < 0) - return ret; - - /* Accelerometer values */ - x = xyval & HCI_ACCEL_MASK; - y = (xyval >> HCI_MISC_SHIFT) & HCI_ACCEL_MASK; - z = zval & HCI_ACCEL_MASK; - /* Movement direction */ - x *= xyval & HCI_ACCEL_DIRECTION_MASK ? -1 : 1; - y *= (xyval >> HCI_MISC_SHIFT) & HCI_ACCEL_DIRECTION_MASK ? -1 : 1; - z *= zval & HCI_ACCEL_DIRECTION_MASK ? -1 : 1; - - return sprintf(buf, "%d %d %d\n", x, y, z); -} -static DEVICE_ATTR_RO(position); - static ssize_t usb_sleep_charge_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -2357,7 +2331,6 @@ static struct attribute *toshiba_attributes[] = { &dev_attr_available_kbd_modes.attr, &dev_attr_kbd_backlight_timeout.attr, &dev_attr_touchpad.attr, - &dev_attr_position.attr, &dev_attr_usb_sleep_charge.attr, &dev_attr_sleep_functions_on_battery.attr, &dev_attr_usb_rapid_charge.attr, @@ -2384,8 +2357,6 @@ static umode_t toshiba_sysfs_is_visible(struct kobject *kobj, exists = (drv->kbd_mode == SCI_KBD_MODE_AUTO) ? true : false; else if (attr == &dev_attr_touchpad.attr) exists = (drv->touchpad_supported) ? true : false; - else if (attr == &dev_attr_position.attr) - exists = (drv->accelerometer_supported) ? true : false; else if (attr == &dev_attr_usb_sleep_charge.attr) exists = (drv->usb_sleep_charge_supported) ? true : false; else if (attr == &dev_attr_sleep_functions_on_battery.attr)