From patchwork Sun Jun 19 23:27:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Azael Avalos X-Patchwork-Id: 9186279 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 003E6601C0 for ; Sun, 19 Jun 2016 23:27:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E671D205AA for ; Sun, 19 Jun 2016 23:27:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D9FC4212DA; Sun, 19 Jun 2016 23:27:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E582205AA for ; Sun, 19 Jun 2016 23:27:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbcFSX1J (ORCPT ); Sun, 19 Jun 2016 19:27:09 -0400 Received: from mail-ob0-f195.google.com ([209.85.214.195]:33414 "EHLO mail-ob0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbcFSX1I (ORCPT ); Sun, 19 Jun 2016 19:27:08 -0400 Received: by mail-ob0-f195.google.com with SMTP id f10so2072572obr.0; Sun, 19 Jun 2016 16:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U85XF/vmU63xPl2vDKyAeRN6ofL9EIb7MOkxmYBOZkI=; b=qnuHYlBg//PfxAnQWmtGGmCBaCvncC3xLiiVmspjrZ0A9z4l2Lx2ZavvntIazB8dW2 8EZqDcQ8jyCj4hpv2OnCfr+XpOzUqCguG8PS0feMFHxCZTNsMzINNHHUJ9YuabgJxk0A a5vcfMNCB3cxhdm2q7rj/UvKl828/+OedwCTQ3pIL2PCB/nhgElmnUXvcVX9mfFK0Pr2 4ciYHA02tCmR6Tn7ttIp1Z+yuVu/PCcaWSdS1P+UTG8AxHlcg69ibhSUH4/Fkqky5ZyI xVsm9sAKej7B26C+dT9dbLP6Cv4fovdgdUQromqjl02j3pIboqtWfMtm2UQ4zdAdhHJG JhCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U85XF/vmU63xPl2vDKyAeRN6ofL9EIb7MOkxmYBOZkI=; b=DbrdPkDgMBnYVsDrW6jxrauc4mOSjXImsmb5njWhzno8g9ZxTRn3WEIcIiFpjBsEtB qvjxzSnCjAQA/H7Elw8N213zPuX1CqQPx2T870OEEnQYw3lkAGeUjn6lmw4EMoO5ni8o jPMEe77GZ8meHj5QMH7Ns92rnis1bW2tR/Qp6lGKa2HE4z8iRf5sen2RAG5165JFfzBG lAvQh3CAoT57CEgq1DKuF+C0/JfpKZ3uMWrKOl/QdjMkgSubgftVymJItJi9+yQr4AIH 1g0A7RIQXmt+zHFLbTHcvgtVXSmkxicxPSCSb+zEJmZRDeac8Eeas1qSMelCWUYhnLST ve5w== X-Gm-Message-State: ALyK8tJAGsPsuCrtPAtTQwXlcHmT7pAjf5y80c66cvgwAd9Sp+YE4fglLh5fR7NIWbdWrA== X-Received: by 10.157.27.103 with SMTP id l94mr5315823otl.54.1466378827041; Sun, 19 Jun 2016 16:27:07 -0700 (PDT) Received: from Shakuras.scurra.org (148-240-208-153.ftth.dynamic.axtel.net. [148.240.208.153]) by smtp.gmail.com with ESMTPSA id 65sm24204982otx.16.2016.06.19.16.27.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 19 Jun 2016 16:27:06 -0700 (PDT) From: Azael Avalos To: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Azael Avalos Subject: [PATCH v2 2/3] toshiba_acpi: Remove the position sysfs entry Date: Sun, 19 Jun 2016 17:27:02 -0600 Message-Id: <20160619232703.8820-2-coproscefalo@gmail.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20160619232703.8820-1-coproscefalo@gmail.com> References: <20160619232703.8820-1-coproscefalo@gmail.com> Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 7949929..a9760d2 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -1961,28 +1961,6 @@ static ssize_t touchpad_show(struct device *dev, } static DEVICE_ATTR_RW(touchpad); -static ssize_t position_show(struct device *dev, - struct device_attribute *attr, char *buf) -{ - struct toshiba_acpi_dev *toshiba = dev_get_drvdata(dev); - u32 xyval, zval, tmp; - u16 x, y, z; - int ret; - - xyval = zval = 0; - ret = toshiba_accelerometer_get(toshiba, &xyval, &zval); - if (ret < 0) - return ret; - - x = xyval & HCI_ACCEL_MASK; - tmp = xyval >> HCI_MISC_SHIFT; - y = tmp & HCI_ACCEL_MASK; - z = zval & HCI_ACCEL_MASK; - - return sprintf(buf, "%d %d %d\n", x, y, z); -} -static DEVICE_ATTR_RO(position); - static ssize_t usb_sleep_charge_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -2353,7 +2331,6 @@ static struct attribute *toshiba_attributes[] = { &dev_attr_available_kbd_modes.attr, &dev_attr_kbd_backlight_timeout.attr, &dev_attr_touchpad.attr, - &dev_attr_position.attr, &dev_attr_usb_sleep_charge.attr, &dev_attr_sleep_functions_on_battery.attr, &dev_attr_usb_rapid_charge.attr, @@ -2380,8 +2357,6 @@ static umode_t toshiba_sysfs_is_visible(struct kobject *kobj, exists = (drv->kbd_mode == SCI_KBD_MODE_AUTO) ? true : false; else if (attr == &dev_attr_touchpad.attr) exists = (drv->touchpad_supported) ? true : false; - else if (attr == &dev_attr_position.attr) - exists = (drv->accelerometer_supported) ? true : false; else if (attr == &dev_attr_usb_sleep_charge.attr) exists = (drv->usb_sleep_charge_supported) ? true : false; else if (attr == &dev_attr_sleep_functions_on_battery.attr)