From patchwork Thu Feb 2 14:25:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9551977 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CADA260236 for ; Thu, 2 Feb 2017 14:28:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB9DF28408 for ; Thu, 2 Feb 2017 14:28:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E67428435; Thu, 2 Feb 2017 14:28:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0DB5F28408 for ; Thu, 2 Feb 2017 14:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751308AbdBBO2l (ORCPT ); Thu, 2 Feb 2017 09:28:41 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:59671 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbdBBO2l (ORCPT ); Thu, 2 Feb 2017 09:28:41 -0500 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MDYsf-1cgmbu3QWj-00GsMt; Thu, 02 Feb 2017 15:27:47 +0100 From: Arnd Bergmann To: Darren Hart , Andy Shevchenko Cc: Hans de Goede , Arnd Bergmann , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86: silead depends on I2C being built-in Date: Thu, 2 Feb 2017 15:25:57 +0100 Message-Id: <20170202142744.3418986-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ffPaIi5hDOBJwyK3y7jmjAvLN9uq8x11pFLB7OMJ2OjyuKU71jQ 70y4B67l0mFvzYW/h2rjXF9towSsiySsoc6R8O7mI9r0i7yemTbHg7ruTH9O19n4oO3EdgR N0ummPKutc17pZjOg/Elz5+lcbHMSZAyPz7OMBnUTUTxIwE1UlcauCUz1ApqnilYO5X20Nl PEReJgOAv0TceKYZY1pAg== X-UI-Out-Filterresults: notjunk:1; V01:K0:AWnhB8DxkU4=:GG6FWXDrSCLwC5/zSdsqqj BIhvy5RJFYN3YTNrhhkC3NqdL/GmUsVq4eVXvFDr0zLwybh3JXK1PPU/lYvUK+UIamHCmZe0d 1/uGmgc8mhcbU6MMDzT5t/ptddX4MBogaHmctDcNnGd5iA0b/7F1o56ySNA2hjCsyhNHhUyjh il2j0XYvhhkunWnVWTpDyuQrI3b8puAeWbtHyGmY06Ru1BeUfBGKyTiTcMs+lQbviSMpnVC5C yq5+zjCfbMwBwgi8TbnQQCZbpMCVRcwks4E9Y67X4Kv+PIz3zE4ve+JrFum+epYpNVqFFZr9Z 9bPckJYP/u31Gm6pqwDURCOBCQNYNxJ3aSKKDMm/KdtUGdiULdeFspavDK6wH/Q/jqXNSK03R ABu8nhwwOffo4CFTIHMazIO/2SLRHlFKuuyE6zIgX630GlEEUCcPG3A3Z3smDRz8IknRktJWh 25fcskkjPlhEbVIbfZhu681hhYTDB/yaeJCZmoT0QPj607evkPPq3TttDR+HSIotEdIRgxdA2 G7ROwUCiKqvtm5rox3uyEpiiouP6EQZj+zoyWoJSrLDtuvglEEE9HQKQigeV2YuAomtxBRNSG MF7H2+nDMQ9iKBG2DM+a/p8wAKz79sSja/gdG34rIQvCIexKkN4UPxIbM5576pw4brVK9Yirg Vcj/s3/9DK8Y5O4RfyHIKj2a3F1m4bN9wfSeLuvbHaQW874ZPKyjgpBckZOnhPed1tgk= Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The new driver cannot be a loadable module, so if I2C is loadable, we get this link error: drivers/platform/built-in.o: In function `silead_ts_dmi_init': silead_dmi.c:(.init.text+0x2ef): undefined reference to `i2c_bus_type' This makes the Kconfig dependency stricter to require I2C=y. Fixes: 9eeda3897a85 ("platform/x86: add support for devices with Silead touchscreens") Signed-off-by: Arnd Bergmann Acked-by: Hans de Goede --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index dd4952ac8797..a7fe9b9f975d 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle