From patchwork Thu Mar 30 10:35:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9653729 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C49A6034C for ; Thu, 30 Mar 2017 10:39:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17E9328582 for ; Thu, 30 Mar 2017 10:39:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 095B52857F; Thu, 30 Mar 2017 10:39:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA2AA2857F for ; Thu, 30 Mar 2017 10:39:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933124AbdC3KfV (ORCPT ); Thu, 30 Mar 2017 06:35:21 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33326 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933347AbdC3KfT (ORCPT ); Thu, 30 Mar 2017 06:35:19 -0400 Received: by mail-lf0-f65.google.com with SMTP id r36so4188244lfi.0 for ; Thu, 30 Mar 2017 03:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wj//FwUNMrq0ZbZ577k3nrXK5iQWNxUXIG0YHVEj97M=; b=bHaWE+L7xrEjhpKJCV9acDVaHn8CE+xotsfeXk2/x/JDgtg3b4W80SIKVprJ8GkLsq Fnt58wLi6L5cC355JL3fz3jQLFdiyVZEn+ED5LJNULA+uuAdkDnWzkkv6OW/wCetjlmd 5OObJ0EIpuomgLLwuAHwKVVczIqdUs/hORBOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wj//FwUNMrq0ZbZ577k3nrXK5iQWNxUXIG0YHVEj97M=; b=hP2vxE9XBq994fiUpYqU53XeQsQcnUPS4gLYqt5iUDk4/EmtrcC00UXJvMOREe5Dko ORXDg7C8eiJns6xmz5dkpwengbkhfZZGYVmfUq431W2067QyW9lNKdlFbXKvvwcj3Ygh 8Mt9zmIVpQ25DQzW/2vWgxlUYT9PmkRVcZ4dWI9nNZqB1oR825AOc1Fupl6eOQT3U9lC FZenG5xWazXxBmmVkzUhY31kgzE5yI09IgI2P5raZCajqgbmKvm+NnSl2jne8joE3Oil f/pqHkLebYuN8cQ9u6MbtezEofb0a5baKncSxI1WYBaR/G6GYr4zaraPZqFoeLJTGGTQ x6FQ== X-Gm-Message-State: AFeK/H1/xPMkUJCKHHsbZyJLgm7MKrtpd3ufjv6xXaMaYlkIK/FHfrGO07NDTg4S8Z0RWA== X-Received: by 10.46.33.135 with SMTP id h7mr1903800lji.96.1490870117008; Thu, 30 Mar 2017 03:35:17 -0700 (PDT) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id x1sm296975lfb.54.2017.03.30.03.35.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 03:35:16 -0700 (PDT) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] platform/x86: fujitsu-laptop: simplify set_lcd_level() Date: Thu, 30 Mar 2017 12:35:02 +0200 Message-Id: <20170330103509.32509-5-kernel@kempniu.pl> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170330103509.32509-1-kernel@kempniu.pl> References: <20170330103509.32509-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP acpi_execute_simple_method() takes a method parameter which tells it to look for the given method underneath the given handle, so calling acpi_get_handle() beforehand is redundant. Replace the call to acpi_get_handle() with a call to acpi_execute_simple_method(), thus eliminating the need for a local variable storing the handle. Also do not assign a default value to status as it has no influence on execution flow. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 5005400b57bb..b888ba190fb2 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -358,8 +358,7 @@ static enum led_brightness eco_led_get(struct led_classdev *cdev) static int set_lcd_level(int level) { - acpi_status status = AE_OK; - acpi_handle handle = NULL; + acpi_status status; char *method; switch (use_alt_lcd_levels) { @@ -377,16 +376,13 @@ static int set_lcd_level(int level) if (level < 0 || level >= fujitsu_bl->max_brightness) return -EINVAL; - status = acpi_get_handle(fujitsu_bl->acpi_handle, method, &handle); + status = acpi_execute_simple_method(fujitsu_bl->acpi_handle, method, + level); if (ACPI_FAILURE(status)) { vdbg_printk(FUJLAPTOP_DBG_ERROR, "%s not present\n", method); return -ENODEV; } - status = acpi_execute_simple_method(handle, NULL, level); - if (ACPI_FAILURE(status)) - return -ENODEV; - return 0; }