From patchwork Thu Mar 30 10:35:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9653715 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 041B560113 for ; Thu, 30 Mar 2017 10:38:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2F6028581 for ; Thu, 30 Mar 2017 10:38:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D70DF28582; Thu, 30 Mar 2017 10:38:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8583C2857F for ; Thu, 30 Mar 2017 10:38:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933650AbdC3KiR (ORCPT ); Thu, 30 Mar 2017 06:38:17 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33802 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933651AbdC3KfW (ORCPT ); Thu, 30 Mar 2017 06:35:22 -0400 Received: by mail-lf0-f68.google.com with SMTP id x137so4173357lff.1 for ; Thu, 30 Mar 2017 03:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JcHacM0LVQdRGgVGBnTyLW9ngWueYkWjEeGxHIv/zzA=; b=ClRjLyAWOmCTfMcSXh8DYagbmgmTlglcQzUlvJpYbKnNcwUtXUZhnf7l73IuneHDZ3 ZKm2FiJO0PXAoPyuXztKsiPqFrjmmr+BMThgLibFbj9phsrTf+8dql0cLrW2oXKwPBbR sB3dq29qEP1DvOhUv91Gn5yifH94zLFB0m8ME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JcHacM0LVQdRGgVGBnTyLW9ngWueYkWjEeGxHIv/zzA=; b=kD+5EE1vtYXizJoWJT7DnYoiO/UYwu766DPm9pN6S8jlZ4WnC7/8/0nGDYjqPDycyL PSiWhqv3BVJNdOqIl1xWquy5OPkdjJWty+gDKlcp8vvdeJIf2kK86RVl+b7zp9GrwIvN nle6Vu86jSYOJUEyoxDP1jjhLrFQqFYGNMHFId5sTJnPq0haFZjRcSY+2V/nze1KjEVB PzQqjUo0xdpwEDAhULSTRQPYpb3+xJHzp6CEJdI1IKjovTZILKvy3y4wNCrFzxk4r5zm PBpb1fdxsdLU6KcPdnjqMyquEDuYOE7JzequeQQXsJ12i3fEKwqrE4h8H9NdYdA4JcJu lyPw== X-Gm-Message-State: AFeK/H3Sej/PYqEF+uXZYfaMNI85+vtbHBCuqeiGhJs8XqRz+KIeJHTyIUit5lOKfsFfUg== X-Received: by 10.46.32.151 with SMTP id g23mr1712622lji.2.1490870120344; Thu, 30 Mar 2017 03:35:20 -0700 (PDT) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id x1sm296975lfb.54.2017.03.30.03.35.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 03:35:19 -0700 (PDT) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/11] platform/x86: fujitsu-laptop: ignore errors when setting backlight power Date: Thu, 30 Mar 2017 12:35:06 +0200 Message-Id: <20170330103509.32509-9-kernel@kempniu.pl> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170330103509.32509-1-kernel@kempniu.pl> References: <20170330103509.32509-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Not all Fujitsu laptops support controlling backlight power through the FUJ02E3 ACPI device. Remove the debug message informing about a failed attempt to set backlight power as it may be confusing and the return value of call_fext_func() is logged anyway. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 84c2bd55526f..ed9c37e0591d 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -444,13 +444,9 @@ static int bl_update_status(struct backlight_device *b) { int ret; if (b->props.power == FB_BLANK_POWERDOWN) - ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x3); + call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x3); else - ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x0); - if (ret != 0) - vdbg_printk(FUJLAPTOP_DBG_ERROR, - "Unable to adjust backlight power, error code %i\n", - ret); + call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x0); ret = set_lcd_level(b->props.brightness); if (ret != 0)