From patchwork Mon Apr 3 09:38:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9659137 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F2AAB60353 for ; Mon, 3 Apr 2017 09:39:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4B5D283ED for ; Mon, 3 Apr 2017 09:39:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D91D3284A5; Mon, 3 Apr 2017 09:39:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 651D8283ED for ; Mon, 3 Apr 2017 09:39:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbdDCJjL (ORCPT ); Mon, 3 Apr 2017 05:39:11 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36284 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbdDCJjK (ORCPT ); Mon, 3 Apr 2017 05:39:10 -0400 Received: by mail-lf0-f68.google.com with SMTP id n78so12309854lfi.3 for ; Mon, 03 Apr 2017 02:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JCOHQTi7m+uHh6rCpZlFzjhGqGrSMUSFfMblVknXGAU=; b=ZhwYPvXZY/UdCwFMs0C4DGk63LF0dhEM8fU9j1lRHG5iGtTPqoiCCy6IMmras+Wfi5 CSOXhR6kHpwoU4AVwqZN3E5pqGVr1vqnb7+IQTqoAdpeLttdY9KrZ4oq0BUTE8asgnqs YHe63j/v+yNVj+7fe0HD7O0pc3xJ2py0MB5L4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JCOHQTi7m+uHh6rCpZlFzjhGqGrSMUSFfMblVknXGAU=; b=lL5dBbx9lB1lAZrHlKiVd1ICHi1c3rODVGcjB57HJgXPkkieQ9mE8KrUoK6KBK4WLf E27EFkSawX+PAwZ9lZtbubeYbugDaRUCEvx0bTJPuZmAnCYacgo+wLhIDlzuxCdv+2k3 8ECCn6yMx+/i9HGDOjRcFdulNcIX4734GRnM8jhCJePDrlnMl6e4vmHyNw0BP96wJE8R rg33umwEPra+owK7MIhViPu4+KW+W0vr5lflMPDPDdD4KknH0cwewU46cMAG14fXF6Kv LypBu9BKmIYur4cBe6j3DO9hWNSZIVq4rUH8X0yWxa3J2ZF6KdV4OMwf23zM1rvO4FlQ pXkw== X-Gm-Message-State: AFeK/H2VuqqxDMmN7dZdFt2KDPPfMlMEyj0lNNQWgjK6TGdQcqB4GmRDsl+cB9+UcWkUrg== X-Received: by 10.25.158.8 with SMTP id h8mr5016575lfe.5.1491212349316; Mon, 03 Apr 2017 02:39:09 -0700 (PDT) Received: from ozzy.hq.kempniu.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id y15sm2439945ljd.41.2017.04.03.02.39.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Apr 2017 02:39:08 -0700 (PDT) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] platform/x86: fujitsu-laptop: clean up local variables in call_fext_func() Date: Mon, 3 Apr 2017 11:38:57 +0200 Message-Id: <20170403093859.6685-2-kernel@kempniu.pl> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170403093859.6685-1-kernel@kempniu.pl> References: <20170403093859.6685-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Set values of FUNC call parameters in a designated initializer. Do not initialize status and handle variables as the values these are initialized to have no influence on execution flow. Use an array variable instead of the address of the first element of that array. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index f66da4b0c31a..ca1491ff659e 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -219,16 +219,16 @@ static u32 dbg_level = 0x03; static int call_fext_func(int cmd, int arg0, int arg1, int arg2) { - acpi_status status = AE_OK; union acpi_object params[4] = { - { .type = ACPI_TYPE_INTEGER }, - { .type = ACPI_TYPE_INTEGER }, - { .type = ACPI_TYPE_INTEGER }, - { .type = ACPI_TYPE_INTEGER } + { .integer.type = ACPI_TYPE_INTEGER, .integer.value = cmd }, + { .integer.type = ACPI_TYPE_INTEGER, .integer.value = arg0 }, + { .integer.type = ACPI_TYPE_INTEGER, .integer.value = arg1 }, + { .integer.type = ACPI_TYPE_INTEGER, .integer.value = arg2 } }; - struct acpi_object_list arg_list = { 4, ¶ms[0] }; + struct acpi_object_list arg_list = { 4, params }; unsigned long long value; - acpi_handle handle = NULL; + acpi_status status; + acpi_handle handle; status = acpi_get_handle(fujitsu_laptop->acpi_handle, "FUNC", &handle); if (ACPI_FAILURE(status)) { @@ -237,11 +237,6 @@ static int call_fext_func(int cmd, int arg0, int arg1, int arg2) return -ENODEV; } - params[0].integer.value = cmd; - params[1].integer.value = arg0; - params[2].integer.value = arg1; - params[3].integer.value = arg2; - status = acpi_evaluate_integer(handle, NULL, &arg_list, &value); if (ACPI_FAILURE(status)) { vdbg_printk(FUJLAPTOP_DBG_WARN,