From patchwork Wed Apr 5 06:49:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9663081 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 28EE160364 for ; Wed, 5 Apr 2017 06:52:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A49A281B7 for ; Wed, 5 Apr 2017 06:52:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0F2C5284FE; Wed, 5 Apr 2017 06:52:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BCCDA28507 for ; Wed, 5 Apr 2017 06:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbdDEGwk (ORCPT ); Wed, 5 Apr 2017 02:52:40 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34903 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753861AbdDEGtS (ORCPT ); Wed, 5 Apr 2017 02:49:18 -0400 Received: by mail-lf0-f65.google.com with SMTP id v2so355225lfi.2 for ; Tue, 04 Apr 2017 23:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8X81S4NmOjGK5xLG466edsawh+6xw8YQboboYnL2Y0I=; b=FMba71y1tv3eOgHJOpVkzCHs0sm3+s/4d7LcFSZajrTwL29sUuGXS6enaiN1rE6tWI PsW5e2vy9hsKp0hfIvRhpeTV74BzSuqdnEoUS53gEoXxhx9Dmt503GL4PF8OOGrI2zhc hm1upnnNmmg7VxQF9T2SbKIzgLVXcGn9/uYgk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8X81S4NmOjGK5xLG466edsawh+6xw8YQboboYnL2Y0I=; b=YNLK88VoauiPDzqmTC1B3mvLUOzD425JqfRnyNBFv/Z1QMT3v6y6240D8Jmb+1GiP7 HAtp08wkjZ6nhVRTz17urn6SCpU45s7pDDo4AauVE+4nYSwDU9YUN1M18FHIeO4R1WiH kBgwsWMrVMXhVab3yZtU2hD6mK12a83SuZJT0vnanrdfKJcgKHxuzR8rjeRR7a43M2/T +acmgPfr5n7+hPtE13l7m4v9dhURF01yym1uHD9Q6UY4fzJyOST8YVPDnCtJQyrc9bh5 NWyYShKcUbnlA7IbOkTbGj6zjibH3FQKBp/i6vvxg2DlY39B7naYM07Zthe+Lu08T35R jJCg== X-Gm-Message-State: AFeK/H2/LLB+K3q+ni/Wd+MgHrsaHh4MoO9X6ZXm/GFa/3tl5FM05tgKpfDqOE25W40KRw== X-Received: by 10.46.88.85 with SMTP id x21mr7950123ljd.90.1491374956947; Tue, 04 Apr 2017 23:49:16 -0700 (PDT) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id o91sm3619921lfg.1.2017.04.04.23.49.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 23:49:16 -0700 (PDT) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/11] platform/x86: fujitsu-laptop: simplify set_lcd_level() Date: Wed, 5 Apr 2017 08:49:03 +0200 Message-Id: <20170405064910.3162-5-kernel@kempniu.pl> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170405064910.3162-1-kernel@kempniu.pl> References: <20170405064910.3162-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP acpi_execute_simple_method() takes a method parameter which tells it to look for the given method underneath the given handle, so calling acpi_get_handle() beforehand is redundant. Replace the call to acpi_get_handle() with a call to acpi_execute_simple_method(), thus eliminating the need for a local variable storing the handle. Update debug message to reflect this change. Also do not assign a default value to status as it has no influence on execution flow. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 2f563aa00592..6d4a2a36716b 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -358,8 +358,7 @@ static enum led_brightness eco_led_get(struct led_classdev *cdev) static int set_lcd_level(int level) { - acpi_status status = AE_OK; - acpi_handle handle = NULL; + acpi_status status; char *method; switch (use_alt_lcd_levels) { @@ -377,16 +376,14 @@ static int set_lcd_level(int level) if (level < 0 || level >= fujitsu_bl->max_brightness) return -EINVAL; - status = acpi_get_handle(fujitsu_bl->acpi_handle, method, &handle); + status = acpi_execute_simple_method(fujitsu_bl->acpi_handle, method, + level); if (ACPI_FAILURE(status)) { - vdbg_printk(FUJLAPTOP_DBG_ERROR, "%s not present\n", method); + vdbg_printk(FUJLAPTOP_DBG_ERROR, "Failed to evaluate %s\n", + method); return -ENODEV; } - status = acpi_execute_simple_method(handle, NULL, level); - if (ACPI_FAILURE(status)) - return -ENODEV; - return 0; }