From patchwork Wed Apr 5 06:49:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 9663041 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B69D460353 for ; Wed, 5 Apr 2017 06:49:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A5446284FE for ; Wed, 5 Apr 2017 06:49:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 975242850D; Wed, 5 Apr 2017 06:49:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28948284FE for ; Wed, 5 Apr 2017 06:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754447AbdDEGta (ORCPT ); Wed, 5 Apr 2017 02:49:30 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34955 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754396AbdDEGt1 (ORCPT ); Wed, 5 Apr 2017 02:49:27 -0400 Received: by mail-lf0-f68.google.com with SMTP id v2so355502lfi.2 for ; Tue, 04 Apr 2017 23:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jNcRr8GfIlXv8KmhR0IFHhlExJkt/Q1i04on9hcfbSY=; b=T67Hxe3BelMJRGmqMx/aYicoYzZkxehQBdaqzVVsO68Bg8CsvG6XWa2V72iGv+xfA2 21qRBu8Wiu/CnE9TaYLCdVKO6oORA3XhhPvf7PNC5FhmUNvcVe+zz8m3fnUU0kWTWH4E yBYlad/h+UVh7IHtF7Ylsmrmw/OCnHN9hIYkU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jNcRr8GfIlXv8KmhR0IFHhlExJkt/Q1i04on9hcfbSY=; b=qsArb3O2PxBZSkrjvOuZ47vsSNMnV7NukSmK3VmMwXHPH/m2NA56r60JHhVFJkAI69 qiaH0zoXvgdfZr+1YoETqNF8++itYQW1Ey58pRzklu1z3ynZF9CnviJJcD70xH4zVDxK AIPWaSLr54fXXoIKSQZPg3tJ1r+LAmvYhCNf/jxmDwQD3J5TTM4y9Diml+WzW+S6Ke6h sXNVcTmgq/zddB9uYqzdGs3Da85XdGliVQ2Il3HgrM81REcTWjPa2EcmWrztYftjJACd dbeh3QS29UIs5go9/x6yd0RIdn3XtzkyCOgKVdQt54oDs4ROPa+2nycSiwSmGMrA9+cL 1Gdw== X-Gm-Message-State: AFeK/H0z5kvEbFs0sydm+a2zFuOeQDczmXz6M7kS+J9vKWYWzBlgjjKoi6xU6DMwncwd3w== X-Received: by 10.25.16.70 with SMTP id f67mr8442242lfi.136.1491374960328; Tue, 04 Apr 2017 23:49:20 -0700 (PDT) Received: from ozzy.nask.waw.pl ([2001:a10:160:3::3]) by smtp.googlemail.com with ESMTPSA id o91sm3619921lfg.1.2017.04.04.23.49.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 23:49:19 -0700 (PDT) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/11] platform/x86: fujitsu-laptop: ignore errors when setting backlight power Date: Wed, 5 Apr 2017 08:49:07 +0200 Message-Id: <20170405064910.3162-9-kernel@kempniu.pl> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170405064910.3162-1-kernel@kempniu.pl> References: <20170405064910.3162-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Not all Fujitsu laptops support controlling backlight power through the FUJ02E3 ACPI device. Remove the debug message informing about a failed attempt to set backlight power as it may be confusing and the return value of call_fext_func() is logged anyway. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index a3e9efd1ac88..0cd58c96938c 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -445,13 +445,9 @@ static int bl_update_status(struct backlight_device *b) { int ret; if (b->props.power == FB_BLANK_POWERDOWN) - ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x3); + call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x3); else - ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x0); - if (ret != 0) - vdbg_printk(FUJLAPTOP_DBG_ERROR, - "Unable to adjust backlight power, error code %i\n", - ret); + call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x0); ret = set_lcd_level(b->props.brightness); if (ret != 0)