From patchwork Fri Apr 21 21:03:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9693743 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A2319601D4 for ; Fri, 21 Apr 2017 21:04:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 91E3828662 for ; Fri, 21 Apr 2017 21:04:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 833F828648; Fri, 21 Apr 2017 21:04:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1709328648 for ; Fri, 21 Apr 2017 21:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1041149AbdDUVES (ORCPT ); Fri, 21 Apr 2017 17:04:18 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:49854 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1041148AbdDUVER (ORCPT ); Fri, 21 Apr 2017 17:04:17 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0MbtTu-1ckYZC41gs-00JKtz; Fri, 21 Apr 2017 23:03:21 +0200 From: Arnd Bergmann To: Darren Hart , Andy Shevchenko Cc: Arnd Bergmann , Hans de Goede , Rajneesh Bhardwaj , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86: INT33FE: add I2C dependency Date: Fri, 21 Apr 2017 23:03:13 +0200 Message-Id: <20170421210331.876697-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:5rKsDLSQPRR/3qUb6DeLG51KyJOKzEikaik5wlRIOLGsTeBj+Zq OYu714dgnnAwcu2eBI14oNs0CtRb+gn582qbAfC1GsB+vx0wmRkR8clAtrGN4KeUkXOpkwG I/NNVTdyBaWzmJvt+rlP5JWdo6BTJtIh0m/xkSx0xCGxCJUeBO9zqt/4cuDBKlkDnZws5qz Tv8jSc2kdEonDqyrv9otQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:0DqfqHe4iYk=:I7qwgM/bF0HJIWupPsU9NS Wcdc//nHWePlQ2I7w3njRPgJsIuIF6AhdPCemkQGqDWFG/NA1FA/T/i7PyTfd8oFjcT1dtF2I qtShv6WrNAa2jMEZWicrZeNSHei4bUKtdu/TRPAvrl40ZGyDqcf5ezNLqSoOv8HsXsZadEnBn YI/LvIaEm1tVAzXku8zp1/GiUMDM0JFA5b9NvKu5QP+jHhlWzz/LbBjyJGeLxBZUONahJKpV9 DHSaXMyfmDdy+9ppCZJR3zDCKIHP2RqRgmjbu8w+/RxkVVXmIqIFco6AJeKxitglSv7ZJSmIv mL94REZxjNF0nVMlW34R3okP1ykZ+T3nkMxgnT/RDnXOftUvRvZJ/hrLRnq5kH+dQf1gxhTyI ZfgsPuIKZfNYMwbbjcU24T8BqNVGyPvZfLHLyvjvyZg4UKYR9fchr8yke9DNOmGoHKPhqrOsg CcNXqCyEfcPhFkpXVFkHA4eDHi7bqRM2E+kaTfU31HoyLNll1sFEchD2FZL8wEILKfNEb45qh vSHvErnm4GgnU2vCLiNieXK1F1NXskLtlJaPFTGtQgytv6GENS1er1l6Rg0eDRADqfVQm21gB 6/1DD7j3Wj9SNpJh6MnirYlyOiVzH3qEI+NNI8CfB7aLgFRP3PB8MiiZkNV2P8grIm6+GljOB pQwSNHeOxFdJgq+tzTtJ58+PazHAKNuVWz4yhnnzrBIlHL8OMkri8WYZr6yNvd1zsKwg= Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When I2C is disabled, we get a link error: drivers/platform/built-in.o: In function `cht_int33fe_remove': intel_cht_int33fe.c:(.text+0x8ba): undefined reference to `i2c_unregister_device' drivers/platform/built-in.o: In function `cht_int33fe_probe': intel_cht_int33fe.c:(.text+0x9ec): undefined reference to `i2c_acpi_new_device' intel_cht_int33fe.c:(.text+0xa7a): undefined reference to `i2c_unregister_device' This adds a Kconfig dependency to ensure I2C is available to this driver. Fixes: 1cd706df8a9c ("platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver") Signed-off-by: Arnd Bergmann --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 76ced87efde5..4c7db1fbac26 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -782,7 +782,7 @@ config ACPI_CMPC config INTEL_CHT_INT33FE tristate "Intel Cherry Trail ACPI INT33FE Driver" - depends on X86 && ACPI + depends on X86 && ACPI && I2C ---help--- This driver add support for the INT33FE ACPI device found on some Intel Cherry Trail devices.