| Message ID | 20170720160114.3261176-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Darren Hart |
| Headers | show |
On Thu, Jul 20, 2017 at 06:00:50PM +0200, Arnd Bergmann wrote: > The new driver fails to build without INPUT_POLLDEV > > drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_exit': > peaq-wmi.c:(.exit.text+0x1c): undefined reference to `input_unregister_polled_device' > drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_init': > peaq-wmi.c:(.init.text+0x23): undefined reference to `input_allocate_polled_device' > peaq-wmi.c:(.init.text+0x18e): undefined reference to `input_register_polled_device' > > For some reason, all other drivers that need this use 'select' > here rather than 'depends on', so I'm doing the same. > > Fixes: 13bb0fd5519d ("platform/x86: peaq-wmi: Add new peaq-wmi driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Queued to fixes branch for 4.13-rcX. I'll leave patch 2/2 to andy since you worked that one together already.
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 2b209f5d42ff..d9238e9ff54a 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -672,6 +672,7 @@ config PEAQ_WMI tristate "PEAQ 2-in-1 WMI hotkey driver" depends on ACPI_WMI depends on INPUT + select INPUT_POLLDEV help Say Y here if you want to support WMI-based hotkeys on PEAQ 2-in-1s.
The new driver fails to build without INPUT_POLLDEV drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_exit': peaq-wmi.c:(.exit.text+0x1c): undefined reference to `input_unregister_polled_device' drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_init': peaq-wmi.c:(.init.text+0x23): undefined reference to `input_allocate_polled_device' peaq-wmi.c:(.init.text+0x18e): undefined reference to `input_register_polled_device' For some reason, all other drivers that need this use 'select' here rather than 'depends on', so I'm doing the same. Fixes: 13bb0fd5519d ("platform/x86: peaq-wmi: Add new peaq-wmi driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)