From patchwork Thu Jul 20 16:00:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9855271 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D12A360392 for ; Thu, 20 Jul 2017 16:01:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C165C223C7 for ; Thu, 20 Jul 2017 16:01:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B575626E4E; Thu, 20 Jul 2017 16:01:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 529C3223C7 for ; Thu, 20 Jul 2017 16:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935907AbdGTQBt (ORCPT ); Thu, 20 Jul 2017 12:01:49 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:59860 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934497AbdGTQBs (ORCPT ); Thu, 20 Jul 2017 12:01:48 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MJkO4-1dZKLg09Bs-00196Q; Thu, 20 Jul 2017 18:01:16 +0200 From: Arnd Bergmann To: Darren Hart , Andy Shevchenko Cc: Arnd Bergmann , Hans de Goede , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] platform/x86: peaq-wmi: select INPUT_POLLDEV Date: Thu, 20 Jul 2017 18:00:50 +0200 Message-Id: <20170720160114.3261176-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:HhFqqrI2AP8d1rmq6s/oUfMxtoXPvNTOtmL3AIVdeNr2Gem122E st7v7SoswNJryxeIAScNssYrXA4NwFeYrtrmfnecBajzLUICEKENxDUAoB36RFTtSLa0g5G UqFOgrNnwwOVEcGsJ7bwBbTTfg7p26yks4be2p//PeczdOr8GW4qEetlUrqr7GaoK/WrvX3 gCN35tw4XMPEqQSW0QmuA== X-UI-Out-Filterresults: notjunk:1; V01:K0:e/yY5OfflWQ=:17ejynq8vaNxEo2ltnfjgv sjHdXvNu0Zp9Yz5xho5nW0nlk1OMGkp/UMlgePfOE0Vu6GlzBO2tkHutgendjSwFm8epYnGXk dFL54AEfpdFnTRxpbCNjIYzI5/uRaGTuTKo5dYPn7Ji5cCugHUWpqSXDMTkYNWatjn/0G0GFK nz76Utn8faA3x16JBgiZ3dKZ1vhS//DYgim5LFeY7jQhgXblWFZqLeIKGiaJWkH6jOF+EGFTO dS3H4k1R22tM0fliUAMyx77rBM/TfZErReVUKGL7Bp5Bb5i2CSExTdP4rn94gCrPOqUz15x2I SA0IVUSNsw3nuFa0Nu4wul4Sn0wgmQ3eaqm9JsNAa529nLX5e7G7IO234pNsjPfLexjQSiKYe c/dNDJ/eTvTM2FsN0gBQ897TTIfbLmooMjbuvTnKPWbPHBrWT+WOu9DME+lgeOo+A0w6oIKCG rqjDSd17cVQiVK0oNaTHG9s/NqKIis2QcoWcx9Mbj6tMxaWLZA+XBatburqFzzmHsrVnK642S jXyV+Lbo9/PdGGCaF6Wy+X/XCm2Q/NGNQnCsg7GPitGdvlrBuosk2Iv8HfLlK7Eu3y4+PXJ8B mMTYH6dCfjOQ1yrJbISK7jpC160dZeUsOIUQcDYPxOB1zZzCUeqcoxGqx9Yn2U/MsYq9/ygOu YEAL0iydytjalZHO3L9WUUlbtCOHPycZyRmkFuX3LVFvTi3SUCgq/rYfpAVSeYKXA0pKvr7/P 8RbgAx6x1ZKY3ZPy4Du25zFOCbdooNsqCc6aMA== Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The new driver fails to build without INPUT_POLLDEV drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_exit': peaq-wmi.c:(.exit.text+0x1c): undefined reference to `input_unregister_polled_device' drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_init': peaq-wmi.c:(.init.text+0x23): undefined reference to `input_allocate_polled_device' peaq-wmi.c:(.init.text+0x18e): undefined reference to `input_register_polled_device' For some reason, all other drivers that need this use 'select' here rather than 'depends on', so I'm doing the same. Fixes: 13bb0fd5519d ("platform/x86: peaq-wmi: Add new peaq-wmi driver") Signed-off-by: Arnd Bergmann --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 2b209f5d42ff..d9238e9ff54a 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -672,6 +672,7 @@ config PEAQ_WMI tristate "PEAQ 2-in-1 WMI hotkey driver" depends on ACPI_WMI depends on INPUT + select INPUT_POLLDEV help Say Y here if you want to support WMI-based hotkeys on PEAQ 2-in-1s.