From patchwork Sun Feb 11 21:07:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 10211543 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DF6F0602CB for ; Sun, 11 Feb 2018 21:09:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D197228800 for ; Sun, 11 Feb 2018 21:09:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C61192884C; Sun, 11 Feb 2018 21:09:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EE7D28800 for ; Sun, 11 Feb 2018 21:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932207AbeBKVHo (ORCPT ); Sun, 11 Feb 2018 16:07:44 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:38143 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173AbeBKVHm (ORCPT ); Sun, 11 Feb 2018 16:07:42 -0500 Received: by mail-lf0-f67.google.com with SMTP id g72so17904250lfg.5 for ; Sun, 11 Feb 2018 13:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=gwcn8zcWTniQGmoG9GdA5MBHk6AVpQq/eo83fgZ2GcRmjzRxTRxXK0afmYfAqNkze/ frZ3pffSKoGDpvQmkYoYSopJyRU27XqaT8v0BwC+0gKWpZ2TB5sxSvNzTIfJ34xY/NNf aWyCxEDG32wBI5B8fymXZYWfkX1NIUsHmxIEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=dA56UOUzoSS1tVFmHwTMODBjBZz/67bde1ekqAcqy1yXGRJ1L6GflggozPDHyp/08z GmWbElOMax6cOCBJRpD2oN/4ghsak0vDC3gZwLcsgobDiQMvqeb6W36z8sMz3jA9L7WE O99oA3Nj/QeKlWRBRylE8+AY+RfAKFwwVk5noTe31to6Ai63m3yf4X0Egfnx/+Esj/x0 2JR8CSPCgZkXyiRNKCn7gr2nWFlfJVp+yWUUt2Gbc9By1hi3S5AqaFKxcnKaVVzWirLq 4uq4lTXwD2/4cvTyFdGxizE0+puPdp/xXZ9kXsCiRbD3irL1p8I5fdN9zsGJBGAuAIKF e6mg== X-Gm-Message-State: APf1xPBQcjg++qhYpF3AOEv0Tc7Cd8YVl4zbRUGbtIrA99HphrX2WIua NmgVMeEPCl9v3seR5PCJCW/CKA== X-Google-Smtp-Source: AH8x2258A18KbJO+ykK39fJjLNO+wq2Q0+25/bFcyLRBOxk3XOs3NET9R/kL8aBOkrjaZN3R5/FoFQ== X-Received: by 10.25.77.212 with SMTP id a203mr6241733lfb.14.1518383261447; Sun, 11 Feb 2018 13:07:41 -0800 (PST) Received: from kmp-mobile.hq.kempniu.pl (kmp-mobile.hq.kempniu.pl. [2001:470:64df:111::1b01]) by smtp.googlemail.com with ESMTPSA id y198sm1390477lfd.62.2018.02.11.13.07.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Feb 2018 13:07:40 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] platform/x86: fujitsu-laptop: Clearly distinguish module parameters Date: Sun, 11 Feb 2018 22:07:24 +0100 Message-Id: <20180211210727.12130-5-kernel@kempniu.pl> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180211210727.12130-1-kernel@kempniu.pl> References: <20180211210727.12130-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In order to improve code clarity, move declarations of variables that are module parameters higher up and add a comment. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 94ff7f86fa8f..7888b779d6c5 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -112,6 +112,10 @@ #define MAX_HOTKEY_RINGBUFFER_SIZE 100 #define RINGBUFFERSIZE 40 +/* Module parameters */ +static int use_alt_lcd_levels = -1; +static bool disable_brightness_adjust; + /* Device controlling the backlight and associated keys */ struct fujitsu_bl { struct input_dev *input; @@ -122,8 +126,6 @@ struct fujitsu_bl { }; static struct fujitsu_bl *fujitsu_bl; -static int use_alt_lcd_levels = -1; -static bool disable_brightness_adjust; /* Device used to access hotkeys and other features on the laptop */ struct fujitsu_laptop {