From patchwork Tue Feb 20 05:24:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= X-Patchwork-Id: 10229423 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 081E8602DC for ; Tue, 20 Feb 2018 05:26:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDE2B26E97 for ; Tue, 20 Feb 2018 05:26:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E26D6283A5; Tue, 20 Feb 2018 05:26:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A26F26E97 for ; Tue, 20 Feb 2018 05:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750737AbeBTF0P (ORCPT ); Tue, 20 Feb 2018 00:26:15 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:40049 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbeBTFZG (ORCPT ); Tue, 20 Feb 2018 00:25:06 -0500 Received: by mail-lf0-f66.google.com with SMTP id 37so2441779lfs.7 for ; Mon, 19 Feb 2018 21:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=YtQvKZ8eSy3xw2+sJCukwcs/vAOul4FHo4pbYlUEveiNDY0Xy5+xkLfYK3rq1nxoI/ /znGYU8TYC6r7U7sTntw7RIcvFYIamx8dHPJA/lbW/Niy72xOXbn4G4q2xAe0qFuBhMy yCiW9rskfjrf9ZPT3SO4G6fYyHFNwFunklhI8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=mJmEuDH6XRQRJjEG1WJZyS+F2R2BOq+8G4qjVWp3k1IQRmlPIha5KPW28rUbSu+1Js PTbNl9EPMupaJMsmDBJgs+SWRDgY+B765uveD90NTWmgCYqUm/z0RRbdTIVfSqlWdOLn uLVtEYpj4N/gzZKmnt8Yl6a3Sza7P8CMZ+L+uBNJUH3DnJWx4F5+WV5p4gIFkgEwgYF+ UFxAVGlU3NXa96iAQpwcbAff9DBwGaFsJ+sqOi2e/sDKMSflQyCboe1q8G5TrapPXw1/ qIDj71EhCFla3HgWoEbf+ALkFX9HPG9AFgnw5qmI4VIba1hFnkBuEtlFGpz+U8hmwXjh BC7A== X-Gm-Message-State: APf1xPBmayq4pVnyZ+L3lYLXHYMzmymJiowlRneKoSl1TNHp26xSPF0y D5Zv7Swlm/wNxG7X2qbzVJ/6Rg== X-Google-Smtp-Source: AH8x224ohi5iPNGxO83guqWz4BrLyS3gNgf9CycR9u4xK8eIgKMtfLW6+/YdS+E6O2luOFwkfkZHhQ== X-Received: by 10.46.12.73 with SMTP id o9mr2447283ljd.68.1519104305473; Mon, 19 Feb 2018 21:25:05 -0800 (PST) Received: from kmp-mobile.hq.kempniu.pl (kmp-mobile.hq.kempniu.pl. [2001:470:64df:111::1b01]) by smtp.googlemail.com with ESMTPSA id b27sm3978286ljb.84.2018.02.19.21.25.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2018 21:25:04 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/7] platform/x86: fujitsu-laptop: Clearly distinguish module parameters Date: Tue, 20 Feb 2018 06:24:51 +0100 Message-Id: <20180220052454.11134-5-kernel@kempniu.pl> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180220052454.11134-1-kernel@kempniu.pl> References: <20180220052454.11134-1-kernel@kempniu.pl> MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In order to improve code clarity, move declarations of variables that are module parameters higher up and add a comment. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 94ff7f86fa8f..7888b779d6c5 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -112,6 +112,10 @@ #define MAX_HOTKEY_RINGBUFFER_SIZE 100 #define RINGBUFFERSIZE 40 +/* Module parameters */ +static int use_alt_lcd_levels = -1; +static bool disable_brightness_adjust; + /* Device controlling the backlight and associated keys */ struct fujitsu_bl { struct input_dev *input; @@ -122,8 +126,6 @@ struct fujitsu_bl { }; static struct fujitsu_bl *fujitsu_bl; -static int use_alt_lcd_levels = -1; -static bool disable_brightness_adjust; /* Device used to access hotkeys and other features on the laptop */ struct fujitsu_laptop {