| Message ID | 20190304201930.1622839-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
| Series | [1/3] x86: apuv2: remove unused variable | expand |
On 04.03.19 21:19, Arnd Bergmann wrote: > diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c > index dcb084f6b892..c1ca931e1fab 100644 > --- a/drivers/platform/x86/pcengines-apuv2.c > +++ b/drivers/platform/x86/pcengines-apuv2.c > @@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev( > > static int __init apu_board_init(void) > { > - int rc; > const struct dmi_system_id *id; > > id = dmi_first_match(apu_gpio_dmi_table); > ACK. Reviewed-By: Enrico Weigelt, metux IT consult <info@metux.net> thx --mtx
On Tue, Mar 5, 2019 at 2:04 AM Enrico Weigelt, metux IT consult <lkml@metux.net> wrote: > > On 04.03.19 21:19, Arnd Bergmann wrote: > > > diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c > > index dcb084f6b892..c1ca931e1fab 100644 > > --- a/drivers/platform/x86/pcengines-apuv2.c > > +++ b/drivers/platform/x86/pcengines-apuv2.c > > @@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev( > > > > static int __init apu_board_init(void) > > { > > - int rc; > > const struct dmi_system_id *id; > > > > id = dmi_first_match(apu_gpio_dmi_table); > > > > ACK. > > Reviewed-By: Enrico Weigelt, metux IT consult <info@metux.net> Patches from here presumably should go to v5.1-rc1 or, if Linus would do it, through his tree. Linus, I'm fine with what Randy and Arnd sent for fixing this driver. > > > thx > --mtx > > -- > Enrico Weigelt, metux IT consult > Free software and Linux embedded engineering > info@metux.net -- +49-151-27565287
diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c index dcb084f6b892..c1ca931e1fab 100644 --- a/drivers/platform/x86/pcengines-apuv2.c +++ b/drivers/platform/x86/pcengines-apuv2.c @@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev( static int __init apu_board_init(void) { - int rc; const struct dmi_system_id *id; id = dmi_first_match(apu_gpio_dmi_table);
The driver was newly introduced but the version that got merged produces a harmless compiler warning: drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init': drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable] Remove the evidently useless variable. Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/x86/pcengines-apuv2.c | 1 - 1 file changed, 1 deletion(-)