From patchwork Thu Aug 27 18:58:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11741347 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0BEF9739 for ; Thu, 27 Aug 2020 18:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5C172087E for ; Thu, 27 Aug 2020 18:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598554776; bh=Dqxv1PukEgIMN3bm5Lm6sGdSDukCKcjdzgy7iM6VbfY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PbGBrRAofcU+O5Bm/tT/LJ9N38WHe0WeUg5Ez2VBFS4ArVXPeNzet/vbWkUootBFO v6eLcD9YvuyvMODJY2jQTLv0cKbJ4UkHW4l/L9MCUEMwh2nRO0LnplJHp29gr/5Cye B+nZ7m0IH2u3rdAYi1/GZzH7lBcNv12fIE+pKH+w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728109AbgH0S7f (ORCPT ); Thu, 27 Aug 2020 14:59:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:49860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728122AbgH0S7c (ORCPT ); Thu, 27 Aug 2020 14:59:32 -0400 Received: from localhost.localdomain (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 610BC2087E; Thu, 27 Aug 2020 18:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598554772; bh=Dqxv1PukEgIMN3bm5Lm6sGdSDukCKcjdzgy7iM6VbfY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Liu8obZvNyBblM0iUyAt5drhqfZgaCB4+6wJWN+DwRYCnf7Mgmr8uAX19RUbFmArt ZOlo+IE3uAMOWUg8j4FVbgGc46w4mW/NEQS6O6UywtK/OzlsQpdOKaQGSJOfX40rfA /lDwnnd0Aw22mLJ8EzJDPcdL8QmRChehhgqrVK/o= From: Krzysztof Kozlowski To: Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Hans de Goede , Bastien Nocera , Sangwon Jee , Eugen Hristev , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Krzysztof Kozlowski Subject: [PATCH v3 15/27] Input: melfas_mip4 - Simplify with dev_err_probe() Date: Thu, 27 Aug 2020 20:58:17 +0200 Message-Id: <20200827185829.30096-16-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200827185829.30096-1-krzk@kernel.org> References: <20200827185829.30096-1-krzk@kernel.org> Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko --- drivers/input/touchscreen/melfas_mip4.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index f67efdd040b2..d43a8643adcd 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -1451,13 +1451,8 @@ static int mip4_probe(struct i2c_client *client, const struct i2c_device_id *id) ts->gpio_ce = devm_gpiod_get_optional(&client->dev, "ce", GPIOD_OUT_LOW); - if (IS_ERR(ts->gpio_ce)) { - error = PTR_ERR(ts->gpio_ce); - if (error != EPROBE_DEFER) - dev_err(&client->dev, - "Failed to get gpio: %d\n", error); - return error; - } + if (IS_ERR(ts->gpio_ce)) + return dev_err_probe(&client->dev, PTR_ERR(ts->gpio_ce), "Failed to get gpio\n"); error = mip4_power_on(ts); if (error)