From patchwork Thu Aug 27 18:58:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11741319 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A1AB014E5 for ; Thu, 27 Aug 2020 18:58:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8688A2087E for ; Thu, 27 Aug 2020 18:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598554730; bh=DFt+pEv7wsjkuWkpKqMAjj60zynK5r22glOth/UG58o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1fxYWgz5t9WSExdVXYAYQAz4RmlqWHVib0SEu5Jp7AD5K5gwRzXGR/C+6xNnrnmpg fCGBdN8kX4i9Xc35vKcCXdUL8xP5liAf8gbBt0bo1KQEYYbpV3L+4gqZPd1SbNfwBe KrVuggYIMvPxI9SyXSsLH5pE47O70wE1NWb0D63M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbgH0S6r (ORCPT ); Thu, 27 Aug 2020 14:58:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:48614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbgH0S6p (ORCPT ); Thu, 27 Aug 2020 14:58:45 -0400 Received: from localhost.localdomain (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98B1F22BEB; Thu, 27 Aug 2020 18:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598554725; bh=DFt+pEv7wsjkuWkpKqMAjj60zynK5r22glOth/UG58o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q7NQXndYVEf21OUJMIWGJosO1HQHp57eYV358IHleMQtft7IQmm0lNOD0JLGpwtLj 01m5PDS800ywbm9G7BAtnYgr6uKzE/iL3SM/Ftinbj6j2shfqv5PUCnIcYveT9Smou Akz5qZiYMD7jGoSMq5CnFYdkErD0qAl/ArPhMlmM= From: Krzysztof Kozlowski To: Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Hans de Goede , Bastien Nocera , Sangwon Jee , Eugen Hristev , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Krzysztof Kozlowski Subject: [PATCH v3 01/27] Input: gpio_keys_polled - Simplify with dev_err_probe() Date: Thu, 27 Aug 2020 20:58:03 +0200 Message-Id: <20200827185829.30096-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200827185829.30096-1-krzk@kernel.org> References: <20200827185829.30096-1-krzk@kernel.org> Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko --- drivers/input/keyboard/gpio_keys_polled.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c index c3937d2fc744..ba00ecfbd343 100644 --- a/drivers/input/keyboard/gpio_keys_polled.c +++ b/drivers/input/keyboard/gpio_keys_polled.c @@ -299,13 +299,9 @@ static int gpio_keys_polled_probe(struct platform_device *pdev) NULL, GPIOD_IN, button->desc); if (IS_ERR(bdata->gpiod)) { - error = PTR_ERR(bdata->gpiod); - if (error != -EPROBE_DEFER) - dev_err(dev, - "failed to get gpio: %d\n", - error); fwnode_handle_put(child); - return error; + return dev_err_probe(dev, PTR_ERR(bdata->gpiod), + "failed to get gpio\n"); } } else if (gpio_is_valid(button->gpio)) { /*