From patchwork Thu Aug 27 18:58:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11741419 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 444561731 for ; Thu, 27 Aug 2020 19:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 210862087C for ; Thu, 27 Aug 2020 19:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598554849; bh=L/neO1101gcKrTCP6+XWg4JDM1kHZtdbRdGwRIgyRB4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wNIqBKa283Klo86q7ner8nnT5gHz069NDe8ZwLzLrkox0kw1bXLiXFO9LHAaiGfPS D924ZB4kM4qAii1oMTBivle76YdTM2BCzYm5Do/XZ/XX+HCdM5QnO1fGQurOkuMAZ0 RTO/hiRE/M3c7EA3+fx4RZSlxZU/0z4MdCwTjGFE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727954AbgH0S7F (ORCPT ); Thu, 27 Aug 2020 14:59:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:49104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727943AbgH0S7C (ORCPT ); Thu, 27 Aug 2020 14:59:02 -0400 Received: from localhost.localdomain (unknown [194.230.155.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3524F22BEB; Thu, 27 Aug 2020 18:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598554742; bh=L/neO1101gcKrTCP6+XWg4JDM1kHZtdbRdGwRIgyRB4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C6X4r80zTaSo+/cmTuk5oJTGt1uKasZWDSQkci9sL1XJ492hbiTO5Osn0VCVsIZUQ HdeFVon6g6fvNue6poeqI/erUiZtcHaGevaIzzcnoLzdiaGtks4dJUVSJ0UThkjAi5 E1QGxCEPZ2l8t14ay+a7AI1fJV65SP7PIVLVgIWA= From: Krzysztof Kozlowski To: Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Hans de Goede , Bastien Nocera , Sangwon Jee , Eugen Hristev , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, clang-built-linux@googlegroups.com Cc: Krzysztof Kozlowski Subject: [PATCH v3 06/27] Input: elan_i2c - Simplify with dev_err_probe() Date: Thu, 27 Aug 2020 20:58:08 +0200 Message-Id: <20200827185829.30096-7-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200827185829.30096-1-krzk@kernel.org> References: <20200827185829.30096-1-krzk@kernel.org> Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko --- drivers/input/mouse/elan_i2c_core.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index c599e21a8478..d703b0d5a3bd 100644 --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i2c_core.c @@ -1229,13 +1229,8 @@ static int elan_probe(struct i2c_client *client, mutex_init(&data->sysfs_mutex); data->vcc = devm_regulator_get(dev, "vcc"); - if (IS_ERR(data->vcc)) { - error = PTR_ERR(data->vcc); - if (error != -EPROBE_DEFER) - dev_err(dev, "Failed to get 'vcc' regulator: %d\n", - error); - return error; - } + if (IS_ERR(data->vcc)) + return dev_err_probe(dev, PTR_ERR(data->vcc), "Failed to get 'vcc' regulator\n"); error = regulator_enable(data->vcc); if (error) {