diff mbox series

efi: x86: make kobj_type structure constant

Message ID 20230227-kobj_type-x86-efi-v1-1-a335952d2536@weissschuh.net (mailing list archive)
State Deferred, archived
Headers show
Series efi: x86: make kobj_type structure constant | expand

Commit Message

Thomas Weißschuh Feb. 27, 2023, 3:09 a.m. UTC 
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 arch/x86/platform/efi/runtime-map.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
change-id: 20230227-kobj_type-x86-efi-7591b1343b08

Best regards,

Comments

Ard Biesheuvel Feb. 27, 2023, 4:34 p.m. UTC | #1 
On Mon, 27 Feb 2023 at 04:09, Thomas Weißschuh <linux@weissschuh.net> wrote:
>
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Thanks, I'll queue these up after the merge window.

> ---
>  arch/x86/platform/efi/runtime-map.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/efi/runtime-map.c b/arch/x86/platform/efi/runtime-map.c
> index bbee682ef8cd..a6f02cef3ca2 100644
> --- a/arch/x86/platform/efi/runtime-map.c
> +++ b/arch/x86/platform/efi/runtime-map.c
> @@ -93,7 +93,7 @@ static void map_release(struct kobject *kobj)
>         kfree(entry);
>  }
>
> -static struct kobj_type __refdata map_ktype = {
> +static const struct kobj_type __refconst map_ktype = {
>         .sysfs_ops      = &map_attr_ops,
>         .default_groups = def_groups,
>         .release        = map_release,
>
> ---
> base-commit: 2fcd07b7ccd5fd10b2120d298363e4e6c53ccf9c
> change-id: 20230227-kobj_type-x86-efi-7591b1343b08
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
diff mbox series

Patch

diff --git a/arch/x86/platform/efi/runtime-map.c b/arch/x86/platform/efi/runtime-map.c
index bbee682ef8cd..a6f02cef3ca2 100644
--- a/arch/x86/platform/efi/runtime-map.c
+++ b/arch/x86/platform/efi/runtime-map.c
@@ -93,7 +93,7 @@  static void map_release(struct kobject *kobj)
 	kfree(entry);
 }
 
-static struct kobj_type __refdata map_ktype = {
+static const struct kobj_type __refconst map_ktype = {
 	.sysfs_ops	= &map_attr_ops,
 	.default_groups	= def_groups,
 	.release	= map_release,