| Message ID | 20230505132523.214338-1-mpearson-lenovo@squebb.ca (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] platform/x86: thinkpad_acpi: Fix platform profiles on T490 | expand |
Hi, On 5/5/23 15:25, Mark Pearson wrote: > I had incorrectly thought that PSC profiles were not usable on Intel > platforms so had blocked them in the driver initialistion. This broke > platform profiles on the T490. > > After discussion with the FW team PSC does work on Intel platforms and > should be allowed. > > Note - it's possible this may impact other platforms where it is advertised > but special driver support that only Windows has is needed. But if it does > then they will need fixing via quirks. Please report any issues to me so I > can get them addressed - but I haven't found any problems in testing...yet > > Fixes: bce6243f767f ("platform/x86: thinkpad_acpi: do not use PSC mode on Intel platforms") > Link: https://bugzilla.redhat.com/show_bug.cgi?id=2177962 > Cc: stable@vger.kernel.org > Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca> Thank you for your patch series, I've applied this series to my fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Note it will show up in my fixes branch once I've pushed my local branch there, which might take a while. I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/thinkpad_acpi.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index 826c522ed1c0..d84a4c7e3c35 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -10585,11 +10585,6 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm) > dytc_mmc_get_available = true; > } > } else if (dytc_capabilities & BIT(DYTC_FC_PSC)) { /* PSC MODE */ > - /* Support for this only works on AMD platforms */ > - if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD) { > - dbg_printk(TPACPI_DBG_INIT, "PSC not support on Intel platforms\n"); > - return -ENODEV; > - } > pr_debug("PSC is supported\n"); > } else { > dbg_printk(TPACPI_DBG_INIT, "No DYTC support available\n");
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 826c522ed1c0..d84a4c7e3c35 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -10585,11 +10585,6 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm) dytc_mmc_get_available = true; } } else if (dytc_capabilities & BIT(DYTC_FC_PSC)) { /* PSC MODE */ - /* Support for this only works on AMD platforms */ - if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD) { - dbg_printk(TPACPI_DBG_INIT, "PSC not support on Intel platforms\n"); - return -ENODEV; - } pr_debug("PSC is supported\n"); } else { dbg_printk(TPACPI_DBG_INIT, "No DYTC support available\n");
I had incorrectly thought that PSC profiles were not usable on Intel platforms so had blocked them in the driver initialistion. This broke platform profiles on the T490. After discussion with the FW team PSC does work on Intel platforms and should be allowed. Note - it's possible this may impact other platforms where it is advertised but special driver support that only Windows has is needed. But if it does then they will need fixing via quirks. Please report any issues to me so I can get them addressed - but I haven't found any problems in testing...yet Fixes: bce6243f767f ("platform/x86: thinkpad_acpi: do not use PSC mode on Intel platforms") Link: https://bugzilla.redhat.com/show_bug.cgi?id=2177962 Cc: stable@vger.kernel.org Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca> --- drivers/platform/x86/thinkpad_acpi.c | 5 ----- 1 file changed, 5 deletions(-)