diff mbox series

platform/x86: lenovo-yogabook: add I2C dependency

Message ID 20230519082606.375471-1-arnd@kernel.org (mailing list archive)
State Accepted, archived
Headers show
Series platform/x86: lenovo-yogabook: add I2C dependency | expand

Commit Message

Arnd Bergmann May 19, 2023, 8:25 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The added platform_driver support fails to link when I2C core support is
not rechable:

x86_64-linux-ld: drivers/platform/x86/lenovo-yogabook.o: in function `yogabook_pdev_probe':
lenovo-yogabook.c:(.text+0x5a5): undefined reference to `i2c_bus_type'

Add a Kconfig dependency to enforce a working configuration.

Fixes: 6df1523fa0b7 ("platform/x86: lenovo-yogabook: Add platform driver support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Hans de Goede May 23, 2023, 11:09 a.m. UTC | #1 
Hi Arnd,

On 5/19/23 10:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The added platform_driver support fails to link when I2C core support is
> not rechable:
> 
> x86_64-linux-ld: drivers/platform/x86/lenovo-yogabook.o: in function `yogabook_pdev_probe':
> lenovo-yogabook.c:(.text+0x5a5): undefined reference to `i2c_bus_type'
> 
> Add a Kconfig dependency to enforce a working configuration.
> 
> Fixes: 6df1523fa0b7 ("platform/x86: lenovo-yogabook: Add platform driver support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thank you I have pushed this to pdx86/for-next now.

Regards,

Hans



> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9fe974d5f645..63637ea99c2f 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -125,6 +125,7 @@ config YOGABOOK
>  	tristate "Lenovo Yoga Book tablet key driver"
>  	depends on ACPI_WMI
>  	depends on INPUT
> +	depends on I2C
>  	select LEDS_CLASS
>  	select NEW_LEDS
>  	help
diff mbox series

Patch

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9fe974d5f645..63637ea99c2f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -125,6 +125,7 @@  config YOGABOOK
 	tristate "Lenovo Yoga Book tablet key driver"
 	depends on ACPI_WMI
 	depends on INPUT
+	depends on I2C
 	select LEDS_CLASS
 	select NEW_LEDS
 	help