| Message ID | 20230811131330.71263-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v1,1/1] platform/x86/amd/pmf: Use str_on_off() helper | expand |
On Fri, 11 Aug 2023, Andy Shevchenko wrote: > We have a common helper to represent a boolean value as "on"/"off" > string. Use it for the sake of the unified style. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/platform/x86/amd/pmf/cnqf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/amd/pmf/cnqf.c b/drivers/platform/x86/amd/pmf/cnqf.c > index 539b186e9027..bc8899e15c91 100644 > --- a/drivers/platform/x86/amd/pmf/cnqf.c > +++ b/drivers/platform/x86/amd/pmf/cnqf.c > @@ -8,6 +8,7 @@ > * Author: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > */ > > +#include <linux/string_choices.h> > #include <linux/workqueue.h> > #include "pmf.h" > > @@ -399,7 +400,7 @@ static ssize_t cnqf_enable_store(struct device *dev, > amd_pmf_set_sps_power_limits(pdev); > } > > - dev_dbg(pdev->dev, "Received CnQF %s\n", input ? "on" : "off"); > + dev_dbg(pdev->dev, "Received CnQF %s\n", str_on_off(input)); > return count; > } > > @@ -409,7 +410,7 @@ static ssize_t cnqf_enable_show(struct device *dev, > { > struct amd_pmf_dev *pdev = dev_get_drvdata(dev); > > - return sysfs_emit(buf, "%s\n", pdev->cnqf_enabled ? "on" : "off"); > + return sysfs_emit(buf, "%s\n", str_on_off(pdev->cnqf_enabled)); > } > > static DEVICE_ATTR_RW(cnqf_enable); > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
On 8/11/23 6:13 PM, Andy Shevchenko wrote: > We have a common helper to represent a boolean value as "on"/"off" > string. Use it for the sake of the unified style. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > drivers/platform/x86/amd/pmf/cnqf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/amd/pmf/cnqf.c b/drivers/platform/x86/amd/pmf/cnqf.c > index 539b186e9027..bc8899e15c91 100644 > --- a/drivers/platform/x86/amd/pmf/cnqf.c > +++ b/drivers/platform/x86/amd/pmf/cnqf.c > @@ -8,6 +8,7 @@ > * Author: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > */ > > +#include <linux/string_choices.h> > #include <linux/workqueue.h> > #include "pmf.h" > > @@ -399,7 +400,7 @@ static ssize_t cnqf_enable_store(struct device *dev, > amd_pmf_set_sps_power_limits(pdev); > } > > - dev_dbg(pdev->dev, "Received CnQF %s\n", input ? "on" : "off"); > + dev_dbg(pdev->dev, "Received CnQF %s\n", str_on_off(input)); > return count; > } > > @@ -409,7 +410,7 @@ static ssize_t cnqf_enable_show(struct device *dev, > { > struct amd_pmf_dev *pdev = dev_get_drvdata(dev); > > - return sysfs_emit(buf, "%s\n", pdev->cnqf_enabled ? "on" : "off"); > + return sysfs_emit(buf, "%s\n", str_on_off(pdev->cnqf_enabled)); > } > > static DEVICE_ATTR_RW(cnqf_enable);
Hi, On 8/11/23 15:13, Andy Shevchenko wrote: > We have a common helper to represent a boolean value as "on"/"off" > string. Use it for the sake of the unified style. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/amd/pmf/cnqf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/amd/pmf/cnqf.c b/drivers/platform/x86/amd/pmf/cnqf.c > index 539b186e9027..bc8899e15c91 100644 > --- a/drivers/platform/x86/amd/pmf/cnqf.c > +++ b/drivers/platform/x86/amd/pmf/cnqf.c > @@ -8,6 +8,7 @@ > * Author: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> > */ > > +#include <linux/string_choices.h> > #include <linux/workqueue.h> > #include "pmf.h" > > @@ -399,7 +400,7 @@ static ssize_t cnqf_enable_store(struct device *dev, > amd_pmf_set_sps_power_limits(pdev); > } > > - dev_dbg(pdev->dev, "Received CnQF %s\n", input ? "on" : "off"); > + dev_dbg(pdev->dev, "Received CnQF %s\n", str_on_off(input)); > return count; > } > > @@ -409,7 +410,7 @@ static ssize_t cnqf_enable_show(struct device *dev, > { > struct amd_pmf_dev *pdev = dev_get_drvdata(dev); > > - return sysfs_emit(buf, "%s\n", pdev->cnqf_enabled ? "on" : "off"); > + return sysfs_emit(buf, "%s\n", str_on_off(pdev->cnqf_enabled)); > } > > static DEVICE_ATTR_RW(cnqf_enable);
diff --git a/drivers/platform/x86/amd/pmf/cnqf.c b/drivers/platform/x86/amd/pmf/cnqf.c index 539b186e9027..bc8899e15c91 100644 --- a/drivers/platform/x86/amd/pmf/cnqf.c +++ b/drivers/platform/x86/amd/pmf/cnqf.c @@ -8,6 +8,7 @@ * Author: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> */ +#include <linux/string_choices.h> #include <linux/workqueue.h> #include "pmf.h" @@ -399,7 +400,7 @@ static ssize_t cnqf_enable_store(struct device *dev, amd_pmf_set_sps_power_limits(pdev); } - dev_dbg(pdev->dev, "Received CnQF %s\n", input ? "on" : "off"); + dev_dbg(pdev->dev, "Received CnQF %s\n", str_on_off(input)); return count; } @@ -409,7 +410,7 @@ static ssize_t cnqf_enable_show(struct device *dev, { struct amd_pmf_dev *pdev = dev_get_drvdata(dev); - return sysfs_emit(buf, "%s\n", pdev->cnqf_enabled ? "on" : "off"); + return sysfs_emit(buf, "%s\n", str_on_off(pdev->cnqf_enabled)); } static DEVICE_ATTR_RW(cnqf_enable);
We have a common helper to represent a boolean value as "on"/"off" string. Use it for the sake of the unified style. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/platform/x86/amd/pmf/cnqf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)