diff mbox series

[platform-next,07/16] platform: mellanox: mlx-platform: Modify power off callback

Message ID 20230814085910.56069-8-vadimp@nvidia.com (mailing list archive)
State Superseded, archived
Headers show
Series Add new features and amendments for Nvidia systems | expand

Commit Message

Vadim Pasternak Aug. 14, 2023, 8:59 a.m. UTC 
Extend platform power off callback with kernel_halt() call.

Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Reviewed-by: Michael Shych <michaelsh@nvidia.com>
---
 drivers/platform/x86/mlx-platform.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ilpo Järvinen Aug. 14, 2023, 1:43 p.m. UTC | #1 
On Mon, 14 Aug 2023, Vadim Pasternak wrote:

> Extend platform power off callback with kernel_halt() call.

That much is obvious from the code change itself but please amend this 
changelog with the answer to question "Why?" you're making this change.
diff mbox series

Patch

diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index dce35934cc37..a505f619f337 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -5539,6 +5539,7 @@  static void mlxplat_poweroff(void)
 	struct mlxplat_priv *priv = platform_get_drvdata(mlxplat_dev);
 
 	regmap_write(priv->regmap, MLXPLAT_CPLD_LPC_REG_GP1_OFFSET, MLXPLAT_CPLD_HALT_MASK);
+	kernel_halt();
 }
 
 static int __init mlxplat_dmi_default_matched(const struct dmi_system_id *dmi)