| Message ID | 20230823075038.7129-1-vadimp@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [platform-next,1/1] platform/x86: mlx-platform: Fix 0-DAY CI warning | expand |
Hi, On 8/23/23 09:50, Vadim Pasternak wrote: > Fix 0-DAY CI warning: unused variable 'mlxplat_acpi_table'. > > Add dependency on "ACPI" to Kconfig file. > Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'. > > Fixes: e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202308231011.pa9xg8sF-lkp@intel.com/ > Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/Kconfig | 1 + > drivers/platform/x86/mlx-platform.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 06b9a5ae5a63..a43db6731f34 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE > > config MLX_PLATFORM > tristate "Mellanox Technologies platform support" > + depends on ACPI > depends on I2C > select REGMAP > help > diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c > index 44f107965832..3d96dbf79a72 100644 > --- a/drivers/platform/x86/mlx-platform.c > +++ b/drivers/platform/x86/mlx-platform.c > @@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table); > static struct platform_driver mlxplat_driver = { > .driver = { > .name = "mlxplat", > - .acpi_match_table = ACPI_PTR(mlxplat_acpi_table), > + .acpi_match_table = mlxplat_acpi_table, > .probe_type = PROBE_FORCE_SYNCHRONOUS, > }, > .probe = mlxplat_probe,
Hi, On 8/23/23 13:13, Hans de Goede wrote: > Hi, > > On 8/23/23 09:50, Vadim Pasternak wrote: >> Fix 0-DAY CI warning: unused variable 'mlxplat_acpi_table'. >> >> Add dependency on "ACPI" to Kconfig file. >> Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'. >> >> Fixes: e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow") >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: https://lore.kernel.org/oe-kbuild-all/202308231011.pa9xg8sF-lkp@intel.com/ >> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> > > Thank you for your patch, I've applied this patch to my review-hans > branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > Once I've run some tests on this branch the patches there will be > added to the platform-drivers-x86/for-next branch and eventually > will be included in the pdx86 pull-request to Linus for the next > merge-window. Note I have to do a forced push to my review-hans branch due to an author vs s-o-b mismatch which I missed earlier. As part of that I'm going to squash this fix into the original e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow") commit. Regards, Hans >> --- >> drivers/platform/x86/Kconfig | 1 + >> drivers/platform/x86/mlx-platform.c | 2 +- >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >> index 06b9a5ae5a63..a43db6731f34 100644 >> --- a/drivers/platform/x86/Kconfig >> +++ b/drivers/platform/x86/Kconfig >> @@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE >> >> config MLX_PLATFORM >> tristate "Mellanox Technologies platform support" >> + depends on ACPI >> depends on I2C >> select REGMAP >> help >> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c >> index 44f107965832..3d96dbf79a72 100644 >> --- a/drivers/platform/x86/mlx-platform.c >> +++ b/drivers/platform/x86/mlx-platform.c >> @@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table); >> static struct platform_driver mlxplat_driver = { >> .driver = { >> .name = "mlxplat", >> - .acpi_match_table = ACPI_PTR(mlxplat_acpi_table), >> + .acpi_match_table = mlxplat_acpi_table, >> .probe_type = PROBE_FORCE_SYNCHRONOUS, >> }, >> .probe = mlxplat_probe, >
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 06b9a5ae5a63..a43db6731f34 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE config MLX_PLATFORM tristate "Mellanox Technologies platform support" + depends on ACPI depends on I2C select REGMAP help diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c index 44f107965832..3d96dbf79a72 100644 --- a/drivers/platform/x86/mlx-platform.c +++ b/drivers/platform/x86/mlx-platform.c @@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table); static struct platform_driver mlxplat_driver = { .driver = { .name = "mlxplat", - .acpi_match_table = ACPI_PTR(mlxplat_acpi_table), + .acpi_match_table = mlxplat_acpi_table, .probe_type = PROBE_FORCE_SYNCHRONOUS, }, .probe = mlxplat_probe,
Fix 0-DAY CI warning: unused variable 'mlxplat_acpi_table'. Add dependency on "ACPI" to Kconfig file. Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'. Fixes: e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202308231011.pa9xg8sF-lkp@intel.com/ Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> --- drivers/platform/x86/Kconfig | 1 + drivers/platform/x86/mlx-platform.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)