| Message ID | 20240201010747.471141-2-david.e.box@linux.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Intel On Demand: Add netlink interface for SPDM attestation | expand |
On 1/31/24 5:07 PM, David E. Box wrote: > New mailbox commands will support sending multi packet writes and updated > firmware now requires that the message size be written for all commands Can you include some spec reference to new mailbox commands? What about updated firmware mean? Like a particular version? > along with the packet size. Since the driver doesn't perform writes larger > than the packet size, set the message size to the same value. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- > drivers/platform/x86/intel/sdsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c > index 556e7c6dbb05..a70c071de6e2 100644 > --- a/drivers/platform/x86/intel/sdsi.c > +++ b/drivers/platform/x86/intel/sdsi.c > @@ -252,6 +252,7 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv, struct sdsi_mbox_info *in > FIELD_PREP(CTRL_SOM, 1) | > FIELD_PREP(CTRL_RUN_BUSY, 1) | > FIELD_PREP(CTRL_READ_WRITE, 1) | > + FIELD_PREP(CTRL_MSG_SIZE, info->size) | > FIELD_PREP(CTRL_PACKET_SIZE, info->size); > writeq(control, priv->control_addr); >
On Wed, 31 Jan 2024, David E. Box wrote: > New mailbox commands will support sending multi packet writes and updated > firmware now requires that the message size be written for all commands > along with the packet size. Since the driver doesn't perform writes larger > than the packet size, set the message size to the same value. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- > drivers/platform/x86/intel/sdsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c > index 556e7c6dbb05..a70c071de6e2 100644 > --- a/drivers/platform/x86/intel/sdsi.c > +++ b/drivers/platform/x86/intel/sdsi.c > @@ -252,6 +252,7 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv, struct sdsi_mbox_info *in > FIELD_PREP(CTRL_SOM, 1) | > FIELD_PREP(CTRL_RUN_BUSY, 1) | > FIELD_PREP(CTRL_READ_WRITE, 1) | > + FIELD_PREP(CTRL_MSG_SIZE, info->size) | > FIELD_PREP(CTRL_PACKET_SIZE, info->size); > writeq(control, priv->control_addr); Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
On 1/31/24 5:07 PM, David E. Box wrote: > New mailbox commands will support sending multi packet writes and updated > firmware now requires that the message size be written for all commands > along with the packet size. Since the driver doesn't perform writes larger > than the packet size, set the message size to the same value. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > drivers/platform/x86/intel/sdsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c > index 556e7c6dbb05..a70c071de6e2 100644 > --- a/drivers/platform/x86/intel/sdsi.c > +++ b/drivers/platform/x86/intel/sdsi.c > @@ -252,6 +252,7 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv, struct sdsi_mbox_info *in > FIELD_PREP(CTRL_SOM, 1) | > FIELD_PREP(CTRL_RUN_BUSY, 1) | > FIELD_PREP(CTRL_READ_WRITE, 1) | > + FIELD_PREP(CTRL_MSG_SIZE, info->size) | > FIELD_PREP(CTRL_PACKET_SIZE, info->size); > writeq(control, priv->control_addr); >
diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c index 556e7c6dbb05..a70c071de6e2 100644 --- a/drivers/platform/x86/intel/sdsi.c +++ b/drivers/platform/x86/intel/sdsi.c @@ -252,6 +252,7 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv, struct sdsi_mbox_info *in FIELD_PREP(CTRL_SOM, 1) | FIELD_PREP(CTRL_RUN_BUSY, 1) | FIELD_PREP(CTRL_READ_WRITE, 1) | + FIELD_PREP(CTRL_MSG_SIZE, info->size) | FIELD_PREP(CTRL_PACKET_SIZE, info->size); writeq(control, priv->control_addr);
New mailbox commands will support sending multi packet writes and updated firmware now requires that the message size be written for all commands along with the packet size. Since the driver doesn't perform writes larger than the packet size, set the message size to the same value. Signed-off-by: David E. Box <david.e.box@linux.intel.com> --- drivers/platform/x86/intel/sdsi.c | 1 + 1 file changed, 1 insertion(+)