| Message ID | 20240416025312.731809-1-Basavaraj.Natikar@amd.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Hans de Goede |
| Headers | show |
| Series | [-next] platform/x86/amd/pmc: Fix implicit declaration error on i386 | expand |
On 4/15/24 7:53 PM, Basavaraj Natikar wrote: > Add depended header file to fix error on i386 due to implicit declaration > of function ‘writeq’. > > Fixes: 2dc77993cb5e ("platform/x86/amd/pmc: Add AMD MP2 STB functionality") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202404160320.QAHyZ0c3-lkp@intel.com/ > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> > --- LGTM Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > drivers/platform/x86/amd/pmc/mp2_stb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/pmc/mp2_stb.c b/drivers/platform/x86/amd/pmc/mp2_stb.c > index dfa55327e5f1..9775ddc1b27a 100644 > --- a/drivers/platform/x86/amd/pmc/mp2_stb.c > +++ b/drivers/platform/x86/amd/pmc/mp2_stb.c > @@ -11,6 +11,7 @@ > #include <linux/debugfs.h> > #include <linux/device.h> > #include <linux/io.h> > +#include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/iopoll.h> > #include <linux/pci.h> > #include <linux/sizes.h>
Hi, On 4/16/24 4:53 AM, Basavaraj Natikar wrote: > Add depended header file to fix error on i386 due to implicit declaration > of function ‘writeq’. > > Fixes: 2dc77993cb5e ("platform/x86/amd/pmc: Add AMD MP2 STB functionality") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202404160320.QAHyZ0c3-lkp@intel.com/ > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/amd/pmc/mp2_stb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/pmc/mp2_stb.c b/drivers/platform/x86/amd/pmc/mp2_stb.c > index dfa55327e5f1..9775ddc1b27a 100644 > --- a/drivers/platform/x86/amd/pmc/mp2_stb.c > +++ b/drivers/platform/x86/amd/pmc/mp2_stb.c > @@ -11,6 +11,7 @@ > #include <linux/debugfs.h> > #include <linux/device.h> > #include <linux/io.h> > +#include <linux/io-64-nonatomic-lo-hi.h> > #include <linux/iopoll.h> > #include <linux/pci.h> > #include <linux/sizes.h>
diff --git a/drivers/platform/x86/amd/pmc/mp2_stb.c b/drivers/platform/x86/amd/pmc/mp2_stb.c index dfa55327e5f1..9775ddc1b27a 100644 --- a/drivers/platform/x86/amd/pmc/mp2_stb.c +++ b/drivers/platform/x86/amd/pmc/mp2_stb.c @@ -11,6 +11,7 @@ #include <linux/debugfs.h> #include <linux/device.h> #include <linux/io.h> +#include <linux/io-64-nonatomic-lo-hi.h> #include <linux/iopoll.h> #include <linux/pci.h> #include <linux/sizes.h>
Add depended header file to fix error on i386 due to implicit declaration of function ‘writeq’. Fixes: 2dc77993cb5e ("platform/x86/amd/pmc: Add AMD MP2 STB functionality") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202404160320.QAHyZ0c3-lkp@intel.com/ Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> --- drivers/platform/x86/amd/pmc/mp2_stb.c | 1 + 1 file changed, 1 insertion(+)