diff mbox series

[v2] platform/x86: hp-wmi: mark 8A15 board for timed OMEN thermal profile

Message ID 20241226062207.3352629-1-jeffbai@aosc.io (mailing list archive)
State Accepted, archived
Headers show
Series [v2] platform/x86: hp-wmi: mark 8A15 board for timed OMEN thermal profile | expand

Commit Message

Mingcong Bai Dec. 26, 2024, 6:22 a.m. UTC 
The HP OMEN 8 (2022), corresponding to a board ID of 8A15, supports OMEN
thermal profile and requires the timed profile quirk.

Upon adding this ID to both the omen_thermal_profile_boards and
omen_timed_thermal_profile_boards, significant bump in performance can be
observed. For instance, SilverBench (https://silver.urih.com/) results
improved from ~56,000 to ~69,000, as a result of higher power draws (and
thus core frequencies) whilst under load:

Package Power:

- Before the patch: ~65W (dropping to about 55W under sustained load).
- After the patch: ~115W (dropping to about 105W under sustained load).

Core Power:

- Before: ~60W (ditto above).
- After: ~108W (ditto above).

Add 8A15 to omen_thermal_profile_boards and
omen_timed_thermal_profile_boards to improve performance.

Signed-off-by: Xi Xiao <1577912515@qq.com>
Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ilpo Järvinen Dec. 29, 2024, 3:43 p.m. UTC | #1 
On Thu, 26 Dec 2024 14:22:05 +0800, Mingcong Bai wrote:

> The HP OMEN 8 (2022), corresponding to a board ID of 8A15, supports OMEN
> thermal profile and requires the timed profile quirk.
> 
> Upon adding this ID to both the omen_thermal_profile_boards and
> omen_timed_thermal_profile_boards, significant bump in performance can be
> observed. For instance, SilverBench (https://silver.urih.com/) results
> improved from ~56,000 to ~69,000, as a result of higher power draws (and
> thus core frequencies) whilst under load:
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: hp-wmi: mark 8A15 board for timed OMEN thermal profile
      commit: 032fe9b0516702599c2dd990a4703f783d5716b8

--
 i.
diff mbox series

Patch

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index 81ccc96ffe40..20c55bab3b8c 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -64,7 +64,7 @@  static const char * const omen_thermal_profile_boards[] = {
 	"874A", "8603", "8604", "8748", "886B", "886C", "878A", "878B", "878C",
 	"88C8", "88CB", "8786", "8787", "8788", "88D1", "88D2", "88F4", "88FD",
 	"88F5", "88F6", "88F7", "88FE", "88FF", "8900", "8901", "8902", "8912",
-	"8917", "8918", "8949", "894A", "89EB", "8BAD", "8A42"
+	"8917", "8918", "8949", "894A", "89EB", "8BAD", "8A42", "8A15"
 };
 
 /* DMI Board names of Omen laptops that are specifically set to be thermal
@@ -80,7 +80,7 @@  static const char * const omen_thermal_profile_force_v0_boards[] = {
  * "balanced" when reaching zero.
  */
 static const char * const omen_timed_thermal_profile_boards[] = {
-	"8BAD", "8A42"
+	"8BAD", "8A42", "8A15"
 };
 
 /* DMI Board names of Victus laptops */