| Message ID | 20250214214535.4947-1-kuurtb@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: dell: Use *-y instead of *-objs in Makefile | expand |
On Fri, Feb 14, 2025 at 04:45:35PM -0500, Kurt Borja wrote: > The `objs` suffix is reserved for user-space tools. Use the `y` suffix > instead, which is usually used for kernel drivers. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks!
On Fri, 14 Feb 2025, Kurt Borja wrote: > The `objs` suffix is reserved for user-space tools. Use the `y` suffix > instead, which is usually used for kernel drivers. > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Kurt Borja <kuurtb@gmail.com> > --- > Hi all, > > I based this patch on top of the for-next branch. > > Ilpo, if you prefer this patch to be based on top of the fixes branch, > let me know. I'd submit two separate patches, one for alienware-wmi, on > top of the for-next branch and one for the other drivers, on top of > fixes. Thanks for the fix. I took this through for-next branch to not make our lives unnecessarily complicated. If there would be only handful of -objs, I might have decide otherwise but this (wrong) pattern is really widespread so removing a few drops from the ocean is not going to sound us the finish line fanfare. But it's still an important step towards the right direction, regardless. TBH, I didn't know the distinction either until Andy explained it (and like you, would have just copied the pattern if one was readily available). But I've never really deep dived into the kernel's build system anyway. I wonder why checkpatch doesn't catch it, or does it? At least there are no "objs" strings in its source.
On Mon Feb 17, 2025 at 3:58 AM -05, Ilpo Järvinen wrote: > On Fri, 14 Feb 2025, Kurt Borja wrote: > >> The `objs` suffix is reserved for user-space tools. Use the `y` suffix >> instead, which is usually used for kernel drivers. >> >> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Signed-off-by: Kurt Borja <kuurtb@gmail.com> >> --- >> Hi all, >> >> I based this patch on top of the for-next branch. >> >> Ilpo, if you prefer this patch to be based on top of the fixes branch, >> let me know. I'd submit two separate patches, one for alienware-wmi, on >> top of the for-next branch and one for the other drivers, on top of >> fixes. > > Thanks for the fix. > > I took this through for-next branch to not make our lives unnecessarily > complicated. If there would be only handful of -objs, I might have decide > otherwise but this (wrong) pattern is really widespread so removing a few > drops from the ocean is not going to sound us the finish line fanfare. But > it's still an important step towards the right direction, regardless. > > TBH, I didn't know the distinction either until Andy explained it (and > like you, would have just copied the pattern if one was readily > available). But I've never really deep dived into the kernel's build > system anyway. I will finish the job for this subsystem, so no one copies this pattern again :p > > I wonder why checkpatch doesn't catch it, or does it? At least there are > no "objs" strings in its source. It doesn't actually. Not even with --strict.
diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile index 8ac9a933c770..c7501c25e627 100644 --- a/drivers/platform/x86/dell/Makefile +++ b/drivers/platform/x86/dell/Makefile @@ -5,7 +5,7 @@ # obj-$(CONFIG_ALIENWARE_WMI) += alienware-wmi.o -alienware-wmi-objs := alienware-wmi-base.o +alienware-wmi-y := alienware-wmi-base.o alienware-wmi-$(CONFIG_ALIENWARE_WMI_LEGACY) += alienware-wmi-legacy.o alienware-wmi-$(CONFIG_ALIENWARE_WMI_WMAX) += alienware-wmi-wmax.o obj-$(CONFIG_DCDBAS) += dcdbas.o @@ -14,14 +14,14 @@ obj-$(CONFIG_DELL_RBTN) += dell-rbtn.o obj-$(CONFIG_DELL_RBU) += dell_rbu.o obj-$(CONFIG_DELL_PC) += dell-pc.o obj-$(CONFIG_DELL_SMBIOS) += dell-smbios.o -dell-smbios-objs := dell-smbios-base.o +dell-smbios-y := dell-smbios-base.o dell-smbios-$(CONFIG_DELL_SMBIOS_WMI) += dell-smbios-wmi.o dell-smbios-$(CONFIG_DELL_SMBIOS_SMM) += dell-smbios-smm.o obj-$(CONFIG_DELL_SMO8800) += dell-smo8800.o obj-$(CONFIG_DELL_SMO8800) += dell-lis3lv02d.o obj-$(CONFIG_DELL_UART_BACKLIGHT) += dell-uart-backlight.o obj-$(CONFIG_DELL_WMI) += dell-wmi.o -dell-wmi-objs := dell-wmi-base.o +dell-wmi-y := dell-wmi-base.o dell-wmi-$(CONFIG_DELL_WMI_PRIVACY) += dell-wmi-privacy.o obj-$(CONFIG_DELL_WMI_AIO) += dell-wmi-aio.o obj-$(CONFIG_DELL_WMI_DESCRIPTOR) += dell-wmi-descriptor.o
The `objs` suffix is reserved for user-space tools. Use the `y` suffix instead, which is usually used for kernel drivers. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Kurt Borja <kuurtb@gmail.com> --- Hi all, I based this patch on top of the for-next branch. Ilpo, if you prefer this patch to be based on top of the fixes branch, let me know. I'd submit two separate patches, one for alienware-wmi, on top of the for-next branch and one for the other drivers, on top of fixes. ~ Kurt drivers/platform/x86/dell/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: d497c47481f8e8f13e3191c9a707ed942d3bb3d7