From patchwork Sun Jan 3 14:54:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Lutomirski X-Patchwork-Id: 7943571 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 504E09F350 for ; Sun, 3 Jan 2016 14:54:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8CD222034C for ; Sun, 3 Jan 2016 14:54:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9812A202FE for ; Sun, 3 Jan 2016 14:54:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbcACOyw (ORCPT ); Sun, 3 Jan 2016 09:54:52 -0500 Received: from mail.kernel.org ([198.145.29.136]:35689 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751405AbcACOyv (ORCPT ); Sun, 3 Jan 2016 09:54:51 -0500 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C6DB520303; Sun, 3 Jan 2016 14:54:50 +0000 (UTC) Received: from localhost (64.sub-70-197-0.myvzw.com [70.197.0.64]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21AD5202FE; Sun, 3 Jan 2016 14:54:47 +0000 (UTC) From: Andy Lutomirski To: platform-driver-x86@vger.kernel.org Cc: Alex Hung , Darren Hart , Sedat Dilek , Andy Lutomirski Subject: [PATCH] intel-hid: Fix build failure when CONFIG_INTEL_HID_EVENT=m Date: Sun, 3 Jan 2016 06:54:36 -0800 Message-Id: <8c329ffac51276860bff1911a0f257dd108ee5e8.1451832665.git.luto@kernel.org> X-Mailer: git-send-email 2.5.0 X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sedat Dilek When building with CONFIG_INTEL_HID_EVENT=m on Andy's luto.git#xps13 Git branch I see the following build failure: ERROR: "sparse_keymap_setup" [drivers/platform/x86/intel-hid.ko] undefined! ERROR: "sparse_keymap_report_event" [drivers/platform/x86/intel-hid.ko] undefined! Looks like 'select INPUT_SPARSEKMAP' is missing. Fixes: cd8d25841a65 ("intel-hid: new hid event driver for hotkeys") [andy: fixed commit hash above] CC: Alex Hung CC: Andy Lutomirski Signed-off-by: Sedat Dilek Signed-off-by: Andy Lutomirski Tested-by: Alex Hung --- Hi Alex and Darren- I'm relaying this fix from Sedat with a trivial correction. drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index d0bfcf8e8b8e..9d7704e51366 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -736,6 +736,7 @@ config INTEL_HID_EVENT tristate "INTEL HID Event" depends on ACPI depends on INPUT + select INPUT_SPARSEKMAP help This driver provides support for the Intel HID Event hotkey interface. Some laptops require this driver for hotkey support.