From patchwork Tue Jan 31 00:44:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 9546301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9767D60417 for ; Tue, 31 Jan 2017 01:04:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86E6320265 for ; Tue, 31 Jan 2017 01:04:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A54126E47; Tue, 31 Jan 2017 01:04:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E997920265 for ; Tue, 31 Jan 2017 01:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715AbdAaBEk (ORCPT ); Mon, 30 Jan 2017 20:04:40 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:39915 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753689AbdAaBEj (ORCPT ); Mon, 30 Jan 2017 20:04:39 -0500 Received: from static-50-53-43-78.bvtn.or.frontiernet.net ([50.53.43.78] helo=[192.168.1.19]) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1cYMYV-0005je-8p; Tue, 31 Jan 2017 00:44:19 +0000 To: Platform Driver , Darren Hart , Andy Shevchenko From: Randy Dunlap Subject: [PATCH -next] platform: x86: fix silead_dmi build error and depends Cc: Hans de Goede , LKML Message-ID: <8c34389b-9ea3-88af-7d63-db1ca746083b@infradead.org> Date: Mon, 30 Jan 2017 16:44:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap This driver cannot be built as a loadable module, so it should not be built unless I2C=y and INPUT=y. Fixes this build error: drivers/built-in.o: In function `silead_ts_dmi_init': silead_dmi.c:(.init.text+0xf00e): undefined reference to `i2c_bus_type' Signed-off-by: Randy Dunlap Cc: Hans de Goede --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I don't see why the "depends on INPUT" was there at all, but I modified its requirement anyway. Maybe it can be removed... --- linux-next-20170130.orig/drivers/platform/x86/Kconfig +++ linux-next-20170130/drivers/platform/x86/Kconfig @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 config SILEAD_DMI bool "Tablets with Silead touchscreens" - depends on ACPI && DMI && I2C && INPUT + depends on ACPI && DMI && I2C=y && INPUT=y ---help--- Certain ACPI based tablets with Silead touchscreens do not have enough data in ACPI tables for the touchscreen driver to handle