From patchwork Mon Nov 2 02:30:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Azael Avalos X-Patchwork-Id: 7533031 Return-Path: X-Original-To: patchwork-platform-driver-x86@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8A608BEEA4 for ; Mon, 2 Nov 2015 02:30:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B9FE1201C8 for ; Mon, 2 Nov 2015 02:30:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAE76201BC for ; Mon, 2 Nov 2015 02:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751083AbbKBCad (ORCPT ); Sun, 1 Nov 2015 21:30:33 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35466 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbbKBCac (ORCPT ); Sun, 1 Nov 2015 21:30:32 -0500 Received: by wmll128 with SMTP id l128so49250131wml.0; Sun, 01 Nov 2015 18:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=4MONYKX6rQT1G0UL7vxPq6NUnRQNZOEhZVsuVKZFzHk=; b=jQ0FFW/XlV1Gn9vKPEWjf+tFsLYTPL08naygYldH/jPH/Q1lTfuRYAvIef3+3hh5BL DAZrKEk5kPbSNcQ4N1u/ZHhK+3/nrffl5x64RrXQY3VA+1tSp/fkzqDcMWKB2p0LXG3W jQLJbfW7CuXTeMxuefGnFJZb0z1fKQRc6b/L/mvMlIZGRn48mdIsRO+lRv6MZq38nJDl btFldLKoDLKkhjxMc6W2CP8YEsw+cEN4l4CYWSirvEd3TxMu7v1+ZlBdXhbvvCCk7GfX MxrRVEagRQvprg56vZIvA03niewUCizG6OltOMtB2m2j/LElMVDJ4f/ZGTSRISFJlRRs FHow== MIME-Version: 1.0 X-Received: by 10.28.134.134 with SMTP id i128mr11346412wmd.50.1446431430933; Sun, 01 Nov 2015 18:30:30 -0800 (PST) Received: by 10.27.108.2 with HTTP; Sun, 1 Nov 2015 18:30:30 -0800 (PST) Date: Sun, 1 Nov 2015 19:30:30 -0700 Message-ID: Subject: [PATCH] toshiba_acpi: Initialize hotkey_event_type variable From: Azael Avalos To: Darren Hart , "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: Azael Avalos , stable@vger.kernel.org Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some toshiba models") fixed an issue on some laptops regarding hotkeys registration, however, if failed to address the initialization of the hotkey_event_type variable, and thus, it can lead to potential unwanted effects as the variable is being checked. This patch initializes such variable to avoid such unwanted effects. Cc: # 4.1+ Signed-off-by: Azael Avalos --- Darren, Sorry for sending this patch this late, I had a really busy week :-( drivers/platform/x86/toshiba_acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index beb709f..c013029 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev) ret = toshiba_function_keys_get(dev, &dev->special_functions); dev->kbd_function_keys_supported = !ret; + dev->hotkey_event_type = 0; if (toshiba_acpi_setup_keyboard(dev)) pr_info("Unable to activate hotkeys\n");